From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99687A04DD; Fri, 20 Nov 2020 11:55:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABF5FC8B2; Fri, 20 Nov 2020 11:55:04 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id B5D5DC87E for ; Fri, 20 Nov 2020 11:55:01 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 20 Nov 2020 02:55:12 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 20 Nov 2020 10:54:59 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 20 Nov 2020 10:54:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPr/EVoYm+/qhMltHaIQFXBYuYlDpn8ErxwqYcrMtBMbfNwizFDE0XWCyvADu0wfmlrdpBGSfkhuXtbq/0DcNdJ6XCgsJZ3WNZjNzx6wnDmwmr3dYn6plAkQ1BlPV6IFrchfKdDWI+uPRgIKh+GmiT5iX0odWyPckBNMxIrG0sSx2PVrB1nJzNQLkmoWmhkTiJlZvXY/jc3uZyoj5XLl4QBSaWS12sgnIfDEeiYZAoqBXfoPnwMLtDtAon9/QJgnHqJO+uJftYq/jRbH+kaoIHg+Tpm1gFGTz83coLrihDkTnGkuJPpeJ5skrf01A4WxQvsZS6yXkssjifNx6ZPxsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DmKvQsaeKFNMOP4w5QowHnkfP9cP7RVPh7MBm2kjMdw=; b=ZXDovBPqvZKi35M37Z5TOyiQtaQNsxPz5ZrTa7DIEkI1ECfqUeZAqWloo0IhI7EmCU53X94np50qm7UvHPjogU/ZAnuk4jHHtTcP3tly7HfES9E2S7MNUq+SZ3eyP4XocfyLRI0aeyuLAbGap3UicggIeVHaqHPeIZN/7OVAjyRRo+Lq/NWZh0hl0ikOzv0Jbtssq+c0rj4JuIIl03nXLnLDEE5xnHOfkwLgGbkA5sg65dKFfVH1J5vHAnqZ1NBvxmOUy2yZJP3G9/9OnutXsW/meOhwM+OnrhPMqRhFYKKz6pNFBGpq3z0JbdStzzoHDVW1ytDUtOTWBRgSqmu82Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB2548.namprd12.prod.outlook.com (2603:10b6:903:d8::18) by CY4PR1201MB0182.namprd12.prod.outlook.com (2603:10b6:910:18::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Fri, 20 Nov 2020 10:54:58 +0000 Received: from CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42]) by CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42%8]) with mapi id 15.20.3589.021; Fri, 20 Nov 2020 10:54:58 +0000 From: Tal Shnaiderman To: NBU-Contact-Thomas Monjalon , "dev@dpdk.org" CC: "david.marchand@redhat.com" , Andrey Vesnovaty , "dmitry.kozliuk@gmail.com" , Ori Kam , Matan Azrad , Shahaf Shuler , Slava Ovsiienko , Ferruh Yigit , Andrew Rybchenko Thread-Topic: [PATCH 1/1] ethdev: rename a flow shared action error code Thread-Index: AQHWvyNyfVbhR+khAUukUICnAONocKnQ15QQ Date: Fri, 20 Nov 2020 10:54:58 +0000 Message-ID: References: <20201120095438.2620653-1-thomas@monjalon.net> In-Reply-To: <20201120095438.2620653-1-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.118.225] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f563b081-0696-41ee-1ce1-08d88d42b8f7 x-ms-traffictypediagnostic: CY4PR1201MB0182: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:206; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RyT21tKe8NsJZ3FowmfH/Xlpoos0S4aizTgp28winr4qTwxQdgrlBpqG/EqY3f7lY6rz49up4acAbNf6GqD2h77ELp7MQ7ZBjVRCYz+9PhKSLBSAFkUoiPZVoUp3MPieK8ipuYIJy/0W6f0d/aX0DnD4/DSja9gzm1QVN+4DFjj0hsNiLe+u25QLnQ7t7eGxLBEKI5tEO1p11jy41vohNSS8gUiDMAWVACnxGV8O6x9FMohSKM3HHXbusG/ihqfFXkU7VCPXF7PlJXqVAQsmov9OF5rO4xl09nkV1NljqsmKKEBBJ1F/wYFi9P5i5J3d x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1201MB2548.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(346002)(376002)(39860400002)(2906002)(478600001)(7696005)(66476007)(5660300002)(52536014)(4326008)(66946007)(76116006)(66556008)(33656002)(66446008)(110136005)(71200400001)(64756008)(186003)(83380400001)(86362001)(54906003)(26005)(8676002)(316002)(8936002)(9686003)(55016002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: tvszALR7BPv7AQV1C3nex8ONgoe4mBcYCZ/vTFu9fp80TtJv/r5hZv7CvF5lHscEBP7YXn6UNR103m0Ey28Ys+rKZz5drfLPglagbDtLO7M+W4yWk8BKb5+INRPku8cX5eDJKt2xz69swcvzhg2DANjCSiSF57eH9yjWf8jSw8MLD5BNrP7CuOy/kFbBElXQi+CsKLOpNdw0wGhOD97gDhBXBlr2OetJC4EtTQfCjpN4SgAAhiV8eF0Nd659b16C58wLMZ24voj0RyV97l902CinlwYx71w/1VVwq3TtGBnQDjb8mFpHXeGAg8tE4e6oiJxL/FpWUmDzGlaqrHy3dZLsh0e3q7NS68A3XmRN19hB0Spe/RuGpbS2Xcf+kTr5Gxh9/bHNOfTQYyCwJeMjOhuGnkFhXo3wKGqbzbcSE74hcVchTwidu+gqIzOdGxAE8HnLoVX6EQyaW6NLL21Zb2Rjf7kgP8tyCQWVjaRMHsyhTwWzuq2ScD+0EpydT5Btr6Hj1rrxXF437rGIiBZumzk791TUyAJrQj5A7GKq3pxha20oX0+Yh5ZcTQiEBw55BPLjj+7byMmvl06BNT/oKfgvscezkZgF18ait1UHpv+T+NzFygI69ldwXwIIBc+693QvTHvyKyGmQaL0tbvZ4NQ6El7xY/TqBX7gG1U51XeS3oSKbuilkCU2Z/EmkE0hBrSd43wj6B5MnC7LzXlFdqjhR5/QHQSykAV97+TToEO5O38Mc8pavVAuWWf8APMci2wA+W1/kmerm2QQ5oN5uMXuKx3SGrJGmD5xNd1sv1lkU7xeMKOPI2VpHHG3XIDq20omO8UGT37Ujt+pEVQ8Wz8Q8YIrUg5w4c3/GahgKw90v+OZFSb06ABzfOYhyo2hw+WQcL+4CSRsw0wVLprPbw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB2548.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f563b081-0696-41ee-1ce1-08d88d42b8f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2020 10:54:58.1936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mdLCNuqb5FJf3qXq0kf3xjQ6OYIo3KwLpL34XyCqKAOWOMAGj9i/USGOH3DFNISrgPrQfczK/6ZsYIZ9Nomrrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0182 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605869712; bh=DmKvQsaeKFNMOP4w5QowHnkfP9cP7RVPh7MBm2kjMdw=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Bqsv7nQj4nS6tfwrwiqGBKbtA4aM23U1z6bSMYDWeniyPOtqbmUKl4WREgDkhj0Xf aTtQeaCQtjSxlfru5oShc8TVlPDZw6a8jRDJrd/gm7xY3ZaIkTb8PYLyH7RhnvAtNr WAjKaNXrVooxrwLuBk1Y061KJgxgaqismbT3aipcQYKQ3g2jidChc/jWvoD+kaAFHH Ghz75Ghu2VIfgRvJvyHkLsbil/pn5qk2blbCDc3ddRfkMzsm6mZFFkn9uvFbRoS/3/ pHnWL6kHQQb7vPkc/rnxjDQsQnwr+aaPr7WQb2GxU9zs5sIXEMyPbmOBOP7GGgWemz LcpKO6cPsxcAQ== Subject: Re: [dpdk-dev] [PATCH 1/1] ethdev: rename a flow shared action error code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH 1/1] ethdev: rename a flow shared action error code >=20 > External email: Use caution opening links or attachments >=20 >=20 > In the experimental function rte_flow_shared_action_destroy() introduced > in DPDK 20.11, the errno ETOOMANYREFS was used. > This errno is not always available on Windows, so it is preferred using E= BUSY > instead. >=20 > Signed-off-by: Thomas Monjalon > --- > drivers/net/mlx5/mlx5_flow_dv.c | 4 ++-- > lib/librte_ethdev/rte_flow.h | 3 +-- > 2 files changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 62d9ca9ffb..51cc41face 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -11436,14 +11436,14 @@ __flow_dv_action_rss_release(struct > rte_eth_dev *dev, uint32_t idx, > "invalid shared action"); > remaining =3D __flow_dv_action_rss_hrxqs_release(dev, shared_rss)= ; > if (remaining) > - return rte_flow_error_set(error, ETOOMANYREFS, > + return rte_flow_error_set(error, EBUSY, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > "shared rss hrxq has references= "); > if (!__atomic_compare_exchange_n(&shared_rss->refcnt, &old_refcnt= , > 0, 0, __ATOMIC_ACQUIRE, > __ATOMIC_RELAXED)) > - return rte_flow_error_set(error, ETOOMANYREFS, > + return rte_flow_error_set(error, EBUSY, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > "shared rss has references"); d= iff --git > a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index > 8b970ba0b7..b98334c5c4 100644 > --- a/lib/librte_ethdev/rte_flow.h > +++ b/lib/librte_ethdev/rte_flow.h > @@ -3549,8 +3549,7 @@ rte_flow_shared_action_create(uint16_t port_id, > * - (-ENOSYS) if underlying device does not support this functionalit= y. > * - (-EIO) if underlying device is removed. > * - (-ENOENT) if action pointed by *action* handle was not found. > - * - (-ETOOMANYREFS) if action pointed by *action* handle still used b= y > one or > - * more rules > + * - (-EBUSY) if action pointed by *action* handle still used by some = rules > * rte_errno is also set. > */ > __rte_experimental > -- > 2.28.0 Reviewed-by: Tal Shnaiderman Tested-by: Tal Shnaiderman