From: Tal Shnaiderman <talshn@nvidia.com> To: David Marchand <david.marchand@redhat.com> Cc: dev <dev@dpdk.org>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, "Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com> Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for rte_intr_free_epoll_fd Date: Thu, 19 Nov 2020 15:08:14 +0000 Message-ID: <CY4PR1201MB2548D4368B7B1A9878EFB9C3A4E00@CY4PR1201MB2548.namprd12.prod.outlook.com> (raw) In-Reply-To: <CAJFAV8yk6L_sggS1uLb8Gnnt+eQZvMeKJyhOgTOMWE5K6ZWz=g@mail.gmail.com> > Subject: Re: [dpdk-dev] [PATCH] eal/windows: add stub for > rte_intr_free_epoll_fd > > External email: Use caution opening links or attachments > > > On Thu, Nov 19, 2020 at 3:00 PM Tal Shnaiderman <talshn@nvidia.com> > wrote: > > > > Linux epoll mechanism is not implemented in Windows. > > > > Add stub similarly to freeBSD. > > > > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com> > > --- > > lib/librte_eal/windows/eal_interrupts.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/lib/librte_eal/windows/eal_interrupts.c > > b/lib/librte_eal/windows/eal_interrupts.c > > index 6c64a48f34..6f7a1c7acc 100644 > > --- a/lib/librte_eal/windows/eal_interrupts.c > > +++ b/lib/librte_eal/windows/eal_interrupts.c > > @@ -105,3 +105,9 @@ eal_intr_thread_schedule(void (*func)(void *arg), > > void *arg) > > > > return 0; > > } > > + > > +void > > +rte_intr_free_epoll_fd(struct rte_intr_handle *intr_handle) { > > + RTE_SET_USED(intr_handle); > > +} > > This will not be of much use if you don't export it in rte_eal_exports.def, > right? You're absolutely right, thank you for noticing, I'll send a v2 promptly. > > -- > David Marchand
next prev parent reply other threads:[~2020-11-19 15:08 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-19 14:00 Tal Shnaiderman 2020-11-19 15:01 ` David Marchand 2020-11-19 15:08 ` Tal Shnaiderman [this message] 2020-11-19 15:18 ` [dpdk-dev] [PATCH v2] " Tal Shnaiderman 2020-12-01 16:42 ` Dmitry Kozlyuk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CY4PR1201MB2548D4368B7B1A9878EFB9C3A4E00@CY4PR1201MB2548.namprd12.prod.outlook.com \ --to=talshn@nvidia.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=dmitrym@microsoft.com \ --cc=navasile@linux.microsoft.com \ --cc=pallavi.kadam@intel.com \ --cc=thomas@monjalon.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git