From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AD9AA04B1; Mon, 23 Nov 2020 21:15:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F8CDC900; Mon, 23 Nov 2020 21:15:24 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id BC164C8F4 for ; Mon, 23 Nov 2020 21:15:21 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 23 Nov 2020 12:15:20 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Nov 2020 20:15:17 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 23 Nov 2020 20:15:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oELxpriLuDsyFmAg42aQ/xViFoT+kVrSD9O5vbpL5GJRySNz8cmD53GSwY6f5ezcgj3A4OmWAwFs4fGbwKdls70XjwqMV5nyxd5gp05mZ02KaHYl9fbcrkGh02WhWUoiE7A5SwZGy0nG9kqMV7NrP8y+P0jTCfHr2eHv2B4F49lL3Dsnq9N+y+taL0ODPQZtCUzlcgY3GIzqjQwR7ILhuHWqgq697PxgEb9hXjsMI5TKm5OXry11LRXTB0FVb9F2IqXJkEQ7sx8S3dmhR4GITW3lkl3y2m3xkq2xNA2wpvMqmuJW8QuFWBmPxQVDKQAL2CIBiiRCKkAunc2cjdxp3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cflsBP++hzFJTTmCeGyKMv5OhoSXMX3/vH8YUIhREjw=; b=myV+FS6KfRtl8qrGBPpysRAe5SHuGeJpXPnwgxGEhtmrVM0bsvwNYANS1sGlONfI9iQRecRVIgwkGsAXpizBvM0qSJ+tS20kkus+Au3g7VawStaStC3/pqho6aRT3Dd74gq9vWVBowkVOn3m9krrigrFT5kE7gBClkLDO9555qMBOtMxZBsMmRYLSzD+fClkOp9KwvjrCj/VCBetb1DvJHfgg5FbggZrhT/c06HhDZZMC9tn+a00lG2XCUeowfNbdcsYkM6s1KP1Dq01I+r4Aw7M6R/Vv7ROZPJDDIxIAtS/sq0YnOojB0crbIGp037XIM8THe60K/sZveUY77pyVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from CY4PR1201MB2548.namprd12.prod.outlook.com (2603:10b6:903:d8::18) by CY4PR1201MB0120.namprd12.prod.outlook.com (2603:10b6:910:1c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.30; Mon, 23 Nov 2020 20:15:16 +0000 Received: from CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42]) by CY4PR1201MB2548.namprd12.prod.outlook.com ([fe80::e139:246b:5358:8c42%8]) with mapi id 15.20.3589.021; Mon, 23 Nov 2020 20:15:16 +0000 From: Tal Shnaiderman To: Andrey Vesnovaty , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , Ori Kam , Slava Ovsiienko , "andrey.vesnovaty@gmail.com" , Matan Azrad , Shahaf Shuler Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS action update Thread-Index: AQHWwN72z7QjuuB2H0Oyd7KKrycN9qnWJ6OA Date: Mon, 23 Nov 2020 20:15:15 +0000 Message-ID: References: <20201122144952.22008-1-andreyv@nvidia.com> In-Reply-To: <20201122144952.22008-1-andreyv@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [77.137.113.146] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 59279827-c422-4f89-be26-08d88fec7de5 x-ms-traffictypediagnostic: CY4PR1201MB0120: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:901; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FunuNvoIzh9Q8HXBBkYT2NqAcjamyaq0I775V9pabgryzpb8G+majJAN0Sg96AvXF0b3aP8IO/M/LI2nFi5hmpD9Ti5jXFHdD+tb58XuiQrB3bsp/ao4ODQ94+bk4Hm5/4yjBTnTE/B1HXlH7OkxkUe+qpJLCV+yRaGewqKxRxzMwMnes+HCnLDwjLTisY9XA8VckWdadx6AWecFBqZADIVAobp5QFM4/43gUTAYgFlTKUTW4fUZ+kVIdRhCztjMYQlWgmaNfC8CyGh+/aAJ+91r4oSVLDOyK6XEzXUdDhpYMg/0RxJlvzwjEx+J1E7UEjzBSxLCFDjfbzp01igSEQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1201MB2548.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(26005)(186003)(83380400001)(7696005)(66946007)(6506007)(71200400001)(76116006)(33656002)(5660300002)(86362001)(52536014)(66476007)(66556008)(64756008)(66446008)(107886003)(4326008)(478600001)(8676002)(8936002)(2906002)(15650500001)(316002)(110136005)(9686003)(54906003)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: TQLYvH50NZ5aP0Zs2gRejhYXw8MwMeL2g/5a3cJP3lBFpLtfuHczCLVGVHfDGhkEJsVcyz0uzmyT0KafAmAgI/le4S+xB6vqCazlXOecc+jopPM/6zx+C4vsuNrPXVqE1LZq5fvulAWJHMmfgvb9fqrZPDDl7WiIXcBuqhQk3LEw3s5t4/lXBxknbBX5y3zn0Vp5VWchwcRZAFjQ0NQOV5G4FCwSLJ3gmMzQlwSFjr6bF5DoWdsR81pIjkuGIufFxF6e5srFtg6HMCBTYbK4Au6iWHv+c5pSpR9K2xLtQW5AzLxK7GD3a9MmaeUKXGZ4508I9CcxiBqfKQ7brrViqXpw0uQzKB5QSy3fkW6HwGD40eP6YhuGfKscUZmye6scWvlJwcO309fRAcfUFBX1R6oH/A72BSgowcibC0e99p92scdvqzFJDL2D+cdyPCctp52cUTAPJIEAEbqGVe44EeSQZ2m1gOHTCAxZEuaggO+cmduXQ8JA+9K42/7qruiFqBGdt0zty2my0zcT2E2J9bQdwr21ep6jHIONmPh4h/HD5sCh+dJRpf4MIRTqsElU7AqromSfardihJGTYitKZ4FMpv02zP4l8L3xf3NNNM38H9QKxZM/DWlvbu9skFcm5JjjPholJSbZzX0CdSlqOk/5clPuA8Bd59MQk/Y1Ul1PKHcwwuy9BFk5zFmfME7yZ4msm+O4+p0KHFJayZtW1fIU8bxEg/fWp5ZNiww7bR08MZWcl5CYmf/eNQ22hmweE+wy9I1T66bQV00q4tjHXeSj+gtxEAwbO57/s2tCrLZo9l0Af9hWzbqo2x6HAuxVSTUBLX6DEwjyRz318tgl6A2sTwD7zEBVzbqF5tvOfkfuRX5vYyGMZOqMDKeE/x3xgtNHRZUYlVJWirKC2TYeVw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB2548.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59279827-c422-4f89-be26-08d88fec7de5 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2020 20:15:15.7408 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: esNb+JomLrKmL0GVq+FRm4LqQKL3ogW99Qzs5s1b+NpmgXQoW1pSbBs2BauPkGY0uDou+VGXDL+qzDMZYRrjWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0120 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606162520; bh=cflsBP++hzFJTTmCeGyKMv5OhoSXMX3/vH8YUIhREjw=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=lLQwhqT3HrzShZA23Gy5JvqXkptvh/ILjoaUYx/rqWTvkA8dbTUSQK8AG4zVZ3ovp csvac/wCavcd0fHSloVvHdusBIEuvbTsZOp60G+3G03KrtKphhjWZT8K6DIUtM57Hf 3ZYRKn6gMOtuY+wD6ia6WFicw6pm+FsDOoG9r1KEAdmPrRwoI/BEDfBCfFbquUulJn EnlFQmoOJ0HLkIeBssnSSjh6uFncm8bn/VSYaaIWKjLdMiEknigt7Jg/HH77RjdIXF SODTh4PTv2gXMwT/1S0emWgUDrBTo/ABhNrN7VYEYV33zRaZW5mFZMLo5OIDZGDESL MUgKJVBvw9VmQ== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS action update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [dpdk-dev] [PATCH] net/mlx5: fix shared RSS action update >=20 > The shared RSS action update was not operational due to lack of kernel dr= iver > support of TIR object modification. > This commit introduces the workaround to support shared RSS action modify > using an indirect queue table update instead of touching TIR object direc= tly. > Limitations: the only supported RSS property to update is queues, the res= t of > the properties ignored. >=20 > Fixes: d2046c09aa64 ("net/mlx5: support shared action for RSS") >=20 > Signed-off-by: Andrey Vesnovaty > --- > drivers/net/mlx5/mlx5.h | 8 +- > drivers/net/mlx5/mlx5_devx.c | 84 +++++++++++++++-- > drivers/net/mlx5/mlx5_flow.h | 4 +- > drivers/net/mlx5/mlx5_flow_dv.c | 103 ++++++++++++--------- > drivers/net/mlx5/mlx5_rxq.c | 159 +++++++++++++++++++++++++++----- > drivers/net/mlx5/mlx5_rxtx.h | 6 ++ > 6 files changed, 283 insertions(+), 81 deletions(-) >=20 > +11528,14 @@ __flow_dv_action_rss_release(struct rte_eth_dev *dev, > uint32_t idx, > RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > "shared rss hrxq has references"); > + queue =3D shared_rss->ind_tbl->queues; > + remaining =3D mlx5_ind_table_obj_release(dev, shared_rss->ind_tbl, > true); > + if (remaining) > + return rte_flow_error_set(error, ETOOMANYREFS, > + RTE_FLOW_ERROR_TYPE_ACTION, > + NULL, > + "shared rss indirection table has" > + " references"); Please do not use ETOOMANYREFS, the API errno was changed to EBUSY. > if (!__atomic_compare_exchange_n(&shared_rss->refcnt, > &old_refcnt, > 0, 0, __ATOMIC_ACQUIRE, > __ATOMIC_RELAXED)) > -- > 2.26.2