From: Tal Shnaiderman <talshn@nvidia.com> To: Nick Connolly <nick.connolly@mayadata.io> Cc: "dev@dpdk.org" <dev@dpdk.org>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Ranjit Menon <ranjit.menon@intel.com>, "Dmitry Kozlyuk" <dmitry.kozliuk@gmail.com>, "Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>, Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com> Subject: Re: [dpdk-dev] [PATCH v2] windows: minor build fixes Date: Thu, 12 Nov 2020 21:35:56 +0000 Message-ID: <CY4PR1201MB2548FF751C4D20E31B648088A4E70@CY4PR1201MB2548.namprd12.prod.outlook.com> (raw) In-Reply-To: <8b67063a-a9b8-9316-6930-17ee447aa5e6@mayadata.io> > Subject: Re: [dpdk-dev] [PATCH v2] windows: minor build fixes > > > Missing / incorrect '--in-reply-to'. Please ignore - still learning the process! > > On 31/10/2020 06:43, Nick Connolly wrote: > > Meson versions >= 0.54.0 include support for handling /implib with > > msvc link. Specifying it explicitly causes failures when linking > > against the dll. Tested using Link 14.27.29112.0 and Clang 11.0.0. > > How can we verify this behavior change in 0.54 is intentional? I cannot find it in the versions' release notes: https://mesonbuild.com/Release-notes-for-0-54-0.html > > There were a number of changes to the way that import libraries are > > handled between 0.47.1 and 0.54.0. Only make the change for >= 0.54.0, > > leaving the behaviour unchanged for earlier versions. > > > > Signed-off-by: Nick Connolly <nick.connolly@mayadata.io> > > Tested-by: Ranjit Menon <ranjit.menon@intel.com> > > Acked-by: Ranjit Menon <ranjit.menon@intel.com> > > --- > > v2: > > * split out config/meson.build change > > > > drivers/meson.build | 6 ++++-- > > lib/meson.build | 6 ++++-- > > 2 files changed, 8 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/meson.build b/drivers/meson.build index > > 4bb7e9218..6b50f7238 100644 > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > @@ -186,8 +186,10 @@ foreach subpath:subdirs > > lk_deps = [version_map, def_file, mingw_map] > > if is_windows > > if is_ms_linker > > - lk_args = ['-Wl,/def:' + def_file.full_path(), > > - '-Wl,/implib:drivers\\' + implib] > > + lk_args = ['-Wl,/def:' + def_file.full_path()] > > + if meson.version().version_compare('<0.54.0') > > + lk_args += ['-Wl,/implib:drivers\\' + implib] > > + endif > > else > > lk_args = ['-Wl,--version-script=' + > mingw_map.full_path()] > > endif > > diff --git a/lib/meson.build b/lib/meson.build index > > 1bb019720..ed00f8914 100644 > > --- a/lib/meson.build > > +++ b/lib/meson.build > > @@ -157,8 +157,10 @@ foreach l:libraries > > output: '@0@_mingw.map'.format(libname)) > > > > if is_ms_linker > > - lk_args = ['-Wl,/def:' + def_file.full_path(), > > - '-Wl,/implib:lib\\' + implib] > > + lk_args = ['-Wl,/def:' + def_file.full_path()] > > + if meson.version().version_compare('<0.54.0') > > + lk_args += ['-Wl,/implib:lib\\' + implib] > > + endif > > else > > if is_windows > > lk_args = > > ['-Wl,--version-script=' + mingw_map.full_path()]
next prev parent reply other threads:[~2020-11-12 21:36 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-31 6:39 Nick Connolly 2020-10-31 6:43 ` Nick Connolly 2020-10-31 7:00 ` Nick Connolly 2020-11-12 21:35 ` Tal Shnaiderman [this message] 2020-11-13 14:02 ` Thomas Monjalon 2020-11-15 11:20 ` Tal Shnaiderman -- strict thread matches above, loose matches on Subject: below -- 2020-10-30 17:46 [dpdk-dev] [PATCH] Windows: " Nick Connolly 2020-10-31 6:44 ` [dpdk-dev] [PATCH v2] windows: " Nick Connolly
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CY4PR1201MB2548FF751C4D20E31B648088A4E70@CY4PR1201MB2548.namprd12.prod.outlook.com \ --to=talshn@nvidia.com \ --cc=Harini.Ramakrishnan@microsoft.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=dmitry.kozliuk@gmail.com \ --cc=dmitrym@microsoft.com \ --cc=nick.connolly@mayadata.io \ --cc=ranjit.menon@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git