From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 90850A04DD;
Fri, 20 Nov 2020 23:41:27 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E02D8F90;
Fri, 20 Nov 2020 23:41:25 +0100 (CET)
Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4])
by dpdk.org (Postfix) with ESMTP id CDB1923D
for <dev@dpdk.org>; Fri, 20 Nov 2020 23:41:23 +0100 (CET)
Received: from HKMAIL102.nvidia.com (Not Verified[10.18.92.77]) by
nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA)
id <B5fb846110000>; Sat, 21 Nov 2020 06:41:21 +0800
Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL102.nvidia.com
(10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 20 Nov
2020 22:41:12 +0000
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105)
by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id
15.0.1473.3 via Frontend Transport; Fri, 20 Nov 2020 22:41:12 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=Am9TuXdJdoel+i8CiYsLmHih8LVkhwh+Kz5q+eOJ4F0CjTJxgz0Oq3MuQuwsMaj7pgIU1XOxThTFmh4LQqsKQ285YUEwz0iPVowbn9esz3iNNYoS46rcUsFnQBO/8kYLnk85S+TxLtF3cB2N8ih9dTFT6wKs+4uAMIh0RSu0G7DORqYN2FF37vshFmrpxfvG2avyAbpWp4QZSlglW8Gh7rmnD4fBkfwgW8X9hSXRgkcz5oYSZQCOW4xAywRLs5aRfVV+r6CVaCTQlPlKx1f0QhVYXJJ2H+NT0rolwho5znPB/jlTwqo9p8jtmOV74LKGw6Tm+9ogFZQSeySQ0t8nYw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=dZtDxQNZ4kvpCt8/TxXtqsFCNqvOBjJuP2PtQzqSo5U=;
b=P7jg1loMPcGbt6jhcm8PymCJ/o6qZa1hDC89ZWp8kr6ExBVtAau4AQtM0G+pht7JDiUuq5Bk60fv3zQni/LQJ0J3kIowQ4Blfl+0kmfKxhKhSwMD7BFbvkG2OXcWeOFeg8o5hCdrkYryq6Mko7NwmLGVmXbCKRBTmDXz2P5rvA0gkKu9tp86r9hCS1M14yYHRBod4PV+UVwo1UqHoC5tQ+r5B8OsZipJEidwP3lHXfIqBEIyeO1xx2Xn5w8IFBfJt+0ry0ziIbFnr+HAktutGMKFDpgzhjl5co6LaNP9qd9dB8G8bwQar3z0J0g3xkakradT0dAVOeXsce8ICS4sCA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;
dkim=pass header.d=nvidia.com; arc=none
Received: from CY4PR1201MB2548.namprd12.prod.outlook.com
(2603:10b6:903:d8::18) by CY4PR12MB1656.namprd12.prod.outlook.com
(2603:10b6:910:d::10) with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Fri, 20 Nov
2020 22:41:09 +0000
Received: from CY4PR1201MB2548.namprd12.prod.outlook.com
([fe80::e139:246b:5358:8c42]) by CY4PR1201MB2548.namprd12.prod.outlook.com
([fe80::e139:246b:5358:8c42%8]) with mapi id 15.20.3589.021; Fri, 20 Nov 2020
22:41:09 +0000
From: Tal Shnaiderman <talshn@nvidia.com>
To: Nick Connolly <nick.connolly@mayadata.io>, Dmitry Kozlyuk
<dmitry.kozliuk@gmail.com>, Narcisa Ana Maria Vasile
<navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>, Tal Shnaiderman
<talshn@mellanox.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH] eal/windows: fix link error with MinGW
Thread-Index: AQHWv4IcVHqAHmhbb0WhzjY08qkXAKnRmwHA
Date: Fri, 20 Nov 2020 22:41:09 +0000
Message-ID: <CY4PR1201MB2548FFAD5F49FE9FC8D62A41A4FF0@CY4PR1201MB2548.namprd12.prod.outlook.com>
References: <20201120211255.24803-1-nick.connolly@mayadata.io>
In-Reply-To: <20201120211255.24803-1-nick.connolly@mayadata.io>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: mayadata.io; dkim=none (message not signed)
header.d=none;mayadata.io; dmarc=none action=none header.from=nvidia.com;
x-originating-ip: [77.137.116.128]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: deb0d91a-4f0f-4e9c-c1cd-08d88da56031
x-ms-traffictypediagnostic: CY4PR12MB1656:
x-microsoft-antispam-prvs: <CY4PR12MB1656E8F7CB01C0EF0978D86FA4FF0@CY4PR12MB1656.namprd12.prod.outlook.com>
x-ms-exchange-transport-forked: True
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 6sW+632QP7zulVW8X7Qg0hdS4ahEswyDHXkRkWd8nhQ4XecorGp6oDF0xMR8/UQBsIT+d/WZLLr5WVIErcTVVS3fsBqc1hXY93/FDgz/rtmMGr0XaQyAWbEWrgg/iXuIc0Gb4ZwVmW9ldYbLgv7N3MEY0bruaPzKk4s6Thgwn8MXLz/PeUd19OjRJEBMRRQ5NpwA7u0SFEnI1RmHt/3ggSvjDzXyd4E7DTwNtHxWinjsqf2KAIuED/AJRD7mzLMlqNWz0Vkrna6F8J7iUt/9h2z/AM/v1QFB+I+fsUBYxbJwIYzVPS6xqnUv41LIz3PS1X30r4/fOA2d/Vyroc7OPw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:CY4PR1201MB2548.namprd12.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(39860400002)(366004)(376002)(346002)(396003)(136003)(76116006)(86362001)(5660300002)(8936002)(4326008)(64756008)(66446008)(66556008)(186003)(316002)(478600001)(26005)(9686003)(66476007)(110136005)(7696005)(6506007)(2906002)(66946007)(55016002)(8676002)(71200400001)(52536014)(83380400001)(33656002);
DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: Mf8snvQIMYYPZZgfp1fxjH3k1se0o9b4EJTOJe/1bau8ohJt+QPsIxHgnzMi+7sucsmQ9iNhNZlxe+aCXDUVmwj9e5drMNohhrbvG1ygR72I8zIHza3Z5EGym45kb1mkHjcq2EJiUhw17PT56cgZXa4CazmAL24hCPswbCj+qaC/OHRjatFHmwza6rKkSLjpy+hi5y+J+v1tllCggvTDMtHRSwBpNr4PcOV55/wsVNXSk/AGXx/lOJKy1K3QdURzedQKKa/NFrQ0odNuxTzm3ZysV76TIqwXDEHfmVNyHWsx1EBrjPOmOePd3JTPw0WiXdfhwJLOydPbR8wwhob8pqfMrmaI1tze3U6hvGynXagsUDLAiUsZj/dMZ7khIrJ2Efew/QdrPBFU3pGWpt/T+FI3r2jOQLcB6gYppve/JvTikPKUTsMUAT+XcWeAlFP6F7vHs+MXZOhO4iFUEERTNCrUOF48bpg+/SVvs+XAXaoSJJMwWWGbJgqmQrsjFYd5m48/FCu6KwNuGzhUFiX5a+2DBRptLWhsXd3pedifAjpUmJKinCAbIFNsd4nhzFa1Olr/167oEAxNyHQrMXVnc4luuMxBaZiqOXjh+EtYRkIpoC0VyMfSmQ/hMc54zyeNM8kAd3T3OflNreEAwD/urXvwaBRSqukiU5PE97Cv629seFOysmY5QYTr4qu5uDTEHiV/F1N0v+tth9B337ZN9qy826GflqOCbQ1h1pS+IMAtUvBr877wS/CbPGTs9KxIOjna/UpQlQkSYbP3cKWFRTjBURJsgojppU1kEXjfOI8qF2EBciZFbgsxL0SP8g+Tz2kTzqkQCIGGiM/h03nIeF+FmLAziBoDfGeX84Sq0ZCIYeRWRoSK3M42LxaIj/q1cYFIDSano1tqBXfrDH9qOg==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1201MB2548.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: deb0d91a-4f0f-4e9c-c1cd-08d88da56031
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2020 22:41:09.4439 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UVkBwvEAXpj8yAXuZ4qBqF4K7zFabc1/8GFo51LgIpe8bqNT+fi0PRZUAOk3Hx7MBp2UGb+k/JsnvvroT2ARXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1656
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
t=1605912081; bh=dZtDxQNZ4kvpCt8/TxXtqsFCNqvOBjJuP2PtQzqSo5U=;
h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:
CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:
In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach:
X-MS-TNEF-Correlator:authentication-results:x-originating-ip:
x-ms-publictraffictype:x-ms-office365-filtering-correlation-id:
x-ms-traffictypediagnostic:x-microsoft-antispam-prvs:
x-ms-exchange-transport-forked:x-ms-oob-tlc-oobclassifiers:
x-ms-exchange-senderadcheck:x-microsoft-antispam:
x-microsoft-antispam-message-info:x-forefront-antispam-report:
x-ms-exchange-antispam-messagedata:Content-Type:
Content-Transfer-Encoding:MIME-Version:
X-MS-Exchange-CrossTenant-AuthAs:
X-MS-Exchange-CrossTenant-AuthSource:
X-MS-Exchange-CrossTenant-Network-Message-Id:
X-MS-Exchange-CrossTenant-originalarrivaltime:
X-MS-Exchange-CrossTenant-fromentityheader:
X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
X-MS-Exchange-CrossTenant-userprincipalname:
X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
b=eUcayV/KZFNC2vGB8sYo0dhYP3m9NfAcgONnuBMf463OqycFJUzq+nUIC3zghiwgk
s3BgiXTdkalluoh7wyfn99mADIROvv7AJJ9KVdj0w+dVHVJOoLD/rh20c3Aidumom3
5o1FT1Jd87wJc8hVhppd/FnyOZ2SqKrTNKbMKKyPb4+2oMsJzsCV7SH38etA+plk77
3QtVJ+hLYQsnR0mSLU0rKJdre1RLPz8jj/4WXAgTgnRurQYr6UjIpurnL/3ty/LF2X
mlzwgR440BAaDhKKlKeHE/H+NlvaFf7ybDMR+gOCjy/Fl1Lum65g+TC5XxnRcgRiY5
YjIFMjNqAZvtw==
Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix link error with MinGW
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> Subject: [PATCH] eal/windows: fix link error with MinGW
>=20
> Linking with the 'pci' driver when building with MinGW on Windows fails w=
ith
> undefined symbol 'GUID_DEVCLASS_NET'.
> This occurs because devguid.h is included in rte_windows.h before INITGUI=
D
> is defined.
>=20
Hi Nick,=20
I can't seem to reproduce the link error you've mentioned (I'm building hel=
lo_world on master).
can you share more information on how to reproduce it? (MinGW version, buil=
d env variables, build OS).
Thanks,
Tal.
> Resolved by moving the include of devguid.h after the definition of
> INITGUID.
>=20
> Fixes: b762221ac24f ("bus/pci: support Windows with bifurcated drivers")
> Cc: talshn@mellanox.com
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> ---
> lib/librte_eal/windows/include/rte_windows.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/lib/librte_eal/windows/include/rte_windows.h
> b/lib/librte_eal/windows/include/rte_windows.h
> index 0a5e71a05..b82af34f6 100644
> --- a/lib/librte_eal/windows/include/rte_windows.h
> +++ b/lib/librte_eal/windows/include/rte_windows.h
> @@ -25,13 +25,13 @@
> #include <psapi.h>
> #include <setupapi.h>
> #include <winioctl.h>
> -#include <devguid.h>
>=20
> /* Have GUIDs defined. */
> #ifndef INITGUID
> #define INITGUID
> #endif
> #include <initguid.h>
> +#include <devguid.h>
> #include <rte_log.h>
>=20
> /**
> --
> 2.25.1