From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0045.outbound.protection.outlook.com [104.47.40.45]) by dpdk.org (Postfix) with ESMTP id F26AD3230 for ; Thu, 3 May 2018 08:02:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6K5D8PA+YaVVWM3CLQ8k3NbGRzoknjKkRWA6K/xxpYs=; b=A4CMvDfM9mdHc0J2eDTZTTSZfuX2gjOIRENHArpxV/McafiqBV1bIxjBEU5iPVLCLxuX36TRSgRsWbxNM5RI22n+8VY1jTFc6Dw4JdgYmNaxjlo0/PLgyGtSV4ykyMETCfBdM7XBxAMjR8MVH6HWuG6RU78UFmLgpnY5aVB/ttM= Received: from CY4PR12MB1509.namprd12.prod.outlook.com (10.172.68.22) by CY4PR12MB1669.namprd12.prod.outlook.com (10.172.72.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.15; Thu, 3 May 2018 06:02:00 +0000 Received: from CY4PR12MB1509.namprd12.prod.outlook.com ([fe80::392b:5a94:99ce:33b8]) by CY4PR12MB1509.namprd12.prod.outlook.com ([fe80::392b:5a94:99ce:33b8%17]) with mapi id 15.20.0715.020; Thu, 3 May 2018 06:02:00 +0000 From: "Kumar, Ravi1" To: "De Lara Guarch, Pablo" , Thomas Monjalon CC: "dev@dpdk.org" , "hemant.agrawal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo Thread-Index: AQHT2nXFE6JwOvL1WkCkb8yOh792paQN5uhggAAX8ACAACFYAIAPc1QA Date: Thu, 3 May 2018 06:01:59 +0000 Message-ID: References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com> <14946114.ASIPbkMQcp@xps> <1698373.c9XDPgIzTm@xps> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [202.56.249.162] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR12MB1669; 7:itoLhYl1Ldo1oQK6ix3f4pBgfKPxU9YX6F387hwUPg/5mPEScuFjEHzjDJHI3MVcUtMIiAw82HC/YggAY3r6TbNLNrWY4KRLK2blUmp6iRce0JmhX8XCavkGGvDaB72RkX9rrsCbY8Hb5nN1CnNt+onhV+gflDuQjbaIOeIH4FtjTz8YPC+WEteIcz1wsRM66S6NHJ7tYilfJEUK6R4O3AdFnnecug24QXaITaB/58OeTiKKQfcRfDePbe2VuaRe; 20:lr6y3zhpiIC/+O1Hy8HuF33wnCvYgANVelenwIoW3AMn5UzkTy/xK9cbW0xZM+9EI+5H+FR4QI0Xz8JRcn9wH76UcARCri9BN3Zv5JG61ZkKCuZ17URCDuTTiBM8m5U+YeedlEcyiBL7+cswyZv4E4ilwyjb+zAk/eZ7SbXbfut1Mh+AVLNv16CNUxtmq7JYhb0xZnxKe8gYHhgqNEBlAymq4F5QMBRwBTf9hCk3JrYPN0Gr2HOhZbvnHhtC06oE x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR12MB1669; x-ms-traffictypediagnostic: CY4PR12MB1669: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ravi1.Kumar@amd.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(767451399110)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(6055026)(6041310)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR12MB1669; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1669; x-forefront-prvs: 066153096A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(39860400002)(39380400002)(366004)(199004)(13464003)(189003)(6506007)(2906002)(81156014)(7736002)(6436002)(14454004)(6246003)(3660700001)(59450400001)(68736007)(2900100001)(66066001)(74316002)(8676002)(186003)(110136005)(9686003)(93886005)(55016002)(105586002)(4326008)(54906003)(53936002)(81166006)(5250100002)(25786009)(8936002)(3846002)(6116002)(8656006)(97736004)(76176011)(86362001)(102836004)(11346002)(72206003)(106356001)(33656002)(316002)(476003)(99286004)(486006)(5660300001)(26005)(53546011)(446003)(7696005)(478600001)(229853002)(3280700002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1669; H:CY4PR12MB1509.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: lxjo5g7mB6B0Fflryh9sCgGUWlbonwitYNR+MA2p6nMN7bZZ60tvJl5pRDiSYxo2kDhhxSZyGXGgcGmFunrVhCXzaXsTj/VRIIGpvYV8JK9xqZdpQxTePSdsjdNw9aa5sKvtl853SndVczcM3MpIAgROGqRaH0ukh4tBbRONx35Vs9jzQbodBCppgLtWf0TL spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 7de2ef90-aa07-4e7a-fc5b-08d5b0bb6292 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7de2ef90-aa07-4e7a-fc5b-08d5b0bb6292 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 May 2018 06:02:00.0247 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1669 Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 06:02:03 -0000 >Hi Ravi, > >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> Sent: Monday, April 23, 2018 9:06 AM >> To: Kumar, Ravi1 >> Cc: De Lara Guarch, Pablo ;=20 >> dev@dpdk.org; hemant.agrawal@nxp.com >> Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based=20 >> md5 and sha2 family authentication algo >>=20 >> 23/04/2018 08:41, Kumar, Ravi1: >> > >> +CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dn >> > > >> > >Why introducing a compile-time option? >> > >Can it be a run-time option of the device? >> > >We must not add compile-time device option if not well justified. >> [...] >> > By default, all the crypto operations (cipher + auth) are offloaded=20 >> > to CCP >> engines. When user enables CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dy, the=20 >> auth operations are not offloaded to CCP and rather performed over=20 >> CPU. We kept this feature as a compile time option in order to let=20 >> user decide whether to run auth operations on CCP or CPU as some of=20 >> the auth operations performs faster on CPU as compared to their performa= nce on CCP. >>=20 >> No, you do not let the user decide. >> The compilation options are for the packager to decide. >> The user can rely on pre-compiled packages and use only runtime options. >> That's why we forbid compile-time options for such features. >>=20 > >Could you send a patch to remove this compile-time option and pass it as a= n option for the vdev? >Look at how the crypto scheduler accepts parameters from "rte_vdev_init" o= r --vdev, in scheduler_pmd.c. > >Thanks! >Pablo > Hi Pablo, I have uploaded 2 patches for this issue.=20 If needed, you could squash the patch-1 to our very initial patch (commit 0= 054d84f6ec8: crypto/ccp: add AMD ccp skeleton PMD). Please let me know if you need any other information from our side.=20 Regards, Ravi