From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0088.outbound.protection.outlook.com [104.47.33.88]) by dpdk.org (Postfix) with ESMTP id 38B352BCE for ; Mon, 23 Apr 2018 12:41:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=WrPbsQu9zZiMOBTY1mNgskUIn3ifrNEwIZdP6EnuvGo=; b=B60bBt5HFi1juZl6R4ubMhBGhOnSGb8lvbZNmG/A2/hpJ2bEl5fQ5VC6itOGVHwDUR+SXSHXZjqAYUYWKuxnf1hY/Dg672bmSI7RJCU/IHK6oPW000Uy1w7sk3P5iSKqr7jOweThAjDSREtMJoL4X7+22LkAhQGBHnooWydJTFU= Received: from CY4PR12MB1509.namprd12.prod.outlook.com (10.172.68.22) by CY4PR12MB1909.namprd12.prod.outlook.com (10.175.82.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.14; Mon, 23 Apr 2018 10:41:16 +0000 Received: from CY4PR12MB1509.namprd12.prod.outlook.com ([fe80::d52f:887:8f07:7479]) by CY4PR12MB1509.namprd12.prod.outlook.com ([fe80::d52f:887:8f07:7479%18]) with mapi id 15.20.0696.016; Mon, 23 Apr 2018 10:41:16 +0000 From: "Kumar, Ravi1" To: "De Lara Guarch, Pablo" , Thomas Monjalon CC: "dev@dpdk.org" , "hemant.agrawal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo Thread-Index: AQHT2nXFE6JwOvL1WkCkb8yOh792paQN5uhggAAX8ACAACFYAIAACgdg Date: Mon, 23 Apr 2018 10:41:16 +0000 Message-ID: References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com> <14946114.ASIPbkMQcp@xps> <1698373.c9XDPgIzTm@xps> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; x-originating-ip: [202.56.249.162] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY4PR12MB1909; 7:BLvEU8de2arnrPb+KD9k72WDqNrqpn70LqTo22L9yaDFgDThGKVFTwYBxZFVXCtjinbZnueMpvmafHVt/XTIZuC50eqDMoiE2hQD2qmLf3VKPpjo97HXH9CJZviAWSU6BskCvelhmcL9EXd2Waa87ptEKbAcJ7jQhOk3YP+pF4HsWk1sXO0SeVpwEIjSf9y98NeSbsm398aX2MiiySXG2ilhlPgNQ0hdvQ4vvgXkD404aHwCk1tXAz5jL/QGMWCY; 20:R+3a5uoUp8XBXLmuoMCMH3qINnALCHa2ebd1wqBzfY9Ik7BpH4Dyt0EwefQCbm6hC2eGDiZqrpPE+3ZuQU8YvBmPoPb/XWJ4ex5uuRU67mLJx3Z06rET7B9dNz4VwPpT3drmKo9OZKuAaSdML3c4IYD1UpBakX1sanoHkbKxNCOYMJYS9dFt6SZoTa1q3UPToIpGIIUnNOX7MjNnycOlZEPqy/Oe/gFbhTgw1z1uGpXieEAV44Y+HaO1z5HPtmH2 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:CY4PR12MB1909; x-ms-traffictypediagnostic: CY4PR12MB1909: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(767451399110)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231232)(944501410)(52105095)(93006095)(93001095)(6055026)(6041310)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:CY4PR12MB1909; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1909; x-forefront-prvs: 06515DA04B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(346002)(376002)(366004)(396003)(13464003)(86362001)(53936002)(5660300001)(229853002)(93886005)(186003)(4326008)(2906002)(6246003)(3280700002)(9686003)(478600001)(55016002)(3660700001)(110136005)(8656006)(8676002)(74316002)(72206003)(102836004)(8936002)(26005)(66066001)(316002)(476003)(11346002)(81166006)(54906003)(33656002)(6116002)(3846002)(305945005)(2900100001)(7696005)(5250100002)(25786009)(59450400001)(446003)(7736002)(6436002)(76176011)(53546011)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1909; H:CY4PR12MB1509.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; MLV:sfv; x-microsoft-antispam-message-info: kFPZyh8BpnVwVBM3s6ysDGCVulaYJfUmBKXwMODH4UqtkRER1k7Eaeh+I03PaKJ0KpWeF/HpiTC3QG361RSoElnJqhxO/S7dCycqqmzmnC1syllsE2squupOJoEeXvZhxygtqsWNUsAnSnZHG8at4KXvQLfM+8xiXtSFK3BeiVSsLYGBtHu4P7zuPabbHVm3 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 97e1b228-45ab-406e-b21a-08d5a906bde6 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97e1b228-45ab-406e-b21a-08d5a906bde6 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Apr 2018 10:41:16.2766 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1909 Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 10:41:19 -0000 >Hi Ravi, > >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> Sent: Monday, April 23, 2018 9:06 AM >> To: Kumar, Ravi1 >> Cc: De Lara Guarch, Pablo ;=20 >> dev@dpdk.org; hemant.agrawal@nxp.com >> Subject: Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based=20 >> md5 and sha2 family authentication algo >>=20 >> 23/04/2018 08:41, Kumar, Ravi1: >> > >> +CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dn >> > > >> > >Why introducing a compile-time option? >> > >Can it be a run-time option of the device? >> > >We must not add compile-time device option if not well justified. >> [...] >> > By default, all the crypto operations (cipher + auth) are offloaded=20 >> > to CCP >> engines. When user enables CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=3Dy, the=20 >> auth operations are not offloaded to CCP and rather performed over=20 >> CPU. We kept this feature as a compile time option in order to let=20 >> user decide whether to run auth operations on CCP or CPU as some of=20 >> the auth operations performs faster on CPU as compared to their performa= nce on CCP. >>=20 >> No, you do not let the user decide. >> The compilation options are for the packager to decide. >> The user can rely on pre-compiled packages and use only runtime options. >> That's why we forbid compile-time options for such features. >>=20 > >Could you send a patch to remove this compile-time option and pass it as a= n option for the vdev? >Look at how the crypto scheduler accepts parameters from "rte_vdev_init" o= r --vdev, in scheduler_pmd.c. > >Thanks! >Pablo > Hi Pablo, Yes, we are working on it. Regards, Ravi