From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83E36A034D; Mon, 7 Mar 2022 07:04:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 269CA4069F; Mon, 7 Mar 2022 07:04:18 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2061.outbound.protection.outlook.com [40.107.96.61]) by mails.dpdk.org (Postfix) with ESMTP id 3C45C4068F; Mon, 7 Mar 2022 07:04:17 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G9vSeOUsx7RCxRu/3lZDtmT9N4/m1T6RsjgDpD7xOylrd+z4N8E5pjODJq3vASAY6Wi3WptGlYn6gxWgeMbVPT1HBGazD/pv7ZbVG+89cAhedLIgHJEupY5X9Ia6cbIAH46MxGhWo1TtWEmz+Wi8jb976A8vjcvntBIXtYKbS+wLbvxF06ESq4Ky032eh2+dtALopvIMYiMgs+OnwGv8Ojx/ajnjMJLj8Lp8Tfcu9FsE5VPd16wrS1UwxDZ7gEdORYBSgiOUqtryK5VpuxLooIMFietSECV4lOThhmFweldAPK4hkEz8cqZRiJNxZzPwyJz0/+aL4AsGwlVjphlh0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dTnUqZ+fJCphjbN0qZeQa3dCQ3X3b99YtIFpR+rcqWo=; b=A155ClydwORGYsJf2dzVeUGQrgf4yL26Bx60HgdZZLUKVzxugCjbL3skqygsElQYyn5YxH4nXP+n3Qt4buNOZWikVAx7mbRecbogt+rGGjfRWWPvcSy5zei+uzmT8dnCJpBtXmbZM4V6WToL9uQkL4WpghnbMk3ckMKw/wOVDSn1JgKKPUMeUOBDjgc1HGfTHvXnd9h7N1M9FNciuapVipXMYuDJdvUmfOXB5PF1bcruz7yqwBIXPLAGF/JcRWGXKuUewGCZmOMMf5mM6co5ICxf5AOlZlR2lcjlLw3Mf8qPbHbco5OUCDvAgcIGCJsa6w3/wr6COMIbInVP5Y3XMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dTnUqZ+fJCphjbN0qZeQa3dCQ3X3b99YtIFpR+rcqWo=; b=GO1zvVpI0cDNin9P4I0Jalsim/iMs+54WUDybqXpy/inYc6Ds3UUg8qab1ko0ClqUB/UMEFOtZNXQZJHD6rKQeQSHs8WNYuZeT/chq1IPxLi8LN7cD5/N9sT4ZbB1eycmZFC7dRqURFZnA2AfVZ5jFr4jcfvJrJVplfM9tDAD+gCDccL+BDJtCrTcN5QA/n4lOMOZk3jAC0ogqK28718cvntz92TlCRQaU0/0AF9lMXBOCVfIs7Xnmhw3jo25e1ky2Wca2f9SM7LaynOWwhEy/iggmS4RYGkiuNy1v+HOaEhCnkgJrmQm8HTl5R0eiXIcHroT4RcpMe2akZZzEvcHw== Received: from CY4PR12MB1575.namprd12.prod.outlook.com (2603:10b6:910:f::23) by PH7PR12MB5733.namprd12.prod.outlook.com (2603:10b6:510:1e0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Mon, 7 Mar 2022 06:04:14 +0000 Received: from CY4PR12MB1575.namprd12.prod.outlook.com ([fe80::7583:55e6:ad4a:4d19]) by CY4PR12MB1575.namprd12.prod.outlook.com ([fe80::7583:55e6:ad4a:4d19%8]) with mapi id 15.20.5038.026; Mon, 7 Mar 2022 06:04:13 +0000 From: Gregory Etelson To: Ferruh Yigit , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , "stable@dpdk.org" , Slava Ovsiienko , Stephen Hemminger Subject: RE: [PATCH 2/2] net/mlx5: fix INET IPIP protocol type Thread-Topic: [PATCH 2/2] net/mlx5: fix INET IPIP protocol type Thread-Index: AQHYLX/Oph5iDK2zyUqd9qW14OdOa6yt1pCAgAWZ6EA= Date: Mon, 7 Mar 2022 06:04:13 +0000 Message-ID: References: <20220301151856.17341-1-getelson@nvidia.com> <20220301151856.17341-2-getelson@nvidia.com> <67896084-e08e-4615-8992-84524f220b1b@intel.com> In-Reply-To: <67896084-e08e-4615-8992-84524f220b1b@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf2f1c6d-ec32-4ad5-95e7-08da00004e3e x-ms-traffictypediagnostic: PH7PR12MB5733:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: asxI3qRYb6sJ0SKtcAUyi6NvOyGhVjAiFh8K2TB+nVnceCIgA+amHeORQwB+4WcGtMQbA7sLOvDbjdICUc56INJ9IB+ZyVUdyvAyz2PoN7RA8HzdbiGPqJ0WEWoyqjTWo5wvHemfYJNWkxmFBp0IQtgk/BkE9e0DzsYuryBq/Z+T1YdCbB7smjIMHcYWbrmzIGnnwpg/9p0pFk5Z072l5nkJ1jRAwCuSFQ7rHWEHeUIOLAYzFQ2z+0JdJ/cZRGqB2VQdVRrqWHVTBjdt3yG0zhJ83P5MxDlFCAXj27O359TgDoan9W6L5E6uBB2tZOiowD8DTyypeAmBDOdah8Rhc4I4jdOXP/gfBXXMtwfJctpplJCMbUVE4fVkIgcXlMerb5BwtJNs/FU5lVom7QJ/p68dwjWGfmssTdr0fn2rAn+hgRON04MRPJt9BhRL/lx+8OHRkmNfwC6rEpN8vUHzBibAUCQ4fzKjGJL++tM28MoSFBBZVH2x46UE65BS/CO0H5GXFLtMDzBBQ8l6HjtVhYBwn+kivV/UAa8WIx0pmVgcZ2wuySpq7viaURaOKgUwbgnRoHT+EE7jlFVm50sADu/l0/6FPekflsAOpP9MTfztm0EZ48/Xm9N4azMEDNQwliMudhHRw8z8FlOhjL4EcwXTlm5PdU5fhz+BUHqx39t64PaesyeBwTHN6Jd5+o/cwl9eJK4xZyiwdlRSorZZHw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR12MB1575.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(66556008)(4326008)(8936002)(55016003)(66946007)(66446008)(8676002)(66476007)(64756008)(54906003)(110136005)(186003)(5660300002)(83380400001)(52536014)(122000001)(86362001)(2906002)(71200400001)(6506007)(7696005)(9686003)(33656002)(508600001)(76116006)(38070700005)(316002)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7avaykrUeRDiuaNO+93yAWkWqQ5spAgTMIA7rJTRYNyjIwDsMUvXU5N3XPvM?= =?us-ascii?Q?OvnXFrUT33phr6tsQdDYYHXrc1XsMWQ3w15628/6rxBVlkn5PGPXsWwNjknY?= =?us-ascii?Q?cnstQDj6sbdzqkafE+7R+m5DdEV7Q9MMgZfdmnQDyEcqzwIT9/CcF/wGAkgx?= =?us-ascii?Q?6FLRax33+MBa62GFPheltXGIJ5r7Bl0T2JLBKTlcBvzxZTJffWagnmmT+REU?= =?us-ascii?Q?HivSMjpSHenCObaoEqybYZVb2IsU09fn1ekD9ZXnnnubEF6cNWc899I8GBsH?= =?us-ascii?Q?FBOXzGk4cVcaJ7ikA45GaR1V19UnjNKYoHGak3B25GaNpo8fLglNMh29Kl+C?= =?us-ascii?Q?c6n/rhvjHKipUZbfnacpcol7ZtNi0Xw4NthL/yHMF+TW10vdioKRYBDCd6Mz?= =?us-ascii?Q?yvpO5AR7Hkb9SbJFx7TKwy7Zv45SXehlHGvpfsyf2bHaVpqsghC6Uemebyou?= =?us-ascii?Q?4bfvUiWpe7GJL3AujAdu+1axJDSqUkeUVbEDlVsBzwHRj6itm5wVh5URtzJc?= =?us-ascii?Q?6yMNC/puZsJnVDOL5oOql0wwfd8O5QGVYQQvgeWpb52JXwhDToHoADIQ+sGs?= =?us-ascii?Q?IZJd+uE7uIrfW2v2XZxceqbarBhdxchRtTdBhJLTNcvw0NcJzETt7/LAFIFq?= =?us-ascii?Q?pc4yYRKKXsp1VchpcZgiLabIc/1ui1laFZQGian0bwn5tDiItIfOsgzO/cDO?= =?us-ascii?Q?3d53LTLLm+sa7HDpwpFJ3D5c0Mn6w86EgWVGCJvNggs0J7NzLIxgZ8Ru3nIo?= =?us-ascii?Q?CEjoeY+Ymc+yyDlnnrVQgXxPTAhFzssxr6E+iD5Frsv5upc+mIVIhP0fG/aC?= =?us-ascii?Q?jfxT/S8WXrSeGmUR66dz0h0qQIEDN6hjBZBG1wq6kxv96yX8iaZqfV+BGqfz?= =?us-ascii?Q?AOl8j51iYujhdjecIGHAOWNH+TOoaKzsMfPrOoYJO87gaN+7h0638ehodo1m?= =?us-ascii?Q?XQOtI18k4ELmvbgvM0pf0lk3K8XFjtNxAmcbI7ajEKORdRF4dOUwsWKS+Vvf?= =?us-ascii?Q?cdripfbz+9juu68WgDvntzMFQ6KjikyN6yFA2udIDv/ThT0PLzXAmUEWxRJc?= =?us-ascii?Q?ZQRHXKHDhHjc6V9KKEp+bwfULwLQayRuTFQvmg+AeJkxSA9Iv4CAcjaql8by?= =?us-ascii?Q?LR1pJn39+TX3nbfyenssYss3p2GQWFnwFKnjNeEtu28qgtCKpyOjUD2DiIzd?= =?us-ascii?Q?iDo2DbByCk+OfS8pECeubf2EfTnd4FvZtNpN4vOgCP8MabXI+81hCjZKb3NP?= =?us-ascii?Q?oYqHLXUkUWr7EPpIt2ClOHIt6PPON0pHkLh8c8HpF2vgwlz4mu/MEa4pLvvF?= =?us-ascii?Q?LOKbKPLOu8sN4R0xyCkwC9NktnuHvrtIML8rjohARQdcjA8YVjQxHF78rzva?= =?us-ascii?Q?2uR1L+WGJAeMohUsX/XZ8LSxo4brvqdbF7veYsMZgD2EnyLc8LTw+fb9B4eH?= =?us-ascii?Q?Vn2Y3VxidEp7IQnhEvYPVA7jjQT0PWm16+heNAtWwexgkMPtDSxzrMkp/XzH?= =?us-ascii?Q?GCyWQwo/U6yHmsMB5T4D/JP7Vn9b+e8IqokCTQfrqKF2RKWKgjTdWuN+QHz/?= =?us-ascii?Q?TQBHLLtl1ZR4kxCDALHjKX565uUTrOYrdI75cx8OjHvXgk+eWwVh0yrBBPuq?= =?us-ascii?Q?TmIHejlBwImyO3E4PzR976Fn0ho2IA+IxJ7GqUnW4TvqIKRYwoRn3Tvd6m4S?= =?us-ascii?Q?ThEJ0JFzrXbRDb7fOfTfM0vczpY=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1575.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf2f1c6d-ec32-4ad5-95e7-08da00004e3e X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2022 06:04:13.7821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E5bgvs9YYSBuXo20S3XeAWU3fQABCzmv2qcgHU0ZuUAH8NQfqeN6zxPAnLAsg55j6jGlEdr4bLxZdOQWCmm3JA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5733 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ferruh, ::snip:: > > Fixes: f3f1f576f438 ("net/mlx5: fix RSS > expansion with explicit next protocol") > > Signed-off-by: Gregory Etelson > > > Acked-by: Matan Azrad > > --- > > drivers/net/mlx5/mlx5_flow.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > b/drivers/net/mlx5/mlx5_flow.c > > index 0d774cfd19..efb988a9bb 100644 > > --- a/drivers/net/mlx5/mlx5_flow.c > > +++ b/drivers/net/mlx5/mlx5_flow.c > > @@ -208,7 +208,7 @@ > mlx5_inet_proto_to_item_type(uint8_t > proto_spec, uint8_t proto_mask) > > case IPPROTO_TCP: > > type =3D RTE_FLOW_ITEM_TYPE_TCP; > > break; > > - case IPPROTO_IP: > > + case IPPROTO_IPIP: >=20 > Hi Gregory, Matan, >=20 > Are you sure about this change? >=20 > In linux header (include/uapi/linux/in.h) it is > defined as: > IPPROTO_IPIP =3D 4, /* IPIP tunnels (older > KA9Q tunnels use 94) */ >=20 > And IPIP tunnels as far as I can found [1]: > IPIP tunnel, just as the name suggests, is an IP > over IP tunnel, defined in RFC 2003. >=20 >=20 > Since type set to 'RTE_FLOW_ITEM_TYPE_IPV4' > in this case > statement, I would like to double check if this is > correct. >=20 That code is part of MLX5 PMD RSS expansion model. The code returns RTE flow pattern type of the next network header. In case of IPv4 in IPv4 tunnel, next header for the outer IPv4 is also IPv4= . Therefore, the code returns 'RTE_FLOW_ITEM_TYPE_IPV4'. Regards, Gregory