From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46AEFA0577; Mon, 6 Apr 2020 14:33:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 980811BED8; Mon, 6 Apr 2020 14:33:48 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 83FD22B83 for ; Mon, 6 Apr 2020 14:33:47 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 036CUadW022344; Mon, 6 Apr 2020 05:33:29 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-0016f401.pphosted.com with ESMTP id 306srm5fkv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Apr 2020 05:33:29 -0700 Received: from m0045851.ppops.net (m0045851.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 036CVrKO024058; Mon, 6 Apr 2020 05:33:29 -0700 Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 306srm5fks-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 06 Apr 2020 05:33:29 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 6 Apr 2020 05:33:27 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 6 Apr 2020 05:33:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mHQVScDgcPc60CTje1AqlCQAa3GDitFjOlbFDOLAgOTYXPk9xxqCBZLK6JFsqrjIMECq8A7fZ/aKlBqJx7EcWyY/4QVs1AJvQp9hz5RAqKbHeVeJVfRc6yii7+M8/w2i2AVCHNSohKLrKkNNJP9WjRwhwEWR9jOxLOfAbLpFxKvYHvA9DCxy6lBJbeFPNfp69eNNdjtWm35AFkg5NxDv36EFASsUsdHMmE57zyTOf4wmudBPs2Y9pQvVbcCvnyY/ZDevi3XugJR0UYGwXokj/ftUgXgtd08Sp4lOxh9+CwEbVaih5l+kLoTcYaZpczB7q9F12poGHWjV86yso/BRnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGBZMn8ByPKcqMSf6kz3SbV0IgmV/jv+3U8gDGIL1ao=; b=FXkCJTV/IrV+pSik9+q/htmi2oiVjggamH0C+4Xwbd0Co13eL0GXyB7yk7R/jgR4pjnBwFQpi7X/saVVZOSym/xJV4+uboCcUwTFyTbxu0YeH0/EREY4qIGHe8jHtHJQ9D+RKiuD5RPONr3VwzUzhdwur6zUeBgr9BZ96X1+MssdbPx7p0zvUVHA6zcxB4Ksd37yAr/skFK2a9/iWzFNsee0amNqa9k9Q0rqim45J3fmRRGUwHtOTohcrKRAd0W9gZiPa2QCGIzvJFHonPfyM03SR+EjraxBv0xEGd28Jveel8RoJy86v/6Hz0obJM+Bh3x/jUPq3T6jn/iGlmw1IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGBZMn8ByPKcqMSf6kz3SbV0IgmV/jv+3U8gDGIL1ao=; b=u2zH8rydT/tYDlJ/2lvwooTqzv131wyDyO1LM6edFQZ2ZYvikQV0Lo4FT5EUghu92dkBVow4wGBLu511LqJEQoV3s22XfNGOJfcx+iCS30wIKGMhCLJfsDrzhKhon9udMD0p9sOAj8lUEjxYPp49wptygK3Ay+t2EwLuh7oJZlI= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7b::32) by CY4PR1801MB1832.namprd18.prod.outlook.com (2603:10b6:910:79::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.17; Mon, 6 Apr 2020 12:33:25 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::7424:c6cd:94f2:b27b]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::7424:c6cd:94f2:b27b%4]) with mapi id 15.20.2878.021; Mon, 6 Apr 2020 12:33:24 +0000 From: Pavan Nikhilesh Bhagavatula To: Thomas Monjalon , Ori Kam CC: Jerin Jacob Kollanukkaran , "xiang.w.wang@intel.com" , "dev@dpdk.org" , Shahaf Shuler , "hemant.agrawal@nxp.com" , Opher Reviv , Alex Rosenbaum , "Dovrat Zifroni" , Prasun Kapoor , "nipun.gupta@nxp.com" , "bruce.richardson@intel.com" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , "jim@netgate.com" , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , "david.marchand@redhat.com" Thread-Topic: [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions Thread-Index: AQHWBZX54UsASpZbek6bztL98vA/6qhpAT8ggAGqpYCAAVKNAIAADc4w Date: Mon, 6 Apr 2020 12:33:24 +0000 Message-ID: References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <2875521.ySyUEvhnHf@xps> In-Reply-To: <2875521.ySyUEvhnHf@xps> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.181.45.244] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c18fbf4b-9b82-4816-8169-08d7da26b360 x-ms-traffictypediagnostic: CY4PR1801MB1832: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0365C0E14B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1801MB1863.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(39860400002)(396003)(366004)(136003)(346002)(316002)(7406005)(5660300002)(7416002)(86362001)(4326008)(33656002)(8676002)(81156014)(81166006)(2906002)(8936002)(7696005)(6506007)(186003)(71200400001)(26005)(76116006)(66446008)(64756008)(66556008)(66476007)(52536014)(55016002)(4744005)(54906003)(110136005)(9686003)(66946007)(478600001); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TKNZ8S4JxsqgFzJF/5HK0KPoQDHKqlDqKW9VWvYxWLdHQintBnklM93fN/qf2izh8eIJ5u8pyKJltMEeRJLocLGrEbrU0Q2hMUa9MDMwBwUPwo2T5b8EKj8K04MphU1q2eeJIKeSIJiiIWhy7j2pwWeZ9fPdMADahR65ROl2arjqkbdRP4DnqydDG1caZAgBxn/xujviiQ9BNqk18GjXlclIOLN7zlpTuuEjtjPl1f3fpgxDuiJ0dNqRjwHEX2FqweQcbRsdNDA2lO1PooTP7LrrLJcZPGTBl2+0k6fDy/HgsJ8fps6rFu6EC8/eUKak1mSn8fvuTuySaR6v9ymm1zJ1GpJuOnSy3rmv3IBQHBVrdu9v3Z4AreiV3TrwQa8yxj/8b/k7kG8efsl5meV5xXfaM0l45QruMhUjOfuOnIeZCGW5/QAlQ/z4NlviHQDL5sZfujGMz4KXrH5BwS9/vPPsjUGLTyCmTG+8SSEa0jaRWq6YdEbUiD0QLENIP7fNMB62BUHpb+tg7zA8ZJB22Q== x-ms-exchange-antispam-messagedata: UznKtteIT4jiuU4uW+ggfweF1DO/sKqeoXrTpJGG2l0vTp7K5HYJhH3tOWKHxbl3HyGRwlsmLcaxiXpjfQMjopgweuLwelvaxXLWQ9AMJzYNlJ7vTyPPm6weHXYMUsx3fVtzeKAgtMNqZtW22KS1nQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c18fbf4b-9b82-4816-8169-08d7da26b360 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2020 12:33:24.6964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bMVhBC1y77u8rgOuaorYsMGallqY4kIwkn47mTVzZ9p2Ly91LUeyG6V+5Fwa6Y/I9pScu0C/yIK4sF+Go+zu91glTbkVCo1jkIdxzH0osYU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1832 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-06_07:2020-04-06, 2020-04-06 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 4/4] regexdev: implement regex rte level functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> From: Pavan Nikhilesh Bhagavatula >> > >+uint16_t >> > >+rte_regexdev_enqueue_burst(uint8_t dev_id, uint16_t qp_id, >> > >+ struct rte_regex_ops **ops, uint16_t nb_ops) >> > >+{ >> > >+ return regex_devices[dev_id]- >> > >>enqueue(regex_devices[dev_id], qp_id, >> > >+ ops, nb_ops); >> > >+} >> > >> > Move these functions to .h in-lining them. >> > Also, please add debug checks @see >rte_eth_rx_burst/rte_eth_tx_burst. >> >> O.K will update. > >In general, inlining is a pain for ABI compatibility. >Please inline only if the gain is very significant. > The performance gain mostly comes from hoisting `regex_devices[dev_id]` loa= d above the=20 poll loop.=20 Since, the performance measurement application is still in pipeline and reg= exdev would be=20 experimental for next couple of releases I suggest inlining it now and worr= ying about ABI when experimental tag needs to be removed. We can follow the same path as done by ethdev [https://www.mail-archive.com= /dev@dpdk.org/msg142392.html]