From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2068A00E6 for ; Tue, 6 Aug 2019 15:57:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 967111B952; Tue, 6 Aug 2019 15:57:24 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id CD9851B949 for ; Tue, 6 Aug 2019 15:57:22 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x76Dt2i7004954; Tue, 6 Aug 2019 06:57:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Q6g3PG4oIFyY+PJJzSex/9R9R9jFfAywP1xB/PnY8UE=; b=MPaKjEPkJ/HkXPQeejM1fVDCKH9IGXJBQ8xRFtdDAyGXAv0h8dGpWQmp5Gfe3QKM1dvs 9pI9p1/mjNksZ55lDh/0JjJs/jQNWTioa0QOqPUKdU1u14sg3Tn4yvceRzokoelmUvpm MmmWSlwCB9iwxxiLjV9pvefAjbuXd7qbjUBA27ojWYrl9yWdK9BPPLktcDtmaN6wQvXN YwHLfoNICtK+JK3haBG/skVYlKfjxIg3H+c+5dZNMft8Wstzty6ekkpbMg3P7nNb1cat 47XDqynWIUxGkYp1XFMusNBgnlpVZHlzb4ac72CFjEd+Y3aGPtZmWS5gy8cPprG8olTw Qg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2u57mr3efx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 06 Aug 2019 06:57:21 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 6 Aug 2019 06:57:20 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.53) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 6 Aug 2019 06:57:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TU+n4K5d3iVRNvWvq5BZwuCeXdedex3FpFAk7kKzAlqLKL6Fx2t25D359LJZFz2sb5NpZREYZjCSw+cpCoKfFRo8llLGVYxVezbNd5NNydEaetBJPkO1tJzscRYeLqBBs+SVMyfgtZbSR6Qb5DeYnYGntQVPPc3lw3zVhirSRP612fFGFamMiIO9X6y5SZxgTwdSZ/SyzLmighCYPyTGzLHsE4HHMtc5DaZYAPYQmSd9QslaHLufi++CfNDQ8lEb912y7wo5KvNbPcTK8/8GUrX78iK8kZlt+n0bmq5XwOBQPXd2bTfKsABOYPFiWin9TCdd91gjwfa2LVnbXIXHgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q6g3PG4oIFyY+PJJzSex/9R9R9jFfAywP1xB/PnY8UE=; b=BcXT07QukdMmjXZqAcwu/Nnf2o3/oiwV6PwYDJgLczqukHX36WkUeViol4MLa1ROsclk1Z8q5VejrUcYbx2Pf4y8i8CPVtRZ3i02HWGGXWisPBo2sLayOd0pX1omQB4KHM5vuh6jNHDqFS2klgfpkPhyi5GYuHBfoNYHN/j8B+JzwHLq48/odlAJbm9C2qMVripWs5xKtEtptkCxFtLuY3wPz78SiE6XYx5a6X8lMEm62LwlxZ3U1Z/r/UBLEUQWAMjGSgCAaPlFP/y2wsrUOaAh/Wgv1uazLz2buJ/Z123MMmZCSkhFv2BKTrD4Z+DKXOf2D2dX9RcVmIeT7Qm5gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q6g3PG4oIFyY+PJJzSex/9R9R9jFfAywP1xB/PnY8UE=; b=FfGxre0HD1mp1L/9a/IkEbx/fMUAJepW8kCbSK6ThHf5d64/94mXsQfVuRHHqbwlT68vSTSF0g1lUkA1bAiwLHOfKMRxpGYGzeRH9OitJVXdxMuzn+J1xowpFk420beiScxPXJ1qwib2NXpmqRVMxnYCX9HexIJ9RmzIkKoB0z8= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1830.namprd18.prod.outlook.com (10.171.255.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Tue, 6 Aug 2019 13:57:14 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::ad3e:ff83:79ce:a2bc]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::ad3e:ff83:79ce:a2bc%4]) with mapi id 15.20.2157.011; Tue, 6 Aug 2019 13:57:14 +0000 From: Pavan Nikhilesh Bhagavatula To: "Ananyev, Konstantin" , "Jerin Jacob Kollanukkaran" , "Hunt, David" , "Kovacevic, Marko" , Ori Kam , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "Nicolau, Radu" , Akhil Goyal , "Kantecki, Tomasz" , "Mcnamara, John" , "Van Haaren, Harry" , "Li, Xiaoyun" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload Thread-Index: AQHVTC1P2m0Y/sT3NkOgQH/pMOSET6bt1/6AgABMZ4A= Date: Tue, 6 Aug 2019 13:57:14 +0000 Message-ID: References: <20190806080206.1572-1-pbhagavatula@marvell.com> <20190806080206.1572-4-pbhagavatula@marvell.com> <2601191342CEEE43887BDE71AB9772580168A62840@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A62840@irsmsx105.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [223.226.88.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f630309d-6d3b-4ebc-f9aa-08d71a75fcad x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CY4PR1801MB1830; x-ms-traffictypediagnostic: CY4PR1801MB1830: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:339; x-forefront-prvs: 0121F24F22 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(396003)(39860400002)(376002)(346002)(13464003)(199004)(189003)(14454004)(2906002)(9686003)(52536014)(53936002)(66946007)(71200400001)(66446008)(68736007)(66556008)(81156014)(81166006)(99286004)(7416002)(8676002)(6436002)(110136005)(66476007)(64756008)(33656002)(25786009)(6116002)(86362001)(229853002)(55016002)(8936002)(76116006)(186003)(71190400001)(3846002)(316002)(305945005)(7736002)(478600001)(14444005)(102836004)(53546011)(26005)(6506007)(6246003)(66066001)(486006)(5660300002)(7696005)(256004)(4326008)(55236004)(74316002)(476003)(76176011)(446003)(11346002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1830; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: QdKlEX49Hz224yjLkD9vvaTuJp+PZJt53lr17fbzktpqnwHmc+J99amgiXLM18YuOwkEFe/A2DN53ee/gK13FxHrkgwbZwVx/H1azVWTTi+3lQTlWHjF9ZMcgOXmCn68s/aPm5bPDCAopdT8V71wmLjsbSeOhW8t3XFLbCHG2FAnpJt6Ns3XeyP9uq4LFxBluegO0KLB8/O9w27OVnL4/n04Hmrryv1mSOY34TNWvTCy4S3AvViLgsQ3WDc9cbpLoo2CvsbGr7/3TVlpHBKyFDiCxx3XLvdm4lBexWmrxT8KyInBHyVhLdCYSbZbTcEASDqCZUC+OmkHn5hirkoBLse6W+UxwX55o0dbdV/tNVbHxZnB5RYmUeYY9rD/3lJ1Y9OUYY9lIAGI0SDHrHZpyqkY/5F7Mhv1FwYvf5lJUyM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f630309d-6d3b-4ebc-f9aa-08d71a75fcad X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2019 13:57:14.6841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gvGLptzIrifkpZRj1kvpm1dcJJ4PyTzSJeWcYiJRVEEsX0vq9kLbF+KmrD0s18uXYoDOieCkGlXbL4jw1xJeWvL+tI9I5O3rjKIdYk5ur18= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1830 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-06_08:2019-08-05,2019-08-06 signatures=0 Subject: Re: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Ananyev, Konstantin >Sent: Tuesday, August 6, 2019 2:50 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Hunt, David >; Kovacevic, Marko >; Ori Kam ; >Richardson, Bruce ; De Lara Guarch, >Pablo ; Nicolau, Radu >; Akhil Goyal ; >Kantecki, Tomasz ; Mcnamara, John >; Van Haaren, Harry >; Li, Xiaoyun >Cc: dev@dpdk.org >Subject: RE: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload >> -----Original Message----- >> From: pbhagavatula@marvell.com >[mailto:pbhagavatula@marvell.com] >> Sent: Tuesday, August 6, 2019 9:02 AM >> To: jerinj@marvell.com; Ananyev, Konstantin >; Hunt, David >; Kovacevic, Marko >> ; Ori Kam ; >Richardson, Bruce ; De Lara Guarch, >Pablo >> ; Nicolau, Radu >; Akhil Goyal ; >Kantecki, Tomasz >> ; Mcnamara, John >; Van Haaren, Harry >; Li, >> Xiaoyun >> Cc: dev@dpdk.org; Pavan Nikhilesh >> Subject: [dpdk-dev] [RFC 3/3] examples: add Rx ptype offload >> >> From: Pavan Nikhilesh >> >> Add DEV_RX_OFFLOAD_PTYPE as a offload requirement for applicable >> examples. >> >> Signed-off-by: Pavan Nikhilesh >> --- >> examples/ip_fragmentation/main.c | 7 +++++++ >> examples/l3fwd-power/main.c | 8 ++++++++ >> examples/l3fwd/main.c | 9 +++++++++ >> examples/performance-thread/l3fwd-thread/main.c | 9 +++++++++ >> examples/tep_termination/vxlan_setup.c | 1 + >> 5 files changed, 34 insertions(+) >> >> diff --git a/examples/ip_fragmentation/main.c >b/examples/ip_fragmentation/main.c >> index 324d60773..2a9895542 100644 >> --- a/examples/ip_fragmentation/main.c >> +++ b/examples/ip_fragmentation/main.c >> @@ -904,6 +904,13 @@ main(int argc, char **argv) >> >> /* limit the frame size to the maximum supported by >NIC */ >> rte_eth_dev_info_get(portid, &dev_info); >> + >> + if (dev_info.rx_offload_capa & >DEV_RX_OFFLOAD_PTYPE) >> + local_port_conf.rxmode.offloads |=3D >DEV_RX_OFFLOAD_PTYPE; >> + >> + if (dev_info.tx_offload_capa & >DEV_TX_OFFLOAD_MBUF_FAST_FREE) >> + local_port_conf.txmode.offloads |=3D >> + DEV_TX_OFFLOAD_MBUF_FAST_FREE; > >I didn't look at the rest of the patch series yet, but these 3 lines above >seems wrong. >and not related to that subject. >Probably something wrong with your merge process. Ack. I will remove it in the next version. >Check >commit ed553e3db4a84af0ddac0d898476333d61adb93a >Author: Sunil Kumar Kori >Date: Thu Jul 25 13:54:10 2019 +0530 > > examples/ip_frag: remove Tx fast free offload flag > > >> local_port_conf.rxmode.max_rx_pkt_len =3D RTE_MIN( >> dev_info.max_rx_pktlen, >> local_port_conf.rxmode.max_rx_pkt_len); >> diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd- >power/main.c >> index fd8d9528f..875d60c06 100644 >> --- a/examples/l3fwd-power/main.c >> +++ b/examples/l3fwd-power/main.c >> @@ -2261,6 +2261,14 @@ main(int argc, char **argv) >> dev_rxq_num =3D dev_info.max_rx_queues; >> dev_txq_num =3D dev_info.max_tx_queues; >> >> + if (dev_info.rx_offload_capa & >DEV_RX_OFFLOAD_PTYPE) { >> + if (!parse_ptype) >> + port_conf.rxmode.offloads |=3D >> + DEV_RX_OFFLOAD_PTYPE; >> + } else { >> + parse_ptype =3D 1; >> + } >> + >> nb_rx_queue =3D get_port_n_rx_queues(portid); >> if (nb_rx_queue > dev_rxq_num) >> rte_exit(EXIT_FAILURE, >> diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c >> index 3800bad19..dfee880a0 100644 >> --- a/examples/l3fwd/main.c >> +++ b/examples/l3fwd/main.c >> @@ -875,6 +875,15 @@ main(int argc, char **argv) >> nb_rx_queue, (unsigned)n_tx_queue ); >> >> rte_eth_dev_info_get(portid, &dev_info); >> + >> + if (dev_info.rx_offload_capa & >DEV_RX_OFFLOAD_PTYPE) { >> + if (!parse_ptype) >> + local_port_conf.rxmode.offloads |=3D >> + DEV_RX_OFFLOAD_PTYPE; >> + } else { >> + parse_ptype =3D 1; >> + } >> + >> if (dev_info.tx_offload_capa & >DEV_TX_OFFLOAD_MBUF_FAST_FREE) >> local_port_conf.txmode.offloads |=3D >> DEV_TX_OFFLOAD_MBUF_FAST_FREE; >> diff --git a/examples/performance-thread/l3fwd-thread/main.c >b/examples/performance-thread/l3fwd-thread/main.c >> index 49d942407..f033326be 100644 >> --- a/examples/performance-thread/l3fwd-thread/main.c >> +++ b/examples/performance-thread/l3fwd-thread/main.c >> @@ -3560,6 +3560,15 @@ main(int argc, char **argv) >> printf("Creating queues: nb_rxq=3D%d nb_txq=3D%u... ", >> nb_rx_queue, (unsigned)n_tx_queue); >> rte_eth_dev_info_get(portid, &dev_info); >> + >> + if (dev_info.rx_offload_capa & >DEV_RX_OFFLOAD_PTYPE) { >> + if (!parse_ptype_on) >> + port_conf.rxmode.offloads |=3D >> + DEV_RX_OFFLOAD_PTYPE; >> + } else { >> + parse_ptype_on =3D 1; >> + } >> + >> if (dev_info.tx_offload_capa & >DEV_TX_OFFLOAD_MBUF_FAST_FREE) >> local_port_conf.txmode.offloads |=3D >> DEV_TX_OFFLOAD_MBUF_FAST_FREE; >> diff --git a/examples/tep_termination/vxlan_setup.c >b/examples/tep_termination/vxlan_setup.c >> index 9a0880002..3d2acecd5 100644 >> --- a/examples/tep_termination/vxlan_setup.c >> +++ b/examples/tep_termination/vxlan_setup.c >> @@ -69,6 +69,7 @@ uint8_t tep_filter_type[] =3D >{RTE_TUNNEL_FILTER_IMAC_TENID, >> static struct rte_eth_conf port_conf =3D { >> .rxmode =3D { >> .split_hdr_size =3D 0, >> + .offloads =3D DEV_RX_OFFLOAD_PTYPE, >> }, >> .txmode =3D { >> .mq_mode =3D ETH_MQ_TX_NONE, >> -- >> 2.17.1