From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4FFCA04B3; Sun, 29 Dec 2019 16:42:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7DC01C066; Sun, 29 Dec 2019 16:42:28 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id E7A161BF80 for ; Sun, 29 Dec 2019 16:42:26 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xBTFgQHr003641; Sun, 29 Dec 2019 07:42:26 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=YUN/fEZpwJtxglfqPSLKUN/zYw0ejR5+8yRMBVy1Co8=; b=d5B6SKvCWx3aH7+fP5pUtuIcbYDmIcU+rD5nhBU2hMdRX318lWoFOsP4CpGHF9cJeZwR CITVRZL946uHMfTo97SR7pcMqrGAAc6k2aGyqg3hSBnQjDVrehK4oW/IpK2RBjMOgF9N nl3Zc3PV8WlORIRXEhfepSbYu3FSyD50Ujky/fPlP9IfvehsgcE9QKZSLIxmA2qS9Htc kK8ur6KlPm37RsD6BR1JbjQQ6/3rs96W5Hs0KqgeJmGdnjCPxlEuUca4WzBombM4qHB/ IOkluOXtP9dDofTGuuj5lU9mzejuLsrlR9wU8WbwONs1lq+VH4ukHNn+Y1YK+RJoay0K 6A== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2x67eta7r0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2019 07:42:25 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 29 Dec 2019 07:42:23 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 29 Dec 2019 07:42:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=avMfAadC8dEccCwuHu7j46uJ0yt9S6Kzf2b1HNeJwETKssVXvNElkLjEXDI4V/j1VS3ZS4j3XYwAEFq2v7t6OihX43ZpEI+mWv+6cEssBGjvyULHET1ONiqF/i64KrhZ3r29pugs8z8nbi6qkZkL1QRCxCa/XDIJd1EyaMZY9cEEyoyx00bqwD7O248w4bXNPYkCD3pXzF6/j2EAN2IYqpOxFnDLe8QuaXBnBRrOh7jiECuteORj8mIYn3uygEb+fHOnmDdKllnkUgG5jLFHEK/+rsd3D9VfT8VOvlAuRsN3AXtGBj5/gMZWFqLo3DWvSS7IbZLM97wcMnSbbSdrsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUN/fEZpwJtxglfqPSLKUN/zYw0ejR5+8yRMBVy1Co8=; b=M25V5VXlE4zRla2sxI54rerdHhBUX9e7xxSeK2/5QZeFWhovGa2/M5fpm3ERQOFqZj2JXbOL6KgJVRyuo8XF3SYLjBIloqujJv8hABpgGVc7+WzSLwvBLUWVidz0Hv12PrNUem0goLAtcXVvnPUU3L25hQIwaskL7uuvG+BMG/KJdN+3WANABDo5SIqrqT0ITQs9WAZ7imniTDpFAvSfbguU7Ls5GR1U5B9/d5ndGFbR7kDo7rF/AT/GKwYp+U2ZxUL7xJZb1CweMXBLQaKKKsEKbsPq0JTcJriGDdcb1Ev098B/ZAX97gxjKzRwdh1kKkSJ8VHbNTw8Q06maFjXdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUN/fEZpwJtxglfqPSLKUN/zYw0ejR5+8yRMBVy1Co8=; b=OPtMbEHBx9Xc+BC/QxO38wsYoanaclVLeqZa5FwblT2kJvWcRS4YBYbzd6nLPxM/25nspFZZRO3mSTQrEVU9KZxZ3BM9o8maLpT3+KfdgMVLX9mLvUNek/uVM8qBsG6k/ZxOxSU9XO1dTw26C+ALxSgOmIrXYt9UcotPDUw5RnE= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.160) by CY4PR1801MB2056.namprd18.prod.outlook.com (10.171.255.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2581.12; Sun, 29 Dec 2019 15:42:22 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::9c5c:3cc4:c7f9:5fce]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::9c5c:3cc4:c7f9:5fce%4]) with mapi id 15.20.2581.007; Sun, 29 Dec 2019 15:42:22 +0000 From: Pavan Nikhilesh Bhagavatula To: Nipun Gupta , Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , "Radu Nicolau" , Akhil Goyal , "Tomasz Kantecki" , Sunil Kumar Kori CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup based on eventdev Thread-Index: AQHVvLo4fCm2ejmclEeQawOKny7lyafRQM0g Date: Sun, 29 Dec 2019 15:42:21 +0000 Message-ID: References: <20191204144345.5736-1-pbhagavatula@marvell.com> <20191204144345.5736-5-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [122.172.73.190] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 30cca85c-8b45-4840-ae87-08d78c75b1ea x-ms-traffictypediagnostic: CY4PR1801MB2056: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0266491E90 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(346002)(39850400004)(396003)(376002)(189003)(199004)(13464003)(6636002)(86362001)(478600001)(110136005)(9686003)(5660300002)(186003)(55016002)(2906002)(316002)(64756008)(52536014)(81166006)(66946007)(4326008)(66476007)(76116006)(8936002)(33656002)(7696005)(81156014)(53546011)(6506007)(66446008)(71200400001)(66556008)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2056; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FnYX1RlqK3yJU/D1k8kizY/wzF4JBL1EJS5yJjDLainAYzKxh+s6WhzNR9DJrCX9OFtJ4DnKkPkRmLWsn1+s92R7ksMIupsEg//756SmPNL7VjZ/kvxLY35ycBwFR0w3dxF+f0ZG/6itux7FZlyXgKqxJn8il3FePhf4oud3PeD95qt9uux/J3B4f7g3mk89DHMKWMjwnbE47EfDfNIMhXo3yy47nuT9ttn5G8W1zjkwTE46si0jlNgRH0P2BNkagxjOSac5io6CxWoa58Z0P9vQ/Y4yNdF8aBToPSjc0eoMZSAyokafTGoVewAWRYqt4TNeK18BWcs9oDD7lNhc8ZKBRPbXO2C5Dg2HBwQCjfTctQ1dscKyQRkVT48KzI62s7cqC1Tt/n+Yy6ji+9RWiwthwTrtL/0iDt5MMO/EeL8mCJWFkMQt8zlfBOyj5lmeuEM/plpLcjaz0YtRkiA21AKrzUt7H01DDVDsXVLhFR2y2dpuoZTqbUn5t1bhx2kr Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 30cca85c-8b45-4840-ae87-08d78c75b1ea X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2019 15:42:21.8824 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eM73oSTNQVDM0/5QwP4V26t5m7cKwxoonFMqgEFS6BxrbrVRONaB0h0NJGWYWokwhxPXum5BCb5jBkXZOax7Ya/NNgo+d4zTCsxG1ExJ8hg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2056 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-29_03:2019-12-27,2019-12-29 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev setup based on eventdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> -----Original Message----- >> From: dev On Behalf Of >> pbhagavatula@marvell.com >> Sent: Wednesday, December 4, 2019 8:14 PM >> To: jerinj@marvell.com; Marko Kovacevic >; Ori >> Kam ; Bruce Richardson >> ; Radu Nicolau >; >> Akhil Goyal ; Tomasz Kantecki >> ; Sunil Kumar Kori >; >> Pavan Nikhilesh >> Cc: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH v2 04/11] examples/l3fwd: add ethdev >setup >> based on eventdev >> >> From: Sunil Kumar Kori >> >> Add ethernet port Rx/Tx queue setup for event device which are later >> used for setting up event eth Rx/Tx adapters. >> >> Signed-off-by: Sunil Kumar Kori >> --- >> examples/l3fwd/l3fwd.h | 10 +++ >> examples/l3fwd/l3fwd_event.c | 129 >> ++++++++++++++++++++++++++++++++++- >> examples/l3fwd/l3fwd_event.h | 2 +- >> examples/l3fwd/main.c | 15 ++-- >> 4 files changed, 144 insertions(+), 12 deletions(-) >> > > > >> + >> + local_port_conf.rx_adv_conf.rss_conf.rss_hf &=3D >> + >> dev_info.flow_type_rss_offloads; >> + if (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=3D >> + port_conf- >>rx_adv_conf.rss_conf.rss_hf) { >> + printf("Port %u modified RSS hash function " >> + "based on hardware support," >> + "requested:%#"PRIx64" >> configured:%#"PRIx64"\n", >> + port_id, >> + port_conf->rx_adv_conf.rss_conf.rss_hf, >> + >local_port_conf.rx_adv_conf.rss_conf.rss_hf); >> + } > >We are using 1 queue, but using RSS hash function? rte_event::flow_id which uniquely identifies a given flow is generated usin= g RSS Hash function on the required fields in the packet. > >> + >> + ret =3D rte_eth_dev_configure(port_id, 1, 1, >&local_port_conf); >> + if (ret < 0) >> + rte_exit(EXIT_FAILURE, >> + "Cannot configure device: err=3D%d, >> port=3D%d\n", >> + ret, port_id); >> + > >We should be using number of RX queues as per the config option >provided in the arguments. >L3fwd is supposed to support multiple queue. Right? The entire premise of using event device is to showcase packet scheduling t= o cores without the need for splitting packets across multiple queues. Queue config is ignored when event mode is selected. =20 > >Regards, >Nipun > Regards, Pavan.