From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id EA465A046B
for <public@inbox.dpdk.org>; Sat, 27 Jul 2019 13:51:58 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 1EE861C35F;
Sat, 27 Jul 2019 13:51:58 +0200 (CEST)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id B6AFA1C34E
for <dev@dpdk.org>; Sat, 27 Jul 2019 13:51:56 +0200 (CEST)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
x6RBpt3G013930; Sat, 27 Jul 2019 04:51:55 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
h=from : to : cc :
subject : date : message-id : content-type : content-transfer-encoding :
mime-version; s=pfpt0818; bh=pbpubfpMZI+ZfM8L2Hkb43rtjy0gbsnKeGIpxjXLuz8=;
b=SBUy42WLCAJM++mHNx8U7WpdDfD9L7uxzWJGA5IOT5ATsuP8URgDowCuUG6iR9dqlkD6
8VY82ngIJhks9qSoyZNqe5roBu9CkoIn3JD4MUALDfaTQQyaiL3vlqeEjkpObtIq1hWo
LT0DVFzqqcL7ZXhsQ46/hQgqN7k5b2lomsBVkP1YmotwfkBk6f0QuyNHrXTLumZeUG3w
Agpx5FqfUTYiQtsk4nv8iWYdT82DC8FaXbC0HOnL9KLXxUlpVnrsigW8OKdmDb9TENd9
RlHhN4vW6n1cXWveJ/KH69NRGZekFH3Z3E9sB+eODhaAJJtm78be6czC5k4ie3aEQklT jw==
Received: from sc-exch01.marvell.com ([199.233.58.181])
by mx0b-0016f401.pphosted.com with ESMTP id 2tx625afdw-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
Sat, 27 Jul 2019 04:51:55 -0700
Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com
(10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 27 Jul
2019 04:51:52 -0700
Received: from NAM01-BY2-obe.outbound.protection.outlook.com (104.47.34.51) by
SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server
(TLS) id
15.0.1367.3 via Frontend Transport; Sat, 27 Jul 2019 04:51:52 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=G6v0HMLlwiMt5kkO2a8LNSDgi184IcNGb6PtSsoKlQAegMjvZzbD3W5Xx+64K68IuGBkeE0BRnKxKPPt9BA3V5m6QPK1qCEOIU6Ms+ya64C5DjKdv+F/IyL+YUg6e9lBQvk3B4aT/SEsb9ERGJH36PBoIWfaiqYXSxP6CbucQb87i+5gbSXZkF6xZfz1cqbnckbjuEBdRp5BpyqJ4KsGF8FQld3SHe1MmWV3/Qj+7Xf0JnYWhjXZpcWQqMs8BcAqTf3ZzAj+tj3z6bwXV7QgSmx3hd80i9VNdFy9Rz/wl35ie277qslnb2tQyZCuWrf/M0TBCeebMD9TJtIKOSeqUw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=pbpubfpMZI+ZfM8L2Hkb43rtjy0gbsnKeGIpxjXLuz8=;
b=asikaW414JunHeBrDvQcnTWNDDi2QDv5ChO+0bfeneFQadIz/Xw9e/yxBkRQGL0S5L3nvF29JG/6tIiOItQdVCsJg0YvZJP1mM61z0IK0Kr2KIGb5LIPjhG6BvldRBru/gSBKlFUFlYJz5idIA3yfNi6qe8PvkceM336t9h6CzyEwnZKCyzVKn0RCsUS0jFPkNOJMEK66wiFPVdZbpqhY4zkIZDnkyGeiyOGdpeM+wftylm8PPhCMJTKCPveKaCHMU8ph7yGtmentYDd1/LUqSCG/2yscBe15iVgDSqEhwlSYJbcMz7Y9jX4LQO8RfVfT+KlgGoAqcguaSJqspvJGg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass
smtp.mailfrom=marvell.com;dmarc=pass action=none
header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=pbpubfpMZI+ZfM8L2Hkb43rtjy0gbsnKeGIpxjXLuz8=;
b=pz/41H1q25X5eOOmPQ33j4H2kxL2HZlH4l4Vjjsg/gGLisuCXboMyBchG+EHxCW5iJzAUX4g/dXgqVRHDdEUb9QVSBIIF1gx8mgdkOVuL7H1ecX2XjGyYIALsQP95850GbLvRsg/fj7AFYAnhxmIFrIphLSx42AyZKfoD9VCATU=
Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by
CY4PR1801MB1925.namprd18.prod.outlook.com (10.171.255.28) with Microsoft SMTP
Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.2115.10; Sat, 27 Jul 2019 11:51:51 +0000
Received: from CY4PR1801MB1863.namprd18.prod.outlook.com
([fe80::1859:6ecd:9898:f96c]) by CY4PR1801MB1863.namprd18.prod.outlook.com
([fe80::1859:6ecd:9898:f96c%7]) with mapi id 15.20.2115.005; Sat, 27 Jul 2019
11:51:51 +0000
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "dev@dpdk.org"
<dev@dpdk.org>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"Nithin Kumar Dabilpuram" <ndabilpuram@marvell.com>, Vamsi Krishna Attunuru
<vattunuru@marvell.com>
CC: "thomas@monjalon.net" <thomas@monjalon.net>
Thread-Topic: [dpdk-dev] [PATCH] common/octeontx2: fix to prevent STP
instruction fissure
Thread-Index: AdVEcZplvFgVb1Y3QJGzV6xFpFz3bg==
Date: Sat, 27 Jul 2019 11:51:50 +0000
Message-ID: <CY4PR1801MB186367BCD8ABFDACBF45EE08DEC30@CY4PR1801MB1863.namprd18.prod.outlook.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [183.82.16.194]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a23c440f-9e48-4eeb-674c-08d71288d023
x-microsoft-antispam: BCL:0; PCL:0;
RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);
SRVR:CY4PR1801MB1925;
x-ms-traffictypediagnostic: CY4PR1801MB1925:
x-microsoft-antispam-prvs: <CY4PR1801MB1925861062C1B6A0B48F35D1DEC30@CY4PR1801MB1925.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:124;
x-forefront-prvs: 01110342A5
x-forefront-antispam-report: SFV:NSPM;
SFS:(10009020)(4636009)(376002)(346002)(366004)(396003)(136003)(39850400004)(199004)(13464003)(189003)(33656002)(2906002)(8676002)(81166006)(256004)(14444005)(6116002)(229853002)(74316002)(64756008)(3846002)(81156014)(71190400001)(478600001)(6436002)(71200400001)(53936002)(66446008)(7736002)(76116006)(4326008)(66946007)(68736007)(110136005)(25786009)(305945005)(6246003)(5660300002)(66556008)(66476007)(52536014)(8936002)(186003)(26005)(86362001)(55016002)(486006)(14454004)(66066001)(6506007)(78486014)(476003)(99286004)(2501003)(316002)(6636002)(9686003)(7696005)(102836004);
DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1925;
H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en;
PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: +A6sipiXG7NhKpf4Y7Drhx0Wma7lWO/rS0TFae+XCydiyxWSxYmU2V+ib1w0bGi8rac9sb0wvXQfrAYislRJvyi4vg4Hv5SUQ5uw+1CjU6q7VdvFqoOt6CO7tOqvVxezv4fXzFfcUQoM5at4AoiRt4lqxixhEXYnBAcM14eNTj8MFLQ6vRG5WEZT4/MMsTYy6Yfgy2LyRt57HrksRL6rWNTMHjJG4q3sDXwdu3dAe8WQMJTUGjaYWueXcm2ZRc4Ra6ui049g2V0YV8t+eRTC2ySLkmRbDsxiFxEwKcimiz8+OeZl7AL8JcVR8CTnxonrSz0/gR/b2/UAHkzi42wnyOQte06vf4DyoN4yPcPBOWaOFtSa51Rh/uJT5p3lMWrqBA1/k1X2+Bpi7likk2YNchW3NRuXldAE1K7+H8frIr0=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a23c440f-9e48-4eeb-674c-08d71288d023
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2019 11:51:51.1768 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pbhagavatula@marvell.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1925
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8
definitions=2019-07-27_09:2019-07-26,2019-07-27 signatures=0
Subject: Re: [dpdk-dev] [PATCH] common/octeontx2: fix to prevent STP
instruction fissure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of jerinj@marvell.com
>Sent: Friday, July 26, 2019 10:55 AM
>To: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
>Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Vamsi Krishna
>Attunuru <vattunuru@marvell.com>
>Cc: thomas@monjalon.net
>Subject: [EXT] [dpdk-dev] [PATCH] common/octeontx2: fix to prevent
>STP instruction fissure
>From: Jerin Jacob <jerinj@marvell.com>
>
>OTX2 AP core can sometimes fissure STP instructions when it is more
>optimal to send such writes into the pipeline as 2 separate
>instructions. However registers should be excluded from such
>optimization. This commit ensures that no CSR write is ever fissured
>by introducing zero cost workaround by setting STP pre-index by zero to
>make sure OTX2 AP core prevent fissure.
>
>Fixes: 8a4f835971f5 ("common/octeontx2: add IO handling APIs")
>
>Signed-off-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>---
> drivers/common/octeontx2/otx2_io_arm64.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/common/octeontx2/otx2_io_arm64.h
>b/drivers/common/octeontx2/otx2_io_arm64.h
>index 468243c04..7e45329b3 100644
>--- a/drivers/common/octeontx2/otx2_io_arm64.h
>+++ b/drivers/common/octeontx2/otx2_io_arm64.h
>@@ -14,7 +14,7 @@
>
> #define otx2_store_pair(val0, val1, addr) ({ \
> asm volatile( \
>- "stp %x[x0], %x[x1], [%x[p1]]" \
>+ "stp %x[x0], %x[x1], [%x[p1],#0]!" \
> ::[x0]"r"(val0), [x1]"r"(val1), [p1]"r"(addr) \
> ); })
>
>--
>2.22.0