DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] buildtools: fix pmdinfogen compilation
Date: Fri, 2 Aug 2019 03:35:34 +0000	[thread overview]
Message-ID: <CY4PR1801MB1863839AC79BE230D5595C29DED90@CY4PR1801MB1863.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190731143134.GF1705@bricha3-MOBL.ger.corp.intel.com>

Hi Bruce, Neil,

We had this patch in our internal tree that was intended to fix  -Wimplicit-fallthrough related error due to Host and Target GCC mismatch.
But I just verified both combination of GCC in Make and Meson seems like it has already been addressed somewhere down the line.
So, I'm dropping the patch.

Regards,
Pavan.

>-----Original Message-----
>From: Bruce Richardson <bruce.richardson@intel.com>
>Sent: Wednesday, July 31, 2019 8:02 PM
>To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
>Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Neil Horman
><nhorman@tuxdriver.com>; dev@dpdk.org; stable@dpdk.org
>Subject: [EXT] Re: [dpdk-dev] [PATCH] buildtools: fix pmdinfogen
>compilation
>
>External Email
>
>----------------------------------------------------------------------
>On Wed, Jul 31, 2019 at 11:57:05AM +0530, pbhagavatula@marvell.com
>wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Pmdinfogen is always compiled with host gcc.
>> If host gcc version is lessthan 7 and target gcc is greaterthan 7
>> pmdinfogen fails to compile due to unsupported cflags.
>> This patch removes unsupported host cflags when the above
>condition is
>> met.
>>
>> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen
>utility")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>> ---
>
>Can you perhaps check with a meson cross-compile and see if you
>encounter
>the same issue? If so, I'll investigate.
>
>Thanks,
>/Bruce

      reply	other threads:[~2019-08-02  3:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31  6:27 [dpdk-dev] " pbhagavatula
2019-07-31 11:35 ` Neil Horman
2019-07-31 14:21   ` Bruce Richardson
2019-07-31 14:30     ` Bruce Richardson
2019-07-31 14:31 ` Bruce Richardson
2019-08-02  3:35   ` Pavan Nikhilesh Bhagavatula [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR1801MB1863839AC79BE230D5595C29DED90@CY4PR1801MB1863.namprd18.prod.outlook.com \
    --to=pbhagavatula@marvell.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).