From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD1EBA0577; Sun, 5 Apr 2020 19:10:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC0811BECB; Sun, 5 Apr 2020 19:10:50 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id D74CC2C5E for <dev@dpdk.org>; Sun, 5 Apr 2020 19:10:48 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 035H5fjk018991; Sun, 5 Apr 2020 10:10:40 -0700 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-0016f401.pphosted.com with ESMTP id 306srm382a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 05 Apr 2020 10:10:40 -0700 Received: from m0045851.ppops.net (m0045851.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 035H8HfK020670; Sun, 5 Apr 2020 10:10:39 -0700 Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 306srm3827-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 05 Apr 2020 10:10:39 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 5 Apr 2020 10:10:37 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 5 Apr 2020 10:10:36 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.50) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 5 Apr 2020 10:10:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FIOfhpIHjZPXQGjagoGsD3xLEvqA6PdLq++AjvlOTi0T7aIrVScxRHeoNRNG/WpUmvsjWSU/1+JcLo46PCQGpoa26/M+7yIadfiqdYUaBcx8T4m7nNy5WZ8RLY59DZUcsKcHzKm0ddjfGCnD6LZX1/IikH6DfS5XWk1ZZ2uMHcsI8x8jLUpT2S3e8/aE+m/qtaMwD6IDsYD+zxQc5XqsjPao9L/y+GErHW4sMwiHh2qkU08d8FhYvgkzRs+OsXjRECnJ695xRE2BhhIBqzmVV7Fa5IhZSUrB0bvW4hkdJRhiLVlzlJrQ34Gc9UGbXB4X8qgb8rI6xBhmXhI066Mm7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oWdlaMXfp9f6Fe50eskpmcDsbOoIgkUNkfChaeXWTqA=; b=Jw4pCZP30dqAOo0h8FaNKEOBxU+DbJCKcZR7A4uXLeIbWFVTW/8iqx9Rs6kgJXiIZvWEgdmlkkidCIUeXbpstUzOg0beRMYAWtIwuC2H6DsHeqZi6z3mUWpFG18MjpgsZfeEAPjTMByzzu4zHV9fxbiU+SYaB2zUc8OeexCCMSNuKfLjYQqNMH6sDB94F/Xzj3OqH6lMnbEPwUN4vrZtbXhX0ngAS6pB3u7/imDZOSNVSyy7gOF5QbsOPRITOo/nBvTmSbZX9KPwDFerzCbg1WpA2Xj42jUPVIpaPJiDazPhIl+iBRMvDc7tWoBCyTIlUVqPSD1kT5vzvh8ctHhwQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oWdlaMXfp9f6Fe50eskpmcDsbOoIgkUNkfChaeXWTqA=; b=OodLWoojX1G1AZB8m67GC0lm3z+xnV6KwwP5N7HB7fTbg8yERQ67e3dbTE6SuX/LMHuTbQXv/BanN2wNX+HkBUFYbO2svd1dZ5QgSAx1zyzrRCgbBXBPg4q3KcXFTjj51mqvhf6115RX1MXnf9iyuwCylnP3ofN+lZ+0/CV1v4s= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7b::32) by CY4PR1801MB1848.namprd18.prod.outlook.com (2603:10b6:910:7a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.19; Sun, 5 Apr 2020 17:10:35 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::7424:c6cd:94f2:b27b]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::7424:c6cd:94f2:b27b%4]) with mapi id 15.20.2878.017; Sun, 5 Apr 2020 17:10:35 +0000 From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com> To: Ori Kam <orika@mellanox.com>, Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "xiang.w.wang@intel.com" <xiang.w.wang@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, Shahaf Shuler <shahafs@mellanox.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, Opher Reviv <opher@mellanox.com>, Alex Rosenbaum <alexr@mellanox.com>, Dovrat Zifroni <dovrat@marvell.com>, Prasun Kapoor <pkapoor@marvell.com>, "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "yang.a.hong@intel.com" <yang.a.hong@intel.com>, "harry.chang@intel.com" <harry.chang@intel.com>, "gu.jian1@zte.com.cn" <gu.jian1@zte.com.cn>, "shanjiangh@chinatelecom.cn" <shanjiangh@chinatelecom.cn>, "zhangy.yun@chinatelecom.cn" <zhangy.yun@chinatelecom.cn>, "lixingfu@huachentel.com" <lixingfu@huachentel.com>, "wushuai@inspur.com" <wushuai@inspur.com>, "yuyingxia@yxlink.com" <yuyingxia@yxlink.com>, "fanchenggang@sunyainfo.com" <fanchenggang@sunyainfo.com>, "davidfgao@tencent.com" <davidfgao@tencent.com>, "liuzhong1@chinaunicom.cn" <liuzhong1@chinaunicom.cn>, "zhaoyong11@huawei.com" <zhaoyong11@huawei.com>, "oc@yunify.com" <oc@yunify.com>, "jim@netgate.com" <jim@netgate.com>, "hongjun.ni@intel.com" <hongjun.ni@intel.com>, "j.bromhead@titan-ic.com" <j.bromhead@titan-ic.com>, "deri@ntop.org" <deri@ntop.org>, "fc@napatech.com" <fc@napatech.com>, "arthur.su@lionic.com" <arthur.su@lionic.com>, "Thomas Monjalon" <thomas@monjalon.net>, Parav Pandit <parav@mellanox.com> Thread-Topic: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions Thread-Index: AQHWC1unPBlXcFbc8kG+JZPmau7sUahqvYsA Date: Sun, 5 Apr 2020 17:10:34 +0000 Message-ID: <CY4PR1801MB1863AA228E125CF897A43267DEC50@CY4PR1801MB1863.namprd18.prod.outlook.com> References: <1585464438-111285-1-git-send-email-orika@mellanox.com> <1585464438-111285-4-git-send-email-orika@mellanox.com> <CY4PR1801MB186334240A4C0AF982985B6FDEC40@CY4PR1801MB1863.namprd18.prod.outlook.com> <AM6PR05MB51764E9CDCB575FF7C5FDA9CDBC50@AM6PR05MB5176.eurprd05.prod.outlook.com> In-Reply-To: <AM6PR05MB51764E9CDCB575FF7C5FDA9CDBC50@AM6PR05MB5176.eurprd05.prod.outlook.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [106.206.4.68] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 02f8fcd2-e530-45bd-4f28-08d7d9844153 x-ms-traffictypediagnostic: CY4PR1801MB1848: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <CY4PR1801MB18481AD312E3BDBB6E296FE7DEC50@CY4PR1801MB1848.namprd18.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 03648EFF89 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1801MB1863.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(39850400004)(366004)(376002)(346002)(136003)(396003)(7406005)(316002)(8936002)(76116006)(81156014)(66556008)(66446008)(64756008)(66476007)(2906002)(7416002)(71200400001)(81166006)(110136005)(66946007)(6506007)(7696005)(86362001)(9686003)(33656002)(478600001)(186003)(54906003)(26005)(4326008)(52536014)(5660300002)(55016002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9L6IAwrDjgCGdkYVZC8oV2w8+rHzGJGspOrgq4HsSSEZ6WsMrnCaHSd5oMr5QcQ17gn4uvgIeEDEwD/y4TTj61PKwTGMG4DSFUkAI1+7TTSwvOSMEDgEvefN0DFHN8h77NjBNnOOIuqgBM834tWOKP93CA7V1Q+DLDVrgdy9x0WRsWQ4tz4vXmdJWf6TI2E0Rfnf0sN0aEiDvc5WvpLjAq7WXhCu1BUasaAgfo8RZrfritWH+TIDMnnCTQBjq5wDlrZL/mYaf/6Sy3ETG42l9YQHg4d5qaaN/1VhjZc/VgmBLm2Bf9lKXD8X1NSOJ4L5+B1kG7xAuKT5pYs2wUdrTR/DBBQrNLrhscouovFvwGWo/UBe2SVXrQQ3AwvuRSTzt/EMKB1jA9lJOgHC1QXaix8IoMqLbky+L4tO2Atpti/qCJ1FeJTJyrvfe9bGvYWB x-ms-exchange-antispam-messagedata: KzUqqTcyO8gttuL1nVEfhrFKQ60FFoZ4/AHHa3QWukakH6ysDVJhEoTj+EbdG2zCpAzXEEchHToJqunGfhdOXYfA9aAHS/rgRrc+vQLMyxfcvEZpbQu85hIYXIY28nCNQt/pL3HUpYO4sb6J+MWFYQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 02f8fcd2-e530-45bd-4f28-08d7d9844153 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2020 17:10:34.9044 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I5Ouk+5Cf1mGE+/4WjDwA9OHwyooPTR5f9+4KuglCXaMDsLIQ0UgIqrXk+BLfiFCEee3DXQ86B74YOsbHGhbCkyEy3H/d4+zE+BYiCDObl0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1848 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-05_08:2020-04-03, 2020-04-05 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v1 3/4] regexdev: add regexdev core functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hi Ori, >> From: dev <dev-bounces@dpdk.org> On Behalf Of Pavan Nikhilesh >Bhagavatula >> >> Looks like this implementation is incomplete? >> I don't see any pmd specific helper functions for @see >rte_cryptodev_pmd.c, >> rte_eventdev_pmd* >> >I think the current implementation includes all needed functions, >at least for the first stage. >You can find in rte_regexdev_driver.h the functions that should be >called >by the PMD. We have the register / unregister which acts the same as >create >and destroy. For parsing argument the PMD may call rte_kvargs_parse. > _driver.h should atleast include=20 rte_regex_dev_pci_generic_probe/rte_regex_pmd_vdev_init else there would be a lot of code repetition and possibly udefined behavior at the driver layer. And also why take a different path than the rest of the rte subsystems? > >> >This commit introduce the API that is needed by the RegEx devices in >> >order to work with the RegEX lib. >> > >> >During the probe of a RegEx device, the device should configure >itself, >> >and allocate the resources it requires. >> >On completion of the device init, it should call the >> >rte_regex_dev_register in order to register itself as a RegEx device. >> > >> >Signed-off-by: Ori Kam <orika@mellanox.com> >> >Signed-off-by: Parav Pandit <parav@mellanox.com> >> >--- >> > config/common_base | 3 +- >> > config/meson.build | 1 + >> > lib/librte_regexdev/Makefile | 1 + >> > lib/librte_regexdev/meson.build | 5 ++- >> > lib/librte_regexdev/rte_regexdev.c | 74 >> >++++++++++++++++++++++++++++++- >> > lib/librte_regexdev/rte_regexdev.h | 7 +++ >> > lib/librte_regexdev/rte_regexdev_core.h | 2 + >> > lib/librte_regexdev/rte_regexdev_driver.h | 50 >> >+++++++++++++++++++++ >> > meson_options.txt | 2 + >> > 9 files changed, 142 insertions(+), 3 deletions(-) >> > create mode 100644 lib/librte_regexdev/rte_regexdev_driver.h >> > >> >> <snip>