From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2237DA00E6 for ; Tue, 6 Aug 2019 10:47:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE33F1BDFD; Tue, 6 Aug 2019 10:47:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4F39A2BCE for ; Tue, 6 Aug 2019 10:47:27 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x768khPB014223; Tue, 6 Aug 2019 01:47:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=xwIo2LP6B7YD0nTJNQfXttqUPByIVRtSjsvEks/k3+w=; b=ZdtnS3TUDB9yy5FBWghcYUbnlI8rpyATTHbLPsu7qY4k4VR/bYA4L8Jcig31XpfPGo5r 2Re6Csjou35PJvziZvuDRNeZbBwdkuQJwVitP1IF5xTfNKt18kAZYMbPHeB5JD/LX+S4 IojbzAYst0PARdejSpsr3UU4SrQ4523LMDnhGT8cu12OfzeQOs0eKZC/ERRoW6iubN7Z IyEPa09Fqqg4J17rONRfsYQV1UZKOXsOoQVtdjVaRgl8SfxryhDyOmKJKqFDyOzi9EyS /mLJg53/SqQxL4egOwg78iN917h6jmgoqWaoqEWvMW5Z2jvSgPWnb6eeeYpioYGZ+Fu/ kA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2u57mr2ey5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 06 Aug 2019 01:47:26 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 6 Aug 2019 01:47:24 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (104.47.42.50) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 6 Aug 2019 01:47:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bncm8DI5hEPfkNkuGu3sx+B8ZKtNYn+TPjwM8gH6QDfluloiSXDXABzcUDG/TxRsptnTb77KYz2fWbMcL04hOQt//VXInoYIJt5LduhbbSa3/k5qGfpA+rB45GrLopLM1XCzqbfdZ1YnynSBg6Czoy02XKI7Zh13ckPEhhsprvtE/X7x+0ci3a+DmXzniqq9+PI4n7D9Pj3JKb3N7oRKTmZ17fgEmXojAsqihw81KcRlIpcLHHSRply+JQiLuNAb1rwM7y74RL4+FPNdvXjvbdPTBHjU/6DOP4Bur7eUqChvGxKlNaTxbuhNQPAFBvAfetld/giZBbYSwQ73lPo3yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwIo2LP6B7YD0nTJNQfXttqUPByIVRtSjsvEks/k3+w=; b=CviAAwyYrD0MwBqPDAqe5Cy4uKaMEojasQ8bIqZ+Dqzm6Ex0Jtx/TDqvGbuLBYtbz5dsp6hUTySz2xdP599D70XCpBOrAh/69KvO+ubNbFIaiLLs99FJF+lcS1WkKGGJk6cTS9yU7sYtDgToQfGGb+cLsJYEBLBEMDUEPGemd1+4d0gqEdHi9HjFF68wfw1+S0/tSAlInGX2mfbbnP+9NeZqqI16IL+YQCCo2mk9Vs/LaLPNpzNUoa2tk6J1jlZ6tdGzLWI8Oce+hAKxmbm6STdp7/EV/abqtxuJMoJxU3lsE2sL55qWlcUiTINE1Yybue0Nb4nkmIBivn2f/hGE4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=marvell.com;dmarc=pass action=none header.from=marvell.com;dkim=pass header.d=marvell.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xwIo2LP6B7YD0nTJNQfXttqUPByIVRtSjsvEks/k3+w=; b=F2rHL3wGu+XA8k9aPwW4EDUX/S3wrZvvQYu673nQyXwCMmtStFF1i//r4z7uyLmwS3cDR3Lhv0LhIvxDCIfdpAyGNYwDBipTzosbQMet1LzLhqTWF/zZHx6JmHjHKWW8rKYKbhMApDIdFz45EcBp+FdOvkBmM1h9Ah08wCdmIZg= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB2038.namprd18.prod.outlook.com (10.171.255.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.14; Tue, 6 Aug 2019 08:47:23 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::ad3e:ff83:79ce:a2bc]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::ad3e:ff83:79ce:a2bc%4]) with mapi id 15.20.2136.018; Tue, 6 Aug 2019 08:47:23 +0000 From: Pavan Nikhilesh Bhagavatula To: Hemant Agrawal , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload Thread-Index: AQHVTC+q4RGI9+JDEUS1zhvSZ3SpTqbtyaVA Date: Tue, 6 Aug 2019 08:47:23 +0000 Message-ID: References: <20190806080206.1572-1-pbhagavatula@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [223.226.88.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 352b873c-e127-4571-c13b-08d71a4ab337 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CY4PR1801MB2038; x-ms-traffictypediagnostic: CY4PR1801MB2038: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0121F24F22 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(346002)(39860400002)(396003)(136003)(13464003)(199004)(189003)(51444003)(64756008)(66446008)(66556008)(25786009)(3846002)(86362001)(33656002)(305945005)(7736002)(66476007)(81156014)(81166006)(26005)(52536014)(68736007)(8936002)(5660300002)(7696005)(186003)(66946007)(316002)(76116006)(102836004)(486006)(6506007)(66066001)(256004)(8676002)(14444005)(99286004)(55016002)(110136005)(476003)(76176011)(53936002)(14454004)(6636002)(9686003)(6436002)(6116002)(478600001)(71190400001)(55236004)(11346002)(229853002)(71200400001)(6246003)(74316002)(2906002)(4326008)(446003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2038; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Bjm+HpX4U2RITMVlgF8VmLhedYi6SMe9grwy2YUiJC8JVyu3CzwECsnCrhlEr5AhZfIB6aqU1wxGn3qyVaQ6odIGP7JabrPKa8Mmk1GffgHBJntP6o20FYYhD7vAQ03RO4kt6f8v3XlpypsrBQRa70qfQfmwxpxoEHSYOKJebaVSKoUf6CDbX9zVx0wMU9/FlnoOjC34ndOk7WW57rzg9kK7NYzkXfbDLjXlilxCg3WmP95POInoWu1QkAv90kXZJQCUqfc1/oG+9Z4TG5j8uBpvkO7GDYEs8AzNSzCdMA8prFfDvYFRJZdW9NV2vdO3yNIg5ckKTr/ng4q76N/hBIRE2iEhDgTgGLpiKllvfk4fghEMHf5H2jZS0Gxzf6/n9Y8JviwUB21vUZmiPI+F1e54IddtrHSCdA3a5S0Brts= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 352b873c-e127-4571-c13b-08d71a4ab337 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Aug 2019 08:47:23.1323 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pbhagavatula@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2038 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-06_05:2019-07-31,2019-08-06 signatures=0 Subject: Re: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Hemant Agrawal >Sent: Tuesday, August 6, 2019 1:49 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran >Cc: dev@dpdk.org >Subject: RE: [dpdk-dev] [RFC 0/3] ethdev: add ptype as Rx offload >> >> Add PTYPE to DEV_RX_OFFLOAD_* flags. >> >> Currently, most of the NICs already support PTYPE parsing and update >the >> mbuf->packet_type through an internal lookup table, but there is no >way to >> disable the lookup if the application is not intrested in ptypes >returned by >> `rte_eth_dev_get_supported_ptypes`. >> >[Hemant] it will also mean introducing another check in datapath, if the >application has asked for PTYPE offload - copy the results to mbuf- >>packet_type otherwise don't do it. > I think that having the check would give better performance than loading pt= ype table to L1=20 doing a lookup and copying it to mbuf when the application doesn't need it= . >Your second patch is incomplete in the sense that it only adds the >capability. But it does not disable the lookups? It is upto the maintainer of the PMD to disable the lookup in data path. If= there is a scope of optimization=20 then they could do it. There is no harm in exposing PTYPE even RX_OFFLOAD_= PTYPE is not enabled. I was hesitant to touch data path as it would be impossible to verify perfo= rmance effect on all NICs.