From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
"Bernard Iremonger" <bernard.iremonger@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask
Date: Mon, 11 Nov 2019 14:59:06 +0000 [thread overview]
Message-ID: <CY4PR1801MB1863F2C9FC89C8F3D93AD8CBDE740@CY4PR1801MB1863.namprd18.prod.outlook.com> (raw)
>On 11/11/2019 1:19 PM, pbhagavatula@marvell.com wrote:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Add command to set supported ptype mask.
>> Usage:
>> set port <port_id> ptype_mask <ptype_mask>
>>
>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
><...>
>
>> +set port supported ptypes
>> +~~~~~~~~~~~~~~~~~~~~~~~~~
>> +
>> +set packet types classification for a specific port::
>> +
>> + testpmd> set port (port_id) ptypes_mask (mask)
>> +
>> show device info
>> ~~~~~~~~~~~~~~~~
>>
>
>When I run the command [1] on a device that doesn't support it, I am
>getting:
>"Successfully set following ptypes for Port 0"
>
>I still think this is wrong and we should fix it, and introduce '-ENOTSUP'
>to
>'rte_eth_dev_set_ptypes()' as other APIs. Since the API is experimental
>we can
>do it later for sake of making the set for rc2.
>
>Can we please keep tracing the discussion for this one for rc3?
Agreed we can continue the discussion for -ENOTSUP in rc3.
I will send a patch if everyone agrees on -ENOTSUP.
>
>[1]
>testpmd> set port 0 ptype_mask 0
next reply other threads:[~2019-11-11 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 14:59 Pavan Nikhilesh Bhagavatula [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-06 19:17 [dpdk-dev] [PATCH v16 0/8] ethdev: add new Rx offload flags pbhagavatula
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 00/10] " pbhagavatula
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-11-11 14:51 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1801MB1863F2C9FC89C8F3D93AD8CBDE740@CY4PR1801MB1863.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).