* Re: [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask @ 2019-11-11 14:59 Pavan Nikhilesh Bhagavatula 0 siblings, 0 replies; 3+ messages in thread From: Pavan Nikhilesh Bhagavatula @ 2019-11-11 14:59 UTC (permalink / raw) To: Ferruh Yigit, arybchenko, Jerin Jacob Kollanukkaran, thomas, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger, John McNamara, Marko Kovacevic Cc: dev >On 11/11/2019 1:19 PM, pbhagavatula@marvell.com wrote: >> From: Pavan Nikhilesh <pbhagavatula@marvell.com> >> >> Add command to set supported ptype mask. >> Usage: >> set port <port_id> ptype_mask <ptype_mask> >> >> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> > ><...> > >> +set port supported ptypes >> +~~~~~~~~~~~~~~~~~~~~~~~~~ >> + >> +set packet types classification for a specific port:: >> + >> + testpmd> set port (port_id) ptypes_mask (mask) >> + >> show device info >> ~~~~~~~~~~~~~~~~ >> > >When I run the command [1] on a device that doesn't support it, I am >getting: >"Successfully set following ptypes for Port 0" > >I still think this is wrong and we should fix it, and introduce '-ENOTSUP' >to >'rte_eth_dev_set_ptypes()' as other APIs. Since the API is experimental >we can >do it later for sake of making the set for rc2. > >Can we please keep tracing the discussion for this one for rc3? Agreed we can continue the discussion for -ENOTSUP in rc3. I will send a patch if everyone agrees on -ENOTSUP. > >[1] >testpmd> set port 0 ptype_mask 0 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH v16 0/8] ethdev: add new Rx offload flags
@ 2019-11-06 19:17 pbhagavatula
2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 00/10] " pbhagavatula
0 siblings, 1 reply; 3+ messages in thread
From: pbhagavatula @ 2019-11-06 19:17 UTC (permalink / raw)
To: ferruh.yigit, arybchenko, jerinj, thomas; +Cc: dev, Pavan Nikhilesh
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used
to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also
`ol_flags:PKT_RX_RSS`.
Add new packet type set function `rte_eth_dev_set_ptypes`,
allows application to inform PMDs about the packet types it is interested
in. Based on ptypes requested by application PMDs can optimize the Rx path.
For example, if a given PMD doesn't support any packet types that the
application is interested in then the application can disable[1] writes to
`mbuf.packet_type` done by the PMD and use a software ptype parser.
[1] rte_eth_dev_set_ptypes(*port_id*, RTE_PTYPE_UNKNOWN,
NULL, 0);
v16 Changes:
-----------
- Fix testpmd documentation(Bernard).
- s/rte_eth_dev_set_supported_ptypes/rte_eth_dev_set_ptypes.
- Fix release notes placement.
- Enhance offload validation(Andrew).
- Remove if condition in drivers/net while enabling RSS_HASH by default.
- Spilt 5/7 into two patches.
v15 Changes:
-----------
- Fix sfc RSS_HASH offload check.
- Fix ethdev RSS_HASH offload check when mq_mode is configured with
MQ_RX_NONE.
- Extend offload validation to return error in the case where application
has requested an offload to be enabled and PMD couldn't honor it.
v14 Changes:
-----------
- Remove log from drives
- Add log in rte_eth_dev_configure when certain offloads are requested to be
disabled and PMD cannot honor the request.
- Make changes to default offloads in net/sfc.(Andrew)
v13 Changes:
-----------
- Remove DEV_RX_OFFLOAD_FLOW_MARK from this patchset to allow foreward
progress will be sent as a seperate patch.
- Use set_supported function only for l2fwd and testpmd.
- Add info log in drivers which expose the DEV_RX_OFFLOAD_RSS_HASH
indicating that disabling DEV_RX_OFFLOAD_RSS_HASH is not supported.
- Few documentation changes.
v12 Changes:
-----------
- Rebase onto next-net.
v11 Changes:
-----------
- Use RTE_DIM to get array size.
- Since we are using a list of MASKs to validate ptype_mask return -EINVAL
if any unknown mask is set.
- Rebase to TOT.
v10 Changes:
-----------
- Modify ptype_mask validation in set_supported_ptypes.(Andrew)
v9 Changes:
----------
- Add ptype_mask validation in set_supported_ptypes.(Andrew)
- Make description more verbose.
v8 Changes:
----------
- Make description more verbose.
- Set RTE_PTYPE_UNKNOWN in set_ptypes array when either get ot set ptypes
is not supported by ethernet device.
v7 Changes:
----------
- Fix unused variable in net/octeontx2
v6 Changes:
----------
- Add additional checks for set supported ptypes.(Andrew)
- Clarify `rte_eth_dev_set_supported_ptypes` documentation.
- Remove DEV_RX_OFFLOAD_FLOW_MARK emulation from net/octeontx2.
v5 Changes:
----------
- Fix typos.
v4 Changes:
----------
- Set the last element in set_ptype array as RTE_PTYPE_UNKNOWN to mark the end
of array.
- Fix invalid set ptype function call in examples.
- Remove setting rte_eth_dev_set_supported_ptypes to UNKNOWN in l3fwd-power.
v3 Changes:
----------
- Add missing release notes. (Andrew)
- Re-word various descriptions.
- Fix ptype set logic.
v2 Changes:
----------
- Update release notes. (Andrew)
- Redo commit logs. (Andrew)
- Disable ptype parsing for unsupported examples. (Jerin)
- Disable RSS write only in generic mode eventdev_pipeline. (Jerin)
- Modify set_supported_ptypes function to return successfuly set mask
instead of failure.
- Dropped set_supported_ptypes to drivers by handling in library
layer, interested PMD can add it in.
Pavan Nikhilesh (8):
ethdev: add set ptype function
ethdev: add mbuf RSS update as an offload
ethdev: add validation to offloads set by PMD
drivers/net: update Rx RSS hash offload capabilities
examples/eventdev_pipeline: split port init sequence
examples/eventdev_pipeline: add new Rx RSS hash offload
examples/l2fwd: disable ptype parsing
app/testpmd: add command to set supported ptype mask
app/test-pmd/cmdline.c | 83 ++++++++
app/test-pmd/testpmd.c | 5 +
doc/guides/nics/features.rst | 9 +-
doc/guides/rel_notes/release_19_11.rst | 15 ++
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 +
drivers/net/bnxt/bnxt_ethdev.c | 6 +-
drivers/net/cxgbe/cxgbe.h | 3 +-
drivers/net/cxgbe/cxgbe_ethdev.c | 2 +
drivers/net/dpaa/dpaa_ethdev.c | 3 +-
drivers/net/dpaa2/dpaa2_ethdev.c | 1 +
drivers/net/e1000/igb_ethdev.c | 4 +
drivers/net/e1000/igb_rxtx.c | 3 +-
drivers/net/enic/enic_ethdev.c | 2 +
drivers/net/enic/enic_res.c | 3 +-
drivers/net/fm10k/fm10k_ethdev.c | 5 +-
drivers/net/hinic/hinic_pmd_ethdev.c | 5 +-
drivers/net/i40e/i40e_ethdev.c | 5 +-
drivers/net/iavf/iavf_ethdev.c | 5 +-
drivers/net/ice/ice_ethdev.c | 5 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 5 +
drivers/net/ixgbe/ixgbe_rxtx.c | 3 +-
drivers/net/liquidio/lio_ethdev.c | 5 +-
drivers/net/mlx4/mlx4.c | 2 +
drivers/net/mlx4/mlx4_rxq.c | 3 +-
drivers/net/mlx5/mlx5_ethdev.c | 3 +
drivers/net/mlx5/mlx5_rxq.c | 3 +-
drivers/net/netvsc/hn_ethdev.c | 2 +
drivers/net/netvsc/hn_rndis.c | 3 +-
drivers/net/nfp/nfp_net.c | 5 +-
drivers/net/octeontx2/otx2_ethdev.c | 3 +-
drivers/net/octeontx2/otx2_ethdev.h | 15 +-
drivers/net/qede/qede_ethdev.c | 5 +-
drivers/net/sfc/sfc_ef10_essb_rx.c | 3 +-
drivers/net/sfc/sfc_ef10_rx.c | 3 +-
drivers/net/sfc/sfc_rx.c | 7 +-
drivers/net/thunderx/nicvf_ethdev.c | 2 +
drivers/net/thunderx/nicvf_ethdev.h | 3 +-
drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +-
examples/eventdev_pipeline/main.c | 128 ------------
.../pipeline_worker_generic.c | 132 +++++++++++++
.../eventdev_pipeline/pipeline_worker_tx.c | 128 ++++++++++++
examples/l2fwd/Makefile | 1 +
examples/l2fwd/main.c | 2 +
examples/l2fwd/meson.build | 1 +
lib/librte_ethdev/rte_ethdev.c | 184 +++++++++++++++++-
lib/librte_ethdev/rte_ethdev.h | 37 ++++
lib/librte_ethdev/rte_ethdev_core.h | 18 ++
lib/librte_ethdev/rte_ethdev_version.map | 1 +
48 files changed, 715 insertions(+), 168 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags 2019-11-06 19:17 [dpdk-dev] [PATCH v16 0/8] ethdev: add new Rx offload flags pbhagavatula @ 2019-11-11 13:19 ` pbhagavatula 2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask pbhagavatula 0 siblings, 1 reply; 3+ messages in thread From: pbhagavatula @ 2019-11-11 13:19 UTC (permalink / raw) To: ferruh.yigit, arybchenko, jerinj, thomas; +Cc: dev, Pavan Nikhilesh From: Pavan Nikhilesh <pbhagavatula@marvell.com> Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also `ol_flags:PKT_RX_RSS`. Add new packet type set function `rte_eth_dev_set_ptypes`, allows application to inform PMDs about the packet types it is interested in. Based on ptypes requested by application PMDs can optimize the Rx path. For example, if a given PMD doesn't support any packet types that the application is interested in then the application can disable[1] writes to `mbuf.packet_type` done by the PMD and use a software ptype parser. [1] rte_eth_dev_set_ptypes(*port_id*, RTE_PTYPE_UNKNOWN, NULL, 0); v17 Changes: ----------- - Split 8/8 into two patches. - Add rss_hash to port rx_offloads in testpmd. - Add log when set_ptype fails. - Fix few spell check. v16 Changes: ----------- - Fix testpmd documentation(Bernard). - s/rte_eth_dev_set_supported_ptypes/rte_eth_dev_set_ptypes. - Fix release notes placement. - Enhance offload validation(Andrew). - Remove if condition in drivers/net while enabling RSS_HASH by default. - Spilt 5/7 into two patches. v15 Changes: ----------- - Fix sfc RSS_HASH offload check. - Fix ethdev RSS_HASH offload check when mq_mode is configured with MQ_RX_NONE. - Extend offload validation to return error in the case where application has requested an offload to be enabled and PMD couldn't honor it. v14 Changes: ----------- - Remove log from drives - Add log in rte_eth_dev_configure when certain offloads are requested to be disabled and PMD cannot honor the request. - Make changes to default offloads in net/sfc.(Andrew) v13 Changes: ----------- - Remove DEV_RX_OFFLOAD_FLOW_MARK from this patchset to allow foreward progress will be sent as a seperate patch. - Use set_supported function only for l2fwd and testpmd. - Add info log in drivers which expose the DEV_RX_OFFLOAD_RSS_HASH indicating that disabling DEV_RX_OFFLOAD_RSS_HASH is not supported. - Few documentation changes. v12 Changes: ----------- - Rebase onto next-net. v11 Changes: ----------- - Use RTE_DIM to get array size. - Since we are using a list of MASKs to validate ptype_mask return -EINVAL if any unknown mask is set. - Rebase to TOT. v10 Changes: ----------- - Modify ptype_mask validation in set_supported_ptypes.(Andrew) v9 Changes: ---------- - Add ptype_mask validation in set_supported_ptypes.(Andrew) - Make description more verbose. v8 Changes: ---------- - Make description more verbose. - Set RTE_PTYPE_UNKNOWN in set_ptypes array when either get ot set ptypes is not supported by ethernet device. v7 Changes: ---------- - Fix unused variable in net/octeontx2 v6 Changes: ---------- - Add additional checks for set supported ptypes.(Andrew) - Clarify `rte_eth_dev_set_supported_ptypes` documentation. - Remove DEV_RX_OFFLOAD_FLOW_MARK emulation from net/octeontx2. v5 Changes: ---------- - Fix typos. v4 Changes: ---------- - Set the last element in set_ptype array as RTE_PTYPE_UNKNOWN to mark the end of array. - Fix invalid set ptype function call in examples. - Remove setting rte_eth_dev_set_supported_ptypes to UNKNOWN in l3fwd-power. v3 Changes: ---------- - Add missing release notes. (Andrew) - Re-word various descriptions. - Fix ptype set logic. v2 Changes: ---------- - Update release notes. (Andrew) - Redo commit logs. (Andrew) - Disable ptype parsing for unsupported examples. (Jerin) - Disable RSS write only in generic mode eventdev_pipeline. (Jerin) - Modify set_supported_ptypes function to return successfuly set mask instead of failure. - Dropped set_supported_ptypes to drivers by handling in library layer, interested PMD can add it in. Pavan Nikhilesh (10): ethdev: add set ptype function ethdev: add mbuf RSS update as an offload ethdev: add validation to offloads set by PMD drivers/net: update Rx RSS hash offload capabilities examples/eventdev_pipeline: split port init sequence examples/eventdev_pipeline: add new Rx RSS hash offload examples/l2fwd: disable ptype parsing app/testpmd: add command to set supported ptype mask app/testpmd: disable packet type parsing by default app/testpmd: add RSS hash offload to port Rx offload cmd app/test-pmd/cmdline.c | 90 ++++++++- app/test-pmd/testpmd.c | 12 ++ app/test-pmd/testpmd.h | 1 + doc/guides/nics/features.rst | 9 +- doc/guides/rel_notes/release_19_11.rst | 15 ++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 +- drivers/net/bnxt/bnxt_ethdev.c | 6 +- drivers/net/cxgbe/cxgbe.h | 3 +- drivers/net/cxgbe/cxgbe_ethdev.c | 2 + drivers/net/dpaa/dpaa_ethdev.c | 3 +- drivers/net/dpaa2/dpaa2_ethdev.c | 1 + drivers/net/e1000/igb_ethdev.c | 4 + drivers/net/e1000/igb_rxtx.c | 3 +- drivers/net/enic/enic_ethdev.c | 2 + drivers/net/enic/enic_res.c | 3 +- drivers/net/fm10k/fm10k_ethdev.c | 5 +- drivers/net/hinic/hinic_pmd_ethdev.c | 5 +- drivers/net/i40e/i40e_ethdev.c | 5 +- drivers/net/iavf/iavf_ethdev.c | 5 +- drivers/net/ice/ice_ethdev.c | 5 +- drivers/net/ixgbe/ixgbe_ethdev.c | 5 + drivers/net/ixgbe/ixgbe_rxtx.c | 3 +- drivers/net/liquidio/lio_ethdev.c | 5 +- drivers/net/mlx4/mlx4.c | 2 + drivers/net/mlx4/mlx4_rxq.c | 3 +- drivers/net/mlx5/mlx5_ethdev.c | 3 + drivers/net/mlx5/mlx5_rxq.c | 3 +- drivers/net/netvsc/hn_ethdev.c | 2 + drivers/net/netvsc/hn_rndis.c | 3 +- drivers/net/nfp/nfp_net.c | 5 +- drivers/net/octeontx2/otx2_ethdev.c | 3 +- drivers/net/octeontx2/otx2_ethdev.h | 15 +- drivers/net/qede/qede_ethdev.c | 5 +- drivers/net/sfc/sfc_ef10_essb_rx.c | 3 +- drivers/net/sfc/sfc_ef10_rx.c | 3 +- drivers/net/sfc/sfc_rx.c | 7 +- drivers/net/thunderx/nicvf_ethdev.c | 2 + drivers/net/thunderx/nicvf_ethdev.h | 3 +- drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 +- examples/eventdev_pipeline/main.c | 128 ------------ .../pipeline_worker_generic.c | 132 +++++++++++++ .../eventdev_pipeline/pipeline_worker_tx.c | 128 ++++++++++++ examples/l2fwd/Makefile | 2 + examples/l2fwd/main.c | 5 + examples/l2fwd/meson.build | 2 + lib/librte_ethdev/rte_ethdev.c | 182 +++++++++++++++++- lib/librte_ethdev/rte_ethdev.h | 37 ++++ lib/librte_ethdev/rte_ethdev_core.h | 17 ++ lib/librte_ethdev/rte_ethdev_version.map | 1 + 49 files changed, 731 insertions(+), 171 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask 2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 00/10] " pbhagavatula @ 2019-11-11 13:19 ` pbhagavatula 2019-11-11 14:51 ` Ferruh Yigit 0 siblings, 1 reply; 3+ messages in thread From: pbhagavatula @ 2019-11-11 13:19 UTC (permalink / raw) To: ferruh.yigit, arybchenko, jerinj, thomas, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger, John McNamara, Marko Kovacevic Cc: dev, Pavan Nikhilesh From: Pavan Nikhilesh <pbhagavatula@marvell.com> Add command to set supported ptype mask. Usage: set port <port_id> ptype_mask <ptype_mask> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> --- app/test-pmd/cmdline.c | 84 +++++++++++++++++++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 7 ++ 2 files changed, 91 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 48627c8aa..da556f91e 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -671,6 +671,9 @@ static void cmd_help_long_parsed(void *parsed_result, "ptype mapping update (port_id) (hw_ptype) (sw_ptype)\n" " Update a ptype mapping item on a port\n\n" + "set port (port_id) ptype_mask (ptype_mask)\n" + " set packet types classification for a specific port\n\n" + "set port (port_id) queue-region region_id (value) " "queue_start_index (value) queue_num (value)\n" " Set a queue region on a port\n\n" @@ -19015,6 +19018,86 @@ cmdline_parse_inst_t cmd_show_rx_tx_desc_status = { }, }; +/* Common result structure for set port ptypes */ +struct cmd_set_port_ptypes_result { + cmdline_fixed_string_t set; + cmdline_fixed_string_t port; + portid_t port_id; + cmdline_fixed_string_t ptype_mask; + uint32_t mask; +}; + +/* Common CLI fields for set port ptypes */ +cmdline_parse_token_string_t cmd_set_port_ptypes_set = + TOKEN_STRING_INITIALIZER + (struct cmd_set_port_ptypes_result, + set, "set"); +cmdline_parse_token_string_t cmd_set_port_ptypes_port = + TOKEN_STRING_INITIALIZER + (struct cmd_set_port_ptypes_result, + port, "port"); +cmdline_parse_token_num_t cmd_set_port_ptypes_port_id = + TOKEN_NUM_INITIALIZER + (struct cmd_set_port_ptypes_result, + port_id, UINT16); +cmdline_parse_token_string_t cmd_set_port_ptypes_mask_str = + TOKEN_STRING_INITIALIZER + (struct cmd_set_port_ptypes_result, + ptype_mask, "ptype_mask"); +cmdline_parse_token_num_t cmd_set_port_ptypes_mask_u32 = + TOKEN_NUM_INITIALIZER + (struct cmd_set_port_ptypes_result, + mask, UINT32); + +static void +cmd_set_port_ptypes_parsed( + void *parsed_result, + __attribute__((unused)) struct cmdline *cl, + __attribute__((unused)) void *data) +{ + struct cmd_set_port_ptypes_result *res = parsed_result; +#define PTYPE_NAMESIZE 256 + char ptype_name[PTYPE_NAMESIZE]; + uint16_t port_id = res->port_id; + uint32_t ptype_mask = res->mask; + int ret, i; + + ret = rte_eth_dev_get_supported_ptypes(port_id, RTE_PTYPE_ALL_MASK, + NULL, 0); + if (ret <= 0) { + printf("Port %d doesn't support any ptypes.\n", port_id); + return; + } + + uint32_t ptypes[ret]; + + ret = rte_eth_dev_set_ptypes(port_id, ptype_mask, ptypes, ret); + if (ret < 0) { + printf("Unable to set requested ptypes for Port %d\n", port_id); + return; + } + + printf("Successfully set following ptypes for Port %d\n", port_id); + for (i = 0; i < ret && ptypes[i] != RTE_PTYPE_UNKNOWN; i++) { + rte_get_ptype_name(ptypes[i], ptype_name, sizeof(ptype_name)); + printf("%s\n", ptype_name); + } +} + +cmdline_parse_inst_t cmd_set_port_ptypes = { + .f = cmd_set_port_ptypes_parsed, + .data = NULL, + .help_str = "set port <port_id> ptype_mask <mask>", + .tokens = { + (void *)&cmd_set_port_ptypes_set, + (void *)&cmd_set_port_ptypes_port, + (void *)&cmd_set_port_ptypes_port_id, + (void *)&cmd_set_port_ptypes_mask_str, + (void *)&cmd_set_port_ptypes_mask_u32, + NULL, + }, +}; + /* ******************************************************************************** */ /* list of instructions */ @@ -19254,6 +19337,7 @@ cmdline_parse_ctx_t main_ctx[] = { (cmdline_parse_inst_t *)&cmd_show_vf_stats, (cmdline_parse_inst_t *)&cmd_clear_vf_stats, (cmdline_parse_inst_t *)&cmd_show_port_supported_ptypes, + (cmdline_parse_inst_t *)&cmd_set_port_ptypes, (cmdline_parse_inst_t *)&cmd_ptype_mapping_get, (cmdline_parse_inst_t *)&cmd_ptype_mapping_replace, (cmdline_parse_inst_t *)&cmd_ptype_mapping_reset, diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index 9a5e5cb05..c331b4d90 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -480,6 +480,13 @@ Show ptypes supported for a specific port:: testpmd> show port (port_id) ptypes +set port supported ptypes +~~~~~~~~~~~~~~~~~~~~~~~~~ + +set packet types classification for a specific port:: + + testpmd> set port (port_id) ptypes_mask (mask) + show device info ~~~~~~~~~~~~~~~~ -- 2.17.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask 2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask pbhagavatula @ 2019-11-11 14:51 ` Ferruh Yigit 0 siblings, 0 replies; 3+ messages in thread From: Ferruh Yigit @ 2019-11-11 14:51 UTC (permalink / raw) To: pbhagavatula, arybchenko, jerinj, thomas, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger, John McNamara, Marko Kovacevic Cc: dev On 11/11/2019 1:19 PM, pbhagavatula@marvell.com wrote: > From: Pavan Nikhilesh <pbhagavatula@marvell.com> > > Add command to set supported ptype mask. > Usage: > set port <port_id> ptype_mask <ptype_mask> > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> <...> > +set port supported ptypes > +~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +set packet types classification for a specific port:: > + > + testpmd> set port (port_id) ptypes_mask (mask) > + > show device info > ~~~~~~~~~~~~~~~~ > When I run the command [1] on a device that doesn't support it, I am getting: "Successfully set following ptypes for Port 0" I still think this is wrong and we should fix it, and introduce '-ENOTSUP' to 'rte_eth_dev_set_ptypes()' as other APIs. Since the API is experimental we can do it later for sake of making the set for rc2. Can we please keep tracing the discussion for this one for rc3? [1] testpmd> set port 0 ptype_mask 0 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-11 14:59 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-11-11 14:59 [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask Pavan Nikhilesh Bhagavatula -- strict thread matches above, loose matches on Subject: below -- 2019-11-06 19:17 [dpdk-dev] [PATCH v16 0/8] ethdev: add new Rx offload flags pbhagavatula 2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 00/10] " pbhagavatula 2019-11-11 13:19 ` [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask pbhagavatula 2019-11-11 14:51 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).