From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8243A0555; Wed, 19 Feb 2020 05:32:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2374F1BF7A; Wed, 19 Feb 2020 05:32:34 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 087ED2952 for ; Wed, 19 Feb 2020 05:32:31 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01J4GobF007320; Tue, 18 Feb 2020 20:32:30 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=5vszKh07u8aKluD5lMu+5f4G/TE3c/aisGoV6JwuZjs=; b=oSXUDY5OUCOl1qrDOu/tVYLrRil8wwZboa1R67+10ObJM3X+khFTc2vNbNvARrch4uRZ rDcC7R9YY3B2BkRRtfFtVtYXxCNQMPV3AWZ6wPkDDolTe5cTA+E5wzGQYWvlKwk9N47i 87hTgJS4xi0KkPHnEF9UdEl2wHM0cARNf/0PTK9UgxzEUCtD5ed5SfivzPIrNLUJ7hSw dbvXs5ycY9Zm/K1rzbpR9mOZYCsPY0nZ3eKfQnqqj1QHH8CEV0bwg079xGLDTKTzpLiH QmLs9QO0MFm+wuXBHj9yCw1nYXFjCaUNeEQ663KOkI5bWxqGe0nDaM2IPe3FCcfmOimB dw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 2y8ubh8jkd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 18 Feb 2020 20:32:30 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 Feb 2020 20:32:29 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 18 Feb 2020 20:32:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N0JMGeGBdDCtP2SJFVQ6dhBZL0aP2UCRVIAJB51CQacaplDyce1cVTofXOLayQDPtvJp9Umz6MSFdh/AHUsK0hlva7Ca+yMGaAzDZylMf9JasmgBj0PFKnnRbnEPG3L3E2NbDWhYYXjaEVOhA1CsPqXjSk/ArIN53magr/NjVBKmsj3KzDkMxp1VrDmRR3vN5W/QcNki9d6T1fqST+n4VbC8C44zHs78nmNjooz8oPKJnR73lBL4wM58xoeOPV/W6nfG5eBHuH7axHJsfPQGTxU1mHF5dzXVoAzClZsNDUwJqIWppwCdhK5ixrpZVl8Wnq2JpIHBUphAU4aUYONSUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5vszKh07u8aKluD5lMu+5f4G/TE3c/aisGoV6JwuZjs=; b=gLg7tg975Rot9hknOWpRoqs9xMLftvycJPoj+iZrARoFqW9hMtUtprWt3qHwgBnt85nNRHO6e47VHDFSOUym8gwjZedQzsEL67z1eVHZiAbP7dk45BVM7sRTxfhzSSaq9w6yDnIlM7bI1lMlcyyE6qYuxYc23tnG8e89/bjjYXNasn8ILl7tq5f4vKvP9YKYzHHdlcWPavf1H5qAFdw67MccE9xueDw/nHqMqmjjX6VZbYqffgqVvhk8jaCP0VfiA+AKSdboRdsYigrZxG6MK/gPVyOGqavxqT6/FJKaIONR1iIOPLE2DV6sIK3PUkOqLX900YKZJvzaTFDOcGhSCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5vszKh07u8aKluD5lMu+5f4G/TE3c/aisGoV6JwuZjs=; b=ffijuBvgeCSi+sgDwVJYhAMIJUc4eyKtMMz7i8bDiLP8can6aoL08G45JCDAqHfFMytqhc7knmB0Z/DZZxK+NxDnNwpwEOwcXUnECU1uCD/RTZDNduqy4ZH/gjoI8V77G4WeCD6QgKzJ/fKorcjGIjDlTROpax7z7nzkMXzTV/w= Received: from CY4PR1801MB1926.namprd18.prod.outlook.com (10.171.253.24) by BN8SPR01MB0016.namprd18.prod.outlook.com (20.178.217.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.22; Wed, 19 Feb 2020 04:32:26 +0000 Received: from CY4PR1801MB1926.namprd18.prod.outlook.com ([fe80::e869:1c22:5c93:656a]) by CY4PR1801MB1926.namprd18.prod.outlook.com ([fe80::e869:1c22:5c93:656a%4]) with mapi id 15.20.2729.032; Wed, 19 Feb 2020 04:32:26 +0000 From: Amit Gupta To: Bruce Richardson CC: Harman Kalra , "dev@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled Thread-Index: AQHV5WaUu6dsogQuNkebwiPxnIkN46gfNNeAgAK7G7A= Date: Wed, 19 Feb 2020 04:32:26 +0000 Message-ID: References: <1581925669-15294-1-git-send-email-agupta3@marvell.com> <20200217104843.GB861@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200217104843.GB861@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 892aef1b-5a33-402c-8af9-08d7b4f4b8e3 x-ms-traffictypediagnostic: BN8SPR01MB0016: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0318501FAE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(366004)(346002)(396003)(39850400004)(199004)(189003)(81156014)(7696005)(33656002)(8676002)(81166006)(55236004)(8936002)(2906002)(186003)(316002)(9686003)(64756008)(53546011)(66946007)(76116006)(6506007)(66476007)(66446008)(66556008)(6916009)(86362001)(55016002)(52536014)(26005)(54906003)(4326008)(5660300002)(71200400001)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8SPR01MB0016; H:CY4PR1801MB1926.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F7eehHcjfOhEyeHK3RJ+8f65y3MWqyJdhh/tflzYhbLTgv841goq3Hi8LpXf43+sEJiQ9pK1/svUyFuJwl5uZx/hOaydp4yRILAOqTlc2XVukQ0VnnFP0xbSMJCH+X+373VM6OjCVHPVr1KneM4ou6f4/g+QJTvzVitTPhfVS5CdsCrN4EMM+iiiY+0xjM4CMvGk7GnvHwWZi2xVgIAl/bnoeocKfvQaziLIREk9bH7g65htI9F13a2Dn+cQUaYKp/q0Jt70hV3A8piXv7Ab5iAoZNrDEes6RqhifNM3syQNhMjX6dZEmUd0oCVf1uHcSxO02pgoqNTkrO/Qt2fGffjaEnR7MdrvKfFovbKTFUr50oRebu59+NLY908iUnyx9jTQY1hatVmG1EKNLFBGZmWvMg4BBq6SEQf2trKjE/j+/HOAw508g7vdH6QDvaOB x-ms-exchange-antispam-messagedata: 7pbzzxrXtHdFc98qVgAZzs6s1ZrhFEEuKGUJXhHl1Qjd3jlO8TIzf88OQahqKtOUbv2Z2U1UnItSdZgm7zsUo8AvCjlTVEjiejiw2lUkvNCa/ZXJBodK2IzqqTyxuOaTy7O4Cum1qKZmhlSOVWv6pQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 892aef1b-5a33-402c-8af9-08d7b4f4b8e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2020 04:32:26.1925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sSP2boN9CbYXHHjKS4RhCQvYnwT5hVon0zVz5KtQ8NgwVbozKACHR61509ecU5cMJ44vCHNzd62ZGDDwxWeyuw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8SPR01MB0016 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-18_08:2020-02-18, 2020-02-18 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH] net/octeontx: meson build fix if octeontx drivers are disabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Monday, February 17, 2020 4:19 PM > To: Amit Gupta > Cc: Harman Kalra ; dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [PATCH] net/octeontx: meson build fix if > octeontx drivers are disabled >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Mon, Feb 17, 2020 at 01:17:49PM +0530, agupta3@marvell.com wrote: > > From: Amit Gupta > > > > Add a condition to check if octeontx drivers are disabled. > > octeontx drivers are built only if dependent drivers i.e. > > ethdev, mempool and common/octeontx are enabled. > > > > BugZilla ID # BUG 387 > > > > Signed-off-by: Amit Gupta > > --- > > drivers/net/octeontx/base/meson.build | 32 > > ++++++++++++++++++++++++-------- > > 1 file changed, 24 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/net/octeontx/base/meson.build > > b/drivers/net/octeontx/base/meson.build > > index a06a2c8..50e7972 100644 > > --- a/drivers/net/octeontx/base/meson.build > > +++ b/drivers/net/octeontx/base/meson.build > > @@ -9,17 +9,33 @@ sources =3D [ > > > > depends =3D ['ethdev', 'mempool_octeontx'] static_objs =3D [] -foreac= h > > d: depends > > - static_objs +=3D [get_variable('static_rte_' + d)] > > + > > +disabled_drivers =3D get_option('disable_drivers').split(',') > > + > > +build =3D true > > +foreach disable_path: disabled_drivers > > + if (('net/octeontx' =3D=3D disable_path) or > > + ('event/octeontx' =3D=3D disable_path) or > > + ('common/octeontx' =3D=3D disable_path) or > > + ('mempool/octeontx' =3D=3D disable_path)) > > + build =3D false > > + endif > > endforeach > > > > c_args =3D cflags > > if allow_experimental_apis > > - c_args +=3D '-DALLOW_EXPERIMENTAL_API' > > + c_args +=3D '-DALLOW_EXPERIMENTAL_API' > > endif > > -base_lib =3D static_library('octeontx_base', sources, > > - c_args: c_args, > > - dependencies: static_objs, > > -) > > > > -base_objs =3D base_lib.extract_all_objects() > > +if build > > + foreach d: depends > > + static_objs +=3D [get_variable('static_rte_' + d)] > > + endforeach > > + > > + base_lib =3D static_library('octeontx_base', sources, > > + c_args: c_args, > > + dependencies: static_objs, > > + ) > > + > > + base_objs =3D base_lib.extract_all_objects() endif >=20 > A better fix here might be possible using the fact that the get_variable(= ) call > allows passing a fallback value in the case of failure. Therefore somethi= ng like > the below might work cleaner: ACK, will update the same in V2 >=20 > foreach d: depends > static_obj =3D [get_variable('static_rte_' + d, ''] > if static_obj =3D=3D '' > build =3D false > reason =3D '....' > subdir_done() > endif > static_objs +=3D static_obj > ... >=20 > Maybe a disabler object could be used also. >=20 > Regards, > /Bruce