From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id A04D21B427 for ; Tue, 12 Feb 2019 12:19:10 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x1CBEuCY028393; Tue, 12 Feb 2019 03:19:09 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=I2h/wl/nBkGutRWU7NicXqXnVvOQNVk0VoiMJMOeHSY=; b=U92qzqOQ0kqjWTj8DCbzTjfRCXH9jqvX2naIZ1+/N8XZuTk2aI4tk31eatlgzr/9drUn M+MduvCfu7QoKZI/Coc9p/BU0j5Cel9mUWTtau8vBRSI2BfP2Drldk+mseIDoSUQ8OUe 7ORRHor+Jd0t2fpv5oHzaDgbbKEQzbsImhJ8JmPVeuHSQPC9xTimFeNhGcv/ijXkO/J1 OeU2/YO6AqknTw/CB3VQcUtdvvGmjLkm6qQ3kFedrAmGuTMxrJG95QV9I+XuIEZ2Gf4s /im0vAVR9cmbvZtxAl0woHGbFUot/l8rxjgGEUB9vouvGWc7m3gazkccbZMK8d24l8AH fQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2qkktn9gh0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 12 Feb 2019 03:19:09 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 12 Feb 2019 03:19:07 -0800 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.51) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 12 Feb 2019 03:19:07 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I2h/wl/nBkGutRWU7NicXqXnVvOQNVk0VoiMJMOeHSY=; b=XqDqB1ZVxwM9YJXiBF9aKFc0fB9lk/pH96Q86E+7GyLi/d9YBg0iYIWpJvGTZnuSJOP+wR0CZY2cuqfhpvXLhNPreGNg2WcjN36We26IoIu3NgNmpa8ZmRvZmMyTxUk6K+RuFNW2sWzBwm3KRGiryw9B87RdiaMQ315Avi5xXGs= Received: from CY4PR1801MB2053.namprd18.prod.outlook.com (10.171.255.158) by CY4PR1801MB1815.namprd18.prod.outlook.com (10.165.88.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.16; Tue, 12 Feb 2019 11:19:05 +0000 Received: from CY4PR1801MB2053.namprd18.prod.outlook.com ([fe80::81c3:42cc:43e4:7c4e]) by CY4PR1801MB2053.namprd18.prod.outlook.com ([fe80::81c3:42cc:43e4:7c4e%6]) with mapi id 15.20.1601.023; Tue, 12 Feb 2019 11:19:05 +0000 From: Shally Verma To: "Kusztal, ArkadiuszX" , Ayuj Verma , "Trahe, Fiona" CC: "akhil.goyal@nxp.com" , Kanaka Durga Kotamarthy , Sunila Sahu , "dev@dpdk.org" Thread-Topic: [PATCH 0/3] adding op-type crt sign and decrypt Thread-Index: AQHUvg1gQkJoFzcev0ymVfke48+GsaXVmWXEgACVmtCAA+zJ5IAAVXaggAAS47CAAYLbIIAABUYA Date: Tue, 12 Feb 2019 11:19:05 +0000 Message-ID: References: <20190206111405.30860-1-ayverma@marvell.com> , <348A99DA5F5B7549AA880327E580B435896EBE65@IRSMSX101.ger.corp.intel.com> <06EE24DD0B19E248B53F6DC8657831551B13B064@hasmsx109.ger.corp.intel.com> <06EE24DD0B19E248B53F6DC8657831551B13B21B@hasmsx109.ger.corp.intel.com> In-Reply-To: <06EE24DD0B19E248B53F6DC8657831551B13B21B@hasmsx109.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [223.230.35.64] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 83bedbd9-a46d-4d08-361a-08d690dbe645 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020); SRVR:CY4PR1801MB1815; x-ms-traffictypediagnostic: CY4PR1801MB1815: x-microsoft-exchange-diagnostics: 1; CY4PR1801MB1815; 20:HveTUK+0b+vW+nfAyhKaSMmePgY+ljzCCcZw+bFx7C1sx0VPhd3rap++yHGm3tas/ito6mKRNskimbZR8r6TAP9Q8iJSaaH12hRav+hynJE5NL2YLXg2b+mp0KHRerCyrjFX4yvHSksYsZplAhQ7t8uGtYSMDKVg+/2IpNrVysM= x-microsoft-antispam-prvs: x-forefront-prvs: 0946DC87A1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(39860400002)(136003)(54094003)(13464003)(199004)(189003)(6116002)(3846002)(8676002)(33656002)(93886005)(4326008)(229853002)(2906002)(66066001)(7696005)(25786009)(8936002)(97736004)(81156014)(53936002)(81166006)(6246003)(99286004)(86362001)(71200400001)(71190400001)(305945005)(446003)(105586002)(316002)(486006)(55016002)(106356001)(186003)(9686003)(74316002)(6506007)(53546011)(110136005)(68736007)(76176011)(11346002)(478600001)(102836004)(54906003)(26005)(476003)(256004)(14454004)(7736002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1815; H:CY4PR1801MB2053.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s+RC0EmHs6FVWb8s6GBpE29/8k1AswHD9Sa5DdREfnQcH+q2YMN2Z996O6qa50dIqq61FFbkcocYktjp8NH2XzfKX5agI3ppCVPRzm/f5E7nFJXBz9DPZJ0xQsPuQg5od/AAId1ZgXl4P23NiKia+A/2bB/x6ry9z1VJTHDebOnaUcUaoYjuWl20KURXuLRdi1ZFCkPWBQ2r8Hmr7jAGbYsGZGPdcg3P4kkI9y2NsRF2zBoPQpbYNehccQfIBrBjzAfpUsavTfIF6suIH28l2sTtUkiasOPDdSjTRn4Dzp7tb92ahbTxHfsGmqD5OdVzaGu9sSuppkNExQ9tLvNSW+VmSDYl6OiMZwXZpOAFrT0Y7FkEFjeBpRGa10E2/rLi8v5DhgCkuzTfCcREEkKQdh9gHW9h24Cm7LpbhzZU4fU= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 83bedbd9-a46d-4d08-361a-08d690dbe645 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2019 11:19:05.3495 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1815 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-02-12_07:, , signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=859 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902120083 Subject: Re: [dpdk-dev] [PATCH 0/3] adding op-type crt sign and decrypt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 11:19:11 -0000 Hi Arek >-----Original Message----- >From: Kusztal, ArkadiuszX >Sent: 12 February 2019 16:42 >To: Shally Verma ; Ayuj Verma ; = Trahe, Fiona >Cc: akhil.goyal@nxp.com; Kanaka Durga Kotamarthy = ; Sunila Sahu ; >dev@dpdk.org >Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt > >Hi Shally, Ayuj > >Answers with [AK] > >> -----Original Message----- >> From: Shally Verma [mailto:shallyv@marvell.com] >> Sent: Tuesday, February 12, 2019 6:27 AM >> To: Kusztal, ArkadiuszX ; Ayuj Verma >> ; Trahe, Fiona >> Cc: akhil.goyal@nxp.com; Kanaka Durga Kotamarthy >> ; Sunila Sahu ; >> dev@dpdk.org >> Subject: RE: [PATCH 0/3] adding op-type crt sign and decrypt >> >> HI Arek, >> >> From: Kusztal, ArkadiuszX >> Sent: 11 February 2019 17:11 >> To: Ayuj Verma ; Trahe, Fiona >> ; Shally Verma >> Cc: akhil.goyal@nxp.com >> Subject: [EXT] RE: [PATCH 0/3] adding op-type crt sign and decrypt >> >> External Email >> ________________________________________ >> Hi Ayuj, >> >> Few comments from me. >> >> Some PMDs can only support RSA private key operations using CRT keys >> (quintuple) only. Thus it is required to add in PMD RSA xform capability >> which key type is supported to perform sign and decrypt ops. >> >> >> Thus add an another op_type RTE_CRYPTO_OP_TYPE_SIGN_CRT and >> RTE_CRYPTO_OP_TYPE_DECRYPT_CRT, which would mean perform an >> private key op using CRT keys (quintuple) only. >> [AK] - What would be the purpose of enum rte_crypto_rsa_priv_key_type >> key_type in RSA XFORM then? >> >> [Shally] PMDs, like openssl, can support private key ops with both key t= ype >> i.e. one can invoke RSA_Sign() with quintuple keys or exponent keys. >> Openssl in its capability would reflect it support ops with both key typ= es. >> that's why key_type is still required in xform. > >[AK] But still I wonder if we could not just use this enum to distinguish = between crt and mod exp rsa? >I am not very keen on adding SIGN_CRT op type as it is RSA only. Another o= ption would be to add flags to rsa op like uint64_t flags; [Shally] Ok .. you mean as feature flag? Example, RTE_CRYPTODEV_ASYM_FF_RSA= _PRIV_KEY_OP_CRT? Thanks Shally ... >> Regards, >> Arek