From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF67EA2EDB for ; Sun, 29 Sep 2019 06:28:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FEE63237; Sun, 29 Sep 2019 06:28:59 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 9738F322C for ; Sun, 29 Sep 2019 06:28:58 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x8T4BkOP009103; Sat, 28 Sep 2019 21:28:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=3HJgSSrsakwBORtudSk8VPJXf5AZzfUlfuqeew8elKY=; b=zCrjLdVRlddNr1xeWwarF3hsRj3y7a99mkYIywgBPBs27GFNGk4HFcIKQJgMk/GU8gcr PeQ2nZMrPdXlG616UsREnDymCbKh9i1wSsSdySKlF2qOFycHqLa/zTzHupmciNBPTbfC xh9hyNOQD1FULB/ijCoM+TlvZrLvy/iuQebvOfTEoCLjdxAE98fgQap/N7TzhCca5sZT zuOA6iTgK91AMWH3+ZE/7mFuBJ7+QhWCDigwtG88986LMXJrbcN7KObfWrfUAhRwP/sn Rnr7ENw4vwGMPxBmCpjURr+xD6Woah/a7tQXfYPYI0mr/gzGe2pqfiOIRYKF3noTSiK1 0w== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2va71ma0se-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sat, 28 Sep 2019 21:28:57 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 28 Sep 2019 21:28:56 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sat, 28 Sep 2019 21:28:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S6IgT64BAd10YMftn0JgZaJBgrP5oDmTlXEdfRWhf7y3aLnEfIzPTYd6n7ASKErMDLXAnSH+5FEnJe69kdP2XcRdHi0pKvPTo8N5sKy+wUN1/7j+KkZXhpfprN+Kzrd5Ir8A5DtMogmAbckOvIZkguL9upLmjKPsEvIhLyyQ7dhk0oxL4JRddHWNMDizmyevKg6joa+3Yy69DRekb4GRhEuGdaygWSMH+THkUuiV1yYlxgE0GhbsjevicZS6MxXPCHS7IkX2bFAnvC2gED6Q1kYpjJv+A7Bmnm7EuE3gYuoEaibrd2PIederZmZDAB6JAQDS2Q2T4SyOiGURx+rz+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HJgSSrsakwBORtudSk8VPJXf5AZzfUlfuqeew8elKY=; b=FjGwQSK9dM87QULLPhHhO5wlsG9b+D607lGx+HjJNgPIcn0XA+4qu7q1Lo40gbmaY1u8w7iKazPW3aa3YlBU2Vwf+q8iWaAaVJ2eShbKiJYzC8L13oqT6x3yojezGFjrMaL8bmDYQV1N/RJgXtbpeUqP34ZhD0RwPbjqy6Bps/ZXQfAqAktc5sYPxYKviquehheZHD1CfqxECGoMgJzkpD3XiEp2dTNQcnnD5NAWpFhC3WWaNupcKq0hX/JcJYxpfVS5OUTZDj3GoRCPJBBvIdCzUEArg1sw+Nh4MY7ykaFC6R8ToLYx+0m4Y6VKWa+nKGsuVWy2wv5kdFwgcEig4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3HJgSSrsakwBORtudSk8VPJXf5AZzfUlfuqeew8elKY=; b=yTwKd7+GmfYiD9ycmC5nKpyTfPp/ICkoOyoARt/zvHmNVnHmfxnndGN4oxQRArW35V1XUZX3MeK5ADjUmEInMv5xemf65WyWo14nWBHzDV7vhdwQ4CuMs97iC5PGFkZcwkPw69bGDQABa9GZJiRf/t9EUaLyg7GhvnxvJPjJAHo= Received: from CY4PR18MB1144.namprd18.prod.outlook.com (10.173.184.19) by CY4PR18MB0934.namprd18.prod.outlook.com (10.173.182.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2305.20; Sun, 29 Sep 2019 04:28:54 +0000 Received: from CY4PR18MB1144.namprd18.prod.outlook.com ([fe80::2d29:c0c6:4b83:374a]) by CY4PR18MB1144.namprd18.prod.outlook.com ([fe80::2d29:c0c6:4b83:374a%11]) with mapi id 15.20.2284.028; Sun, 29 Sep 2019 04:28:54 +0000 From: Vivek Kumar Sharma To: "dev@dpdk.org" CC: "intoviveksharma@gmail.com" , "ferruh.yigit@intel.com" Thread-Topic: [PATCH] app/testpmd: introduce QinQ and Rx offloads argument Thread-Index: AQHVaizcx0ab9vuCpUG1yk0QouGhMKdCKHBX Date: Sun, 29 Sep 2019 04:28:54 +0000 Message-ID: References: <1568376860-9502-1-git-send-email-viveksharma@marvell.com> In-Reply-To: <1568376860-9502-1-git-send-email-viveksharma@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [2401:4900:30e4:e02d:a8c6:fbb4:b8e3:e517] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 96af4e8f-6b7a-48e6-f57b-08d7449589d9 x-ms-traffictypediagnostic: CY4PR18MB0934: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 017589626D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39840400004)(136003)(396003)(346002)(366004)(376002)(199004)(189003)(2906002)(54906003)(86362001)(55016002)(6436002)(66446008)(76176011)(64756008)(66556008)(71200400001)(66476007)(6506007)(91956017)(5640700003)(53546011)(14444005)(66946007)(52536014)(33656002)(71190400001)(1730700003)(81166006)(81156014)(46003)(76116006)(2351001)(99286004)(6116002)(446003)(256004)(316002)(11346002)(229853002)(8676002)(8936002)(102836004)(2501003)(14454004)(476003)(6246003)(25786009)(186003)(7696005)(4326008)(74316002)(305945005)(5660300002)(7736002)(9686003)(486006)(6916009)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR18MB0934; H:CY4PR18MB1144.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: srs8A/I7S6xsFBYkVr8MZuqYBw7o2/CI6O9KTc63GZFC30Rnh2IL1vyzoyhPXG3BAMRsVePRc/UQjVeybXhomxrJgqGkJvGvJ3QPhQ+FRBtDyZ6RkX4WGoIa8Rfk/49FtZY82yR8IANxXwnQjSO6ZGepk7cF5SwRCIeqIK7T7TrwAyDERu7FeC02xJL90wJXWoKTVCLrwvzlC8Srila8T1mcLH4CzvosHPF3vENUHHgpUFyengaFm5LSsAx0FsEa7aTcu1scwqmPyTH1ho6BTVDc2GiFQhIRkfQvwIgZb2iKHD7VZS7wMQs9wIHcJ81PTCxnOxJ1K5q7wfw3m4MhZxLRyo79sSA/mfu37GSc6qLzdIKNjcs/jNvBd9GhX2rivlYglEqAZ7g61EvenXDS+/7FG4mqvGozKq8+oK/0Ps4= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 96af4e8f-6b7a-48e6-f57b-08d7449589d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2019 04:28:54.9303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i6bYqfkzGBbupAnPdMh4y60qwEsQf/vdQQHv2ZRs+XI62S13G2DFJ7lZv/3EaXzW5pWMT0UIw9sGiQwjpu+SAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB0934 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-09-29_02:2019-09-25,2019-09-29 signatures=0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: introduce QinQ and Rx offloads argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ping! Thanks, Vivek ________________________________________ From: viveksharma@marvell.com Sent: 13 September 2019 17:44 To: dev@dpdk.org Cc: intoviveksharma@gmail.com; ferruh.yigit@intel.com; Vivek Kumar Sharma Subject: [PATCH] app/testpmd: introduce QinQ and Rx offloads argument From: Vivek Sharma Introduce boot time argument for configuring QinQ strip offload and for configuring all rx offloads.Fix port info display to distinguish between qinq strip and extend offloads. Signed-off-by: Vivek Sharma --- app/test-pmd/config.c | 9 +++++++-- app/test-pmd/parameters.c | 22 +++++++++++++++++++++- doc/guides/testpmd_app_ug/run_app.rst | 9 +++++++++ 3 files changed, 37 insertions(+), 3 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 1a5a5c1..42ae25e 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -530,9 +530,14 @@ port_infos_display(portid_t port_id) printf(" filter off \n"); if (vlan_offload & ETH_VLAN_EXTEND_OFFLOAD) - printf(" qinq(extend) on \n"); + printf(" extend on\n"); else - printf(" qinq(extend) off \n"); + printf(" extend off\n"); + + if (vlan_offload & ETH_QINQ_STRIP_OFFLOAD) + printf(" qinq strip on\n"); + else + printf(" qinq strip off\n"); } if (dev_info.hash_key_size > 0) diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 5244872..6f1870a 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -68,7 +68,8 @@ usage(char* progname) "--rss-ip | --rss-udp | " "--rxpt=3D | --rxht=3D | --rxwt=3D | --rxfreet=3D | " "--txpt=3D | --txht=3D | --txwt=3D | --txfreet=3D | " - "--txrst=3D | --tx-offloads=3D | --vxlan-gpe-port=3D ]\n", + "--txrst=3D | --tx-offloads=3D | | --rx-offloads=3D | " + "--vxlan-gpe-port=3D ]\n", progname); #ifdef RTE_LIBRTE_CMDLINE printf(" --interactive: run in interactive mode.\n"); @@ -135,6 +136,7 @@ usage(char* progname) printf(" --enable-hw-vlan-filter: enable hardware vlan filter.\n")= ; printf(" --enable-hw-vlan-strip: enable hardware vlan strip.\n"); printf(" --enable-hw-vlan-extend: enable hardware vlan extend.\n")= ; + printf(" --enable-hw-qinq-strip: enable hardware qinq strip.\n"); printf(" --enable-drop-en: enable per queue packet drop.\n"); printf(" --disable-rss: disable rss.\n"); printf(" --port-topology=3DN: set port topology (N: paired (defaul= t) or " @@ -186,6 +188,7 @@ usage(char* progname) printf(" --flow-isolate-all: " "requests flow API isolated mode on all ports at initializat= ion time.\n"); printf(" --tx-offloads=3D0xXXXXXXXX: hexadecimal bitmask of TX que= ue offloads\n"); + printf(" --rx-offloads=3D0xXXXXXXXX: hexadecimal bitmask of RX que= ue offloads\n"); printf(" --hot-plug: enable hot plug for device.\n"); printf(" --vxlan-gpe-port=3DN: UPD port of tunnel VXLAN-GPE\n"); printf(" --mlockall: lock all memory\n"); @@ -607,6 +610,7 @@ launch_args_parse(int argc, char** argv) { "enable-hw-vlan-filter", 0, 0, 0 }, { "enable-hw-vlan-strip", 0, 0, 0 }, { "enable-hw-vlan-extend", 0, 0, 0 }, + { "enable-hw-qinq-strip", 0, 0, 0 }, { "enable-drop-en", 0, 0, 0 }, { "disable-rss", 0, 0, 0 }, { "port-topology", 1, 0, 0 }, @@ -641,6 +645,7 @@ launch_args_parse(int argc, char** argv) { "print-event", 1, 0, 0 }, { "mask-event", 1, 0, 0 }, { "tx-offloads", 1, 0, 0 }, + { "rx-offloads", 1, 0, 0 }, { "hot-plug", 0, 0, 0 }, { "vxlan-gpe-port", 1, 0, 0 }, { "mlockall", 0, 0, 0 }, @@ -994,6 +999,10 @@ launch_args_parse(int argc, char** argv) "enable-hw-vlan-extend")) rx_offloads |=3D DEV_RX_OFFLOAD_VLAN_EXTEND= ; + if (!strcmp(lgopts[opt_idx].name, + "enable-hw-qinq-strip")) + rx_offloads |=3D DEV_RX_OFFLOAD_QINQ_STRIP; + if (!strcmp(lgopts[opt_idx].name, "enable-drop-en")= ) rx_drop_en =3D 1; @@ -1215,6 +1224,17 @@ launch_args_parse(int argc, char** argv) rte_exit(EXIT_FAILURE, "tx-offloads must be >=3D = 0\n"); } + + if (!strcmp(lgopts[opt_idx].name, "rx-offloads")) { + char *end =3D NULL; + n =3D strtoull(optarg, &end, 16); + if (n >=3D 0) + rx_offloads =3D (uint64_t)n; + else + rte_exit(EXIT_FAILURE, + "rx-offloads must be >=3D = 0\n"); + } + if (!strcmp(lgopts[opt_idx].name, "vxlan-gpe-port")= ) { n =3D atoi(optarg); if (n >=3D 0) diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app= _ug/run_app.rst index d0d89b3..ef677ba 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guides/testpmd_app_ug/run_app.rst @@ -198,6 +198,10 @@ The command line options are: Enable hardware VLAN extend. +* ``--enable-hw-qinq-strip`` + + Enable hardware QINQ strip. + * ``--enable-drop-en`` Enable per-queue packet drop for packets with no descriptors. @@ -385,6 +389,11 @@ The command line options are: Set the hexadecimal bitmask of TX queue offloads. The default value is 0. +* ``--rx-offloads=3D0xXXXXXXXX`` + + Set the hexadecimal bitmask of RX queue offloads. + The default value is 0. + * ``--hot-plug`` Enable device event monitor mechanism for hotplug. -- 2.7.4