DPDK patches and discussions
 help / color / mirror / Atom feed
From: Sunil Kumar Kori <skori@marvell.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] trace: fix size_t field emitter
Date: Sun, 30 Aug 2020 07:35:16 +0000	[thread overview]
Message-ID: <CY4PR18MB16222E9C4EFF347D99A9285CB4500@CY4PR18MB1622.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20200825232410.975-1-pbhagavatula@marvell.com>

>-----Original Message-----
>From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
>Sent: Wednesday, August 26, 2020 4:54 AM
>To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil Kumar Kori
><skori@marvell.com>
>Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
><pbhagavatula@marvell.com>
>Subject: [dpdk-dev] [PATCH 1/2] trace: fix size_t field emitter
>
>From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
>Add size_t CTF format metadata, this is needed by CTF analyzers to
>parse the emitted CTF trace.
>
>Fixes: 262c4ee791c6 ("trace: add size_t field emitter")
>
>Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>---
> lib/librte_eal/common/eal_common_trace_ctf.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/lib/librte_eal/common/eal_common_trace_ctf.c
>b/lib/librte_eal/common/eal_common_trace_ctf.c
>index 302e2bb74..9dc91df0f 100644
>--- a/lib/librte_eal/common/eal_common_trace_ctf.c
>+++ b/lib/librte_eal/common/eal_common_trace_ctf.c
>@@ -83,6 +83,11 @@ meta_data_type_emit(char **meta, int *offset)
> 		"typealias integer {size = 32; base = x;} := long;\n"
> #endif
> 		"typealias integer {size = 8; signed = false; encoding = ASCII; }
>:= string_bounded_t;\n\n"
>+#ifdef RTE_ARCH_64
>+		"typealias integer {size = 64; base = x;} := size_t;\n"
>+#else
>+		"typealias integer {size = 32; base = x;} := size_t;\n"
>+#endif
> 		"typealias floating_point {\n"
> 		"    exp_dig = 8;\n"
> 		"    mant_dig = 24;\n"
>--
>2.17.1

Acked-by: Sunil Kumar Kori <skori@mavell.com>


      parent reply	other threads:[~2020-08-30  7:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-25 23:24 pbhagavatula
2020-08-25 23:24 ` [dpdk-dev] [PATCH 2/2] trace: add size_t as a generic trace point pbhagavatula
2020-08-30  7:36   ` Sunil Kumar Kori
2020-10-07 12:41     ` Thomas Monjalon
2020-08-30  7:35 ` Sunil Kumar Kori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY4PR18MB16222E9C4EFF347D99A9285CB4500@CY4PR18MB1622.namprd18.prod.outlook.com \
    --to=skori@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).