From: Sunil Kumar Kori <skori@marvell.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v2 2/4] trace: remove size limit on CTF event description
Date: Thu, 29 Oct 2020 09:36:35 +0000 [thread overview]
Message-ID: <CY4PR18MB162238C7486FE89ED29160BBB4140@CY4PR18MB1622.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8wO2s7iqivv4xV3b9ohKnJpcKtuttCoYcEd_PoGiEUyxg@mail.gmail.com>
>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Thursday, October 29, 2020 2:22 PM
>To: Sunil Kumar Kori <skori@marvell.com>
>Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>
>Subject: Re: [EXT] [PATCH v2 2/4] trace: remove size limit on CTF event
>description
>
>On Thu, Oct 29, 2020 at 9:41 AM Sunil Kumar Kori <skori@marvell.com>
>wrote:
>> >@@ -505,15 +504,11 @@ __rte_trace_point_register(rte_trace_point_t
>> >*handle, const char *name,
>> > goto free;
>> > }
>> >
>> >- /* Copy the field data for future use */
>> >- if (rte_strscpy(tp->ctf_field, field, TRACE_CTF_FIELD_SIZE) < 0) {
>> >- trace_err("CTF field size is too long");
>> >- rte_errno = E2BIG;
>> >- goto free;
>> >- }
>> >-
>> >- /* Clear field memory for the next event */
>> >- memset(field, 0, TRACE_CTF_FIELD_SIZE);
>> >+ /* Copy the accumulated fields description and clear it for the next
>> >+ * trace point.
>> >+ */
>> >+ tp->ctf_field = RTE_PER_LCORE(ctf_field);
>> >+ RTE_PER_LCORE(ctf_field) = NULL;
>>
>> Although patch looks okay but I have one that how "tp->ctf_field" is
>> populated because during registration time RTE_PER_LCORE(ctf_field) will
>be NULL. So "tp->ctf_field" will always be NULL.
>
>Sorry, I don't understand your comment.
>RTE_PER_LCORE(ctf_field) is filled at __rte_trace_point_emit_field.
Yes but I am not able to understand that how tp->ctf_field will be populated with latest memory
because RTE_PER_LCORE(ctf_field) is being free and re-allocated at runtime.
>
>
>--
>David Marchand
next prev parent reply other threads:[~2020-10-29 9:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 8:00 [dpdk-dev] [PATCH 0/3] Rework CTF event description storage David Marchand
2020-10-23 8:00 ` [dpdk-dev] [PATCH 1/3] trace: fixup CTF event description at registration David Marchand
2020-10-23 8:00 ` [dpdk-dev] [PATCH 2/3] trace: remove size limit on CTF event description David Marchand
2020-10-28 9:06 ` Jerin Jacob
2020-10-23 8:00 ` [dpdk-dev] [PATCH 3/3] trace: make CTF metadata prettier David Marchand
2020-10-27 19:43 ` [dpdk-dev] [PATCH 0/3] Rework CTF event description storage David Marchand
2020-10-28 8:52 ` Jerin Jacob
2020-10-28 13:09 ` David Marchand
2020-10-28 15:17 ` David Marchand
2020-10-28 15:59 ` David Marchand
2020-10-28 21:02 ` [dpdk-dev] [PATCH v2 0/4] " David Marchand
2020-10-28 21:02 ` [dpdk-dev] [PATCH v2 1/4] trace: fixup CTF event description at registration David Marchand
2020-10-29 8:35 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-10-28 21:02 ` [dpdk-dev] [PATCH v2 2/4] trace: remove size limit on CTF event description David Marchand
2020-10-29 8:41 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-10-29 8:51 ` David Marchand
2020-10-29 9:36 ` Sunil Kumar Kori [this message]
2020-10-29 10:02 ` David Marchand
2020-10-29 10:31 ` Sunil Kumar Kori
2020-10-28 21:02 ` [dpdk-dev] [PATCH v2 3/4] trace: fix metadata dump David Marchand
2020-10-29 8:36 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-10-28 21:02 ` [dpdk-dev] [PATCH v2 4/4] trace: make CTF metadata prettier David Marchand
2020-10-29 8:37 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-10-29 21:50 ` [dpdk-dev] [PATCH v2 0/4] Rework CTF event description storage David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR18MB162238C7486FE89ED29160BBB4140@CY4PR18MB1622.namprd18.prod.outlook.com \
--to=skori@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).