From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BE4EA09EF; Mon, 21 Dec 2020 08:20:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B241ECBB7; Mon, 21 Dec 2020 08:20:03 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 47F46CBB4 for ; Mon, 21 Dec 2020 08:20:01 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BL7G3mn027450; Sun, 20 Dec 2020 23:19:46 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=q6gvNbw1ooJP4wMjKtJsTKRfgoBdZO1CYmfzQniszmc=; b=gSpey7uSZSGrBh1gePbagKNb79pe3IFRH/mQzq7J66yUEvKmc4Zqp1o5xR6kmeXXmbQc bKEJGmJLPW3mvjz5KoVcv6JXV93WfMOd7pOfnSBeIRRHi3dE/TVyjVrKc0qjhU+Ffgdj BaVKET9QGeuZv323AM354AWThY04byoDmK2hCkb8GZS7lQWDsJXDJ5wXAZiEtRbOfAhn 8f8h3c1/61G3bH3KfkUu+L8sbGTLJwfKCelKuwZ2BmL2BXZ7jxpGzf5E5w1a0ymToFMm 9/cTm9xs9JbU3JARcKpiwN93evW980Sva5RTgdnn71PfL31vOB2DoyahzIcHWiTYOAiL 0w== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 35j4wvhj9q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 20 Dec 2020 23:19:46 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 20 Dec 2020 23:19:44 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 20 Dec 2020 23:19:43 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 20 Dec 2020 23:19:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=egup3KfQxNWjOP7fv2glwhANc871AxUUrqCr0ckeMQuyV3rXf3BsYg8AgLnpu5ckZbizdit5iCk4wECIvAS88Cs+QK+uFgHmWUbG+7CjS1hypLoBN75bpO2BTEif/BALfQe/MUoEYt95H/TrKSsT1jdKMmKgdsGgXzJDoPPy50ICS+fxBqZ56LYiz7KigJpoqqAVKbKQDKZRWc42qr/aaLNyV/woWQ07ORSEbqWwvCe30nHJfILIHIzRuOeA+qKKpca89ufoaVMPEIFgZMkv6LCqlcWGG7Ultb1DXbaLkFz0+Cs6s1haYPp1k7Yn3e+cEeukbQ8SwZxpv52I8MNr6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q6gvNbw1ooJP4wMjKtJsTKRfgoBdZO1CYmfzQniszmc=; b=CBi8WnLLSS1Hhh7NkS0E5jf46gZU08Q4cr65t3eVDsW/Fi7axz3d/yQdiGWQd3gtZVZcmFH4diunFtG9nMY7j3ShbgMrt70DUQEyGdyrH0MzEO1EkPnuyLvTvioBipqhl2ks5Fh1exMcXWVqEULsfQ+EHZFpJ8OfRY34g3LvzUcNqZc/c3AR7LI0+msxM1rBZpBt1GLiIT5OYdcKmVUV+ofksQf4czDirmZec7bijkz5So3EPvpNHSaGB4KEDmL911GdKPjetzU90SfSxVijYWpJ0Yyo6EdyZPYZ9B0Hnu5kMT4QWkDnNGUbqpIweTNZOtL1eYwI6xgCKeIdJDucsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q6gvNbw1ooJP4wMjKtJsTKRfgoBdZO1CYmfzQniszmc=; b=haV0eM7rvokDeemJcs++QBEpzbAjyNwBAuFy3GxYJGMdLgwAcHJCmhTDI0YUgr7KBnnwCaaItJeyjPItEu99Ls3jgDfcqAymPhRNjK2fG6XP1y3aYQ58KcToX1qjKAkO52DD3YZP3Dx0xVflcnjCj26uRf9Yo+hkaHimdZXYnd4= Received: from CY4PR18MB1622.namprd18.prod.outlook.com (2603:10b6:903:150::14) by CY4PR18MB1285.namprd18.prod.outlook.com (2603:10b6:903:106::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Mon, 21 Dec 2020 07:19:41 +0000 Received: from CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::901e:982a:b39c:9b33]) by CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::901e:982a:b39c:9b33%6]) with mapi id 15.20.3676.033; Mon, 21 Dec 2020 07:19:41 +0000 From: Sunil Kumar Kori To: Steve Yang , "dev@dpdk.org" CC: "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "bernard.iremonger@intel.com" , "asomalap@amd.com" , "rahul.lakkireddy@chelsio.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "jia.guo@intel.com" , "haiyue.wang@intel.com" , "g.singh@nxp.com" , "xuanziyang2@huawei.com" , "cloud.wangxiaoyun@huawei.com" , "zhouguoyang@huawei.com" , "xavier.huwei@huawei.com" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "jingjing.wu@intel.com" , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , "rosen.xu@intel.com" , "Shijith Thotton" , Srisivasubramanian Srinivasan , "heinrich.kuhn@netronome.com" , Harman Kalra , "Jerin Jacob Kollanukkaran" , Nithin Kumar Dabilpuram , Kiran Kumar Kokkilagadda , Rasesh Mody , Shahed Shaikh , "andrew.rybchenko@oktetlabs.ru" , "Maciej Czekaj [C]" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , "ivan.boule@6wind.com" , "konstantin.ananyev@intel.com" , "samuel.gauthier@6wind.com" , "david.marchand@6wind.com" , "shahafs@mellanox.com" , "stephen@networkplumber.org" , "maxime.coquelin@redhat.com" , "olivier.matz@6wind.com" , "lihuisong@huawei.com" , "shreyansh.jain@nxp.com" , "wei.dai@intel.com" , "fengchunsong@huawei.com" , "chenhao164@huawei.com" , "tangchengchang@hisilicon.com" , "helin.zhang@intel.com" , "yanglong.wu@intel.com" , "xiaolong.ye@intel.com" , "ting.xu@intel.com" , "xiaoyun.li@intel.com" , "dan.wei@intel.com" , "andy.pei@intel.com" , Vamsi Krishna Attunuru , "sony.chacko@qlogic.com" , "bruce.richardson@intel.com" , "ivan.malov@oktetlabs.ru" , "rad@semihalf.com" , "slawomir.rosek@semihalf.com" , "kamil.rytarowski@caviumnetworks.com" , "wei.zhao1@intel.com" , "junyux.jiang@intel.com" , "kumaras@chelsio.com" , "girish.nandibasappa@amd.com" , "rolf.neugebauer@netronome.com" , "alejandro.lucero@netronome.com" Thread-Topic: [EXT] [PATCH v2 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu Thread-Index: AQHW1FhB7IDuIyFpk0+hy3xyhmj0DaoBKnQA Date: Mon, 21 Dec 2020 07:19:41 +0000 Message-ID: References: <20201209031628.29572-1-stevex.yang@intel.com> <20201217092312.27033-1-stevex.yang@intel.com> <20201217092312.27033-13-stevex.yang@intel.com> In-Reply-To: <20201217092312.27033-13-stevex.yang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.76.195.143] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a3222ddd-28b8-4567-fed5-08d8a580c8a2 x-ms-traffictypediagnostic: CY4PR18MB1285: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d1zN4dyvqujd1n+9XWsU/L/FjWgOhZAlNxE1oGHKJlyyyxVOEjfdNhpD2v4rJ0dqcTEi6lpJyH2yqgmO15fUGOuaMz/U1LbS5mszJH4q+lpcMywEI3mY9/oeJI25n8OREPJY2QxlQqe9so8LgLQaBTFg29LcGoR5JDN99ddv6j+WWlQnnP/ZHWb63o0p1IoY85bJSNA6XrUW5kzDSt1jtmnbNMXM3fq3BPhnTrtHfA7/12f2mTqqcnAg4UrYSNg4RCgBHOrqEsmukY0uEmrxo8CDQbnaXrd31v5z4ewiPGmdnV9icCBdM88pqEAJRa+P/i6d1MvWl7yOSvX8LfYPTPzOGiVkr/aQ6v0gulVmKhc52b5Gy2c+r6WCtB63BSM56jaNbI7cdr+d11Y9s2VkhA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR18MB1622.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(366004)(39850400004)(396003)(8676002)(71200400001)(186003)(26005)(9686003)(316002)(86362001)(6506007)(52536014)(54906003)(4326008)(110136005)(5660300002)(2906002)(55016002)(66556008)(66446008)(76116006)(7406005)(8936002)(478600001)(7696005)(66946007)(7416002)(7366002)(33656002)(83380400001)(64756008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?o7ocE+RhECVJ4yBIyeBGRs3FbISx7TtWRhEWf/+ixYdXGz0YE7xPiyZlTm3J?= =?us-ascii?Q?WKHDH7i+lTqK4qMxbmqxQJDVA7KnTQpMNABvR12uTYn1gnZSGSQ8jBJkhemy?= =?us-ascii?Q?hr/Allj7uGaU2IQzMSHSlnD9Osuzf5YFN/wXCOP5R0tKJVoe2b+ByDwRfBjU?= =?us-ascii?Q?UbAwpNwyu883/Rh3iGc8fgp7QFvogyHWwlH+c8iIrQrkApOzKCkLVJwfD+aT?= =?us-ascii?Q?49KRGuN0tu3wlMTsvpgpo04+lOmUaO7iZPZTaDTEYNGCPVBNQKBL/qUOTF53?= =?us-ascii?Q?dsPEgXNkcKjc5QNW/NwGronThtSeVUj4g5VuWZyeKj6yTWLthu17O6U16zGY?= =?us-ascii?Q?kwH8Tamf+XFqkjBfib9yKr0l77ZXTOZQlI098bkVWy5Sf2/akX5/x+SoP2JP?= =?us-ascii?Q?OrOE0pYQ9kpsAzueq+vV6CJ/LFKROpvrBveIpQcRZeZMqgj+JiQYVnMxdUoQ?= =?us-ascii?Q?fxW1pGmhuHBJuo0FxiX8yfeTdNOvWAPES1Boj5NOkJhC2RxX/gMdcy3ug6pD?= =?us-ascii?Q?onhUkmYX3K3lp55HxAUhjK9n0PPj5oUWy1IaN3XhxqOQlZJkZmXvy3514UZU?= =?us-ascii?Q?ECH2YaDDSnMX67V4U00JAHEtfBw9Fq48ko+dojvptQLW1T75ne/tZMkVnwXt?= =?us-ascii?Q?XbkXlMsf6V6CgycQMSfP86IUwB8fZKL0467ns05VXOI1A2dFoMVuHVOtJ3VT?= =?us-ascii?Q?Q1rNht2Pz9FpWX3/h0H464Da8LL+HzgPYyKnfOmoFQzbsqf4XqAh2RnqsLEd?= =?us-ascii?Q?YYAbY5wa7pkXdni3zNhdlk2w6p6ZtTo/fjweWchZ8AnYwD/O9kUPVG6G4STq?= =?us-ascii?Q?G1YoIV6iIUsiKBbJey89J8geIpVfjZXJH2tafpQhSKdvfbVoRJNROnprSlQ+?= =?us-ascii?Q?+ap1EpOCU6sxdlF7BYdSjD9sTTU4GNE5iN+b6i/a+dfGipsxm3GdgB1AhXsl?= =?us-ascii?Q?dB5xndMpjaoxMLUNjviZU2RFvf9IbNNrj8DyVyk0scE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR18MB1622.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3222ddd-28b8-4567-fed5-08d8a580c8a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2020 07:19:41.1148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vQTHAPhUpUcCYeju9RPodB/wmBspvS3gGeGc1PRpOADXYPdc6s7Z/nT+IgKtfn7LbzwrV2mOxaEsZ7ayuBJQaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1285 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-21_02:2020-12-19, 2020-12-21 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v2 12/22] net/octeontx2: fix the jumbo frame flag condition for mtu X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Steve Yang >Sent: Thursday, December 17, 2020 2:53 PM >To: dev@dpdk.org >Cc: wenzhuo.lu@intel.com; beilei.xing@intel.com; >bernard.iremonger@intel.com; asomalap@amd.com; >rahul.lakkireddy@chelsio.com; hemant.agrawal@nxp.com; >sachin.saxena@oss.nxp.com; jia.guo@intel.com; haiyue.wang@intel.com; >g.singh@nxp.com; xuanziyang2@huawei.com; >cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; >xavier.huwei@huawei.com; humin29@huawei.com; >yisen.zhuang@huawei.com; oulijun@huawei.com; jingjing.wu@intel.com; >qiming.yang@intel.com; qi.z.zhang@intel.com; rosen.xu@intel.com; Shijith >Thotton ; Srisivasubramanian Srinivasan >; heinrich.kuhn@netronome.com; Harman Kalra >; Jerin Jacob Kollanukkaran ; >Nithin Kumar Dabilpuram ; Kiran Kumar >Kokkilagadda ; Rasesh Mody >; Shahed Shaikh ; >andrew.rybchenko@oktetlabs.ru; Maciej Czekaj [C] ; >thomas@monjalon.net; ferruh.yigit@intel.com; ivan.boule@6wind.com; >konstantin.ananyev@intel.com; samuel.gauthier@6wind.com; >david.marchand@6wind.com; shahafs@mellanox.com; >stephen@networkplumber.org; maxime.coquelin@redhat.com; >olivier.matz@6wind.com; lihuisong@huawei.com; shreyansh.jain@nxp.com; >wei.dai@intel.com; fengchunsong@huawei.com; chenhao164@huawei.com; >tangchengchang@hisilicon.com; helin.zhang@intel.com; >yanglong.wu@intel.com; xiaolong.ye@intel.com; ting.xu@intel.com; >xiaoyun.li@intel.com; dan.wei@intel.com; andy.pei@intel.com; Vamsi >Krishna Attunuru ; Sunil Kumar Kori >; sony.chacko@qlogic.com; >bruce.richardson@intel.com; ivan.malov@oktetlabs.ru; rad@semihalf.com; >slawomir.rosek@semihalf.com; kamil.rytarowski@caviumnetworks.com; >wei.zhao1@intel.com; junyux.jiang@intel.com; kumaras@chelsio.com; >girish.nandibasappa@amd.com; rolf.neugebauer@netronome.com; >alejandro.lucero@netronome.com; Steve Yang >Subject: [EXT] [PATCH v2 12/22] net/octeontx2: fix the jumbo frame flag >condition for mtu > >External Email > >---------------------------------------------------------------------- >The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but >the Ether overhead is larger than 18 when it supports dual VLAN tags. >That will cause the jumbo flag rx offload is wrong when MTU size is >'RTE_ETHER_MTU'. > >This fix will change the boundary condition with 'RTE_ETHER_MTU' and >overhead. > >Fixes: 0e2efd02db58 ("net/octeontx2: add MTU set operation") > >Signed-off-by: Steve Yang >--- > drivers/net/octeontx2/otx2_ethdev.h | 2 ++ > drivers/net/octeontx2/otx2_ethdev_ops.c | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/octeontx2/otx2_ethdev.h >b/drivers/net/octeontx2/otx2_ethdev.h >index 3b9871f4dc..99f0469d89 100644 >--- a/drivers/net/octeontx2/otx2_ethdev.h >+++ b/drivers/net/octeontx2/otx2_ethdev.h >@@ -51,6 +51,8 @@ > /* ETH_HLEN+ETH_FCS+2*VLAN_HLEN */ > #define NIX_L2_OVERHEAD \ > (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + 8) >+#define NIX_L2_MAX_LEN \ >+ (RTE_ETHER_MTU + NIX_L2_OVERHEAD) > > /* HW config of frame size doesn't include FCS */ > #define NIX_MAX_HW_FRS 9212 >diff --git a/drivers/net/octeontx2/otx2_ethdev_ops.c >b/drivers/net/octeontx2/otx2_ethdev_ops.c >index b36d37b9f7..963cc285ed 100644 >--- a/drivers/net/octeontx2/otx2_ethdev_ops.c >+++ b/drivers/net/octeontx2/otx2_ethdev_ops.c >@@ -58,7 +58,7 @@ otx2_nix_mtu_set(struct rte_eth_dev *eth_dev, uint16_t >mtu) > if (rc) > return rc; > >- if (frame_size > RTE_ETHER_MAX_LEN) >+ if (frame_size > NIX_L2_MAX_LEN) > dev->rx_offloads |=3D DEV_RX_OFFLOAD_JUMBO_FRAME; > else > dev->rx_offloads &=3D ~DEV_RX_OFFLOAD_JUMBO_FRAME; >-- >2.17.1 Acked-by: Sunil Kumar Kori