From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 916D0A04B5; Thu, 29 Oct 2020 09:36:31 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73037C325; Thu, 29 Oct 2020 09:36:30 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id DE9CFC325 for ; Thu, 29 Oct 2020 09:36:28 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09T8aRnE031504; Thu, 29 Oct 2020 01:36:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=PTPNt+tDW38uJRSlv8iUNcD3pY/s+1WiPS2t9Hvm48Y=; b=aiGBzfFPuEo1Tf7/AdbLYsEXMFjvcoh0reJgRdayfxF3GJnlf3NlSwvCpBAHCFVGu2lC Pa32FayPn9XZMPR173qNh2Rb6n1e6DqYc5C2sOwB1LsjkrEQ3/+edv6BD1NWWdq2BJHi WDftlCwwn02BLN4q617fV4ScV6gEUAu79NW2eUo7Ym02IANevp9gAsoRtJ/DEFVUiXiV 8E0ss9Anz1HtOc4hA1172UY4cooJqd7Frrs/YGKxUbCxjQUMZjPlE1J8oVTHFXR8zT0r 44VKHq5vShDQU2WyYv6zz1cDvEOi/S5iDbHhQBhSKlXs9S99uhaabE5qnT1G0VKVLMrt Eg== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 34chmnbyrt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 29 Oct 2020 01:36:26 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Oct 2020 01:36:22 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Oct 2020 01:36:22 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.54) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 29 Oct 2020 01:36:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JJNgkEs8VruKvwoZq4hI8G4bzhgB0YwIfUeGc4Ac9pGwpgLjqN3W0R75JFTBZwhVVGbeRVbioaro30VRvqQEJWtduOBHkbGeQJTps1KMajGCrBs4g30eNocVmmEGdsetB5XwPs+hAJJiprtHMP2ADMFVuWbksdh2DXeqVm6Wf1Y7jligJ72RoBW8YbMb+M9nEHUiJwnt2/zLSbbjWZmKt8U99+yVDrJR9a87Tcyiw0Eb4mVrEcC4Q1JS8Rlw82seyi1EokEQ95AZhsVVrv0JRK/dMQnm9dNOyPHOZ4FEFnzrsy04LYnPGXrvFADZET0uCE3mqUswtjSqBxukWOHoqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PTPNt+tDW38uJRSlv8iUNcD3pY/s+1WiPS2t9Hvm48Y=; b=LDvLyDgCN0r0noWvPZYuVUQUbEI4YIM+HHP7WLgMtjBdOSq+G+00hmVPkzsqgBb9GKHCB0wqoDJuNE3X5KSPdpzaqadfHiJnKGAK4XPOpQMGEedi7GsmHtTyg5FYUKAigYR04BGmjvV/g32gIIN6XeQHd+8BJcJwnA1TVzA5N8viiDbMBnofH+0HqZVKGpR0na4COivS2tLDJ4e2zP7DcqrzTy3ujdPH7kHVcVEQYsl03HXTxhU5jcgsa3GTx+AXjEhx/D2zT1LdAGwF4MwkjQdgMpzm2l2H7qUGKbolTTcgukHdYedGn+dHiVBygo3xcsgkUIE0o9R5r3Wq622Bcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PTPNt+tDW38uJRSlv8iUNcD3pY/s+1WiPS2t9Hvm48Y=; b=V5WHYylO8QM/65mXhjLdxkyaJiZDblWPhTO1VfzSU3atq2z1xRRcANQAug3FWoIginhjvKcBmZv2eQUUoC82w2s/50o8HHsrojXsRMxmio4iAXemGALFk1JujmY+jKgcwW8XR6Q9Ty+mCaJJ1M9RUqwpsoVUiFZWUdV/EQKYBT4= Received: from CY4PR18MB1622.namprd18.prod.outlook.com (2603:10b6:903:150::14) by CY4PR18MB1030.namprd18.prod.outlook.com (2603:10b6:903:a6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Thu, 29 Oct 2020 08:36:20 +0000 Received: from CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::358d:ee84:5927:d04f]) by CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::358d:ee84:5927:d04f%5]) with mapi id 15.20.3499.027; Thu, 29 Oct 2020 08:36:20 +0000 From: Sunil Kumar Kori To: David Marchand , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran Thread-Topic: [EXT] [PATCH v2 3/4] trace: fix metadata dump Thread-Index: AQHWrW3DOGVOJuYR9kaxpOzgaeCyVqmuQh7A Date: Thu, 29 Oct 2020 08:36:20 +0000 Message-ID: References: <20201023080058.13335-1-david.marchand@redhat.com> <20201028210249.9021-1-david.marchand@redhat.com> <20201028210249.9021-4-david.marchand@redhat.com> In-Reply-To: <20201028210249.9021-4-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [27.63.42.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4562d465-bb8b-4b95-4b60-08d87be5b622 x-ms-traffictypediagnostic: CY4PR18MB1030: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lIT+qF5nzR7Qaf8hdmPWn8KXoCluuc69XFXMky48zGSFzOjKnUF7Nh5jesbFQRPRBbo6q8iaa8xR5x/FeiP/zfCZuCXyEKXurwTUoWCxq42VGsX8kWWR0TmF+AYa/1aPV/6/Mz6FSDAWw0n10dFFPWMz4FWfQAOtns4ABPQnRKrutd6zbyPyEV5o9XrfCl8UpOUIFe8UimL8EaYrEzUoDOaPbBK0+jMLaXBhHDXFAWxOvKUTyTByE1tWmlGCaEQrbk+9m89TiLglT5S51tKiAUd3zwoPCbkIL+otqlJq3mQqacqtl7Qf2IUiCsCtnQt+micNPv93N7PcL4zaLr/xVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR18MB1622.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(376002)(346002)(396003)(366004)(478600001)(8676002)(7696005)(8936002)(4326008)(83380400001)(316002)(110136005)(2906002)(107886003)(6506007)(33656002)(186003)(55016002)(9686003)(26005)(5660300002)(66556008)(76116006)(64756008)(66446008)(86362001)(66946007)(66476007)(71200400001)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: oqD11QGBHJg2TEYYDrYYkY5ehIVBULqGkskvyZd0KG/m3G/Ljdarydw+ogN7pw1/Qb1yOjJu7n46vzUW65J9kCQPyCc90DYsoCQFeOEAgC72QniFdkolLAqGr2vTkhQNl9NjO3FofiLsxefKVDUeWqXn6MY1PvlP6y9sYiskFUFKonT5iTryi3SBdM6p1BqBz5XOJiGVo2gxo+gB+FP3QNE53xNdYhKzukuASCo05ZgbGyADzlw5bmpWRz3fTgYM0sOIpRKllkHfV544mnXcBdNJejj0FblKvX2GgsHO8y9n0LO5wP+wL7O6uehp+PrmxvB/bt8GXoUQ/n7tz0QeLn4bnsp82o7eZB9Fiw333+dxTZsAzVdD1e4S2qTUMSClD38PlnkQAXitlG9DZFoFj2yh3cnoljZJBx6MECHjHzYj1BbFi9MMEsyk1a0ZFq0vpL3gsoJXzfSdw3BZkrvuuP7neo92d4JxlSXacYCL16b4K17RQ5a4k3hhutTNUwPsEzWGwuK9ImErFDm/uDLLDKRsFq4a6YRhL6BLaLL3WrjHZah2FEVLJzqEvbWM/awTr7701kuxfV6Un/5zJtBiAhJt+hFnWVKWgTm4Bn9SByFKx4rfdR0i3s7ULFZ4gXQYsl/lVeTx7oVAIeKGzdEVXw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR18MB1622.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4562d465-bb8b-4b95-4b60-08d87be5b622 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 08:36:20.4973 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4JTNTBv3W2CPT5srR226bX5VugtdCrRHoXGg127MAS0VSC+XYSeA9Lro9b0zkwm3syP9V+SkZc2mNFKlgWUTmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1030 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-10-29_03:2020-10-29, 2020-10-29 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v2 3/4] trace: fix metadata dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: David Marchand >Sent: Thursday, October 29, 2020 2:33 AM >To: dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > >Subject: [EXT] [PATCH v2 3/4] trace: fix metadata dump > >External Email > >---------------------------------------------------------------------- >The ctf metadata is written to the metadata file without any check for len= gth, >so this string must be null terminated. > >Fixes: f1a099f5b1f1 ("trace: create CTF TDSL metadata in memory") > >Signed-off-by: David Marchand >--- > lib/librte_eal/common/eal_common_trace_ctf.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/lib/librte_eal/common/eal_common_trace_ctf.c >b/lib/librte_eal/common/eal_common_trace_ctf.c >index ac1f64d04b..22615c4e73 100644 >--- a/lib/librte_eal/common/eal_common_trace_ctf.c >+++ b/lib/librte_eal/common/eal_common_trace_ctf.c >@@ -37,11 +37,12 @@ meta_copy(char **meta, int *offset, char *str, int rc) > if (rc < 0) > return rc; > >- ptr =3D realloc(ptr, count + rc); >+ ptr =3D realloc(ptr, count + rc + 1); > if (ptr =3D=3D NULL) > goto free_str; > > memcpy(RTE_PTR_ADD(ptr, count), str, rc); >+ ptr[count + rc] =3D '\0'; > count +=3D rc; > free(str); > >-- >2.23.0 Acked-by: Sunil Kumar Kori