From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73757A04B5; Thu, 29 Oct 2020 09:37:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D42DBE65; Thu, 29 Oct 2020 09:37:17 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5EF8ABE53 for ; Thu, 29 Oct 2020 09:37:16 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09T8Ztm8018351; Thu, 29 Oct 2020 01:37:14 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=b/2v5+NmXwHmNIcqC03Uvu88SmWRF2NlcbuD2dMNmaQ=; b=JJiCmFmTnkeGI1AGW43a5z2FQ2T4d5RcACrXkGLO9cJ+VLNfgxhqJB40qFPWQ1NO/Xml N6j7tQ6ubPh66vkGyDIABkIziBKs3zE1lf+CWEoWTShnezzU8ArZFuj6LiklczrN6iAC dBoCT9Z5LsOh+nD+zRsIIrLyzTZ9ClSKvyZns3ng9cvu6UnuckcozYyWsjwUjrAvMhUc qtq3kdH9HZC65W04aUqh0UYNZ8YS/N3zL1MXfQpR4pk9k9orOTLJhtFMLLUVE/pasKQN TB6gKupHVy2JkRehs37Xvs9Uu2HjIRMoUeZDl7xebLGBXbEZYobwlLUiN0wQWocJb3DC TQ== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 34cksmkb6u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Thu, 29 Oct 2020 01:37:14 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Oct 2020 01:37:12 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 29 Oct 2020 01:37:12 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.56) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Thu, 29 Oct 2020 01:37:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lYqlxDq02h6xbW9JIRFY+FOehUGAaVv3iBUJj5CqZSY+69nwh8R+iu4LliRf/1Z8X9lDxBuED86d0nZ1nFFCNft/glwS4HPe+dHjCwBI3oz1rh/kuhv1+N6gzXpkpHdHsOW+pA2yG8x9ahyFJz6hmcY2wyNgj6FMbMVA5HTDQ2Al7Rvg9lgwHIV4xZe91DrZ+GmJaqVDmszbOSP2RnJMRc32uucUHJwPRQj6y60BUzZsp9zQAxYBCP2uFVreYkDPfFZPzzF9BgYDDJoMSlOOcd6pAsELeWNxP10+NGPdEEFrABNby5jRGaXqUjZGM/aVY6wnuWRXCMdfbG3Jp7MULA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b/2v5+NmXwHmNIcqC03Uvu88SmWRF2NlcbuD2dMNmaQ=; b=ex/2sGKJoVmLPiPXFLRrA9ifPL7HTpgLFC3w8+k99h1tyArJI8eHXTBce+xQW3Em2tlofosmKZ6JUuTbiDzxKRVVUFadhXE/GmvyHfMnW3Dfv0kaZhY02jRwXlYmazQ7PIt6nYyO53IJudmSANxU+VcHfB4MbtnaXY+ssxAPDk/kWD0HwbXW0VKoKXzOH0WtNUeUdqZIDNZtAitO+guKOhXcAuG7X0YY6Ep0rXSJm8WXT0ObnI4SbwjnCAcOBdNtGbSK0pyRrM0OPJFghpd86Nia39cInLpGGy0xuwzxyH+Vcbg9/9uGATryzsBtboa4naN6lzNCG5LDZmeZna64lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b/2v5+NmXwHmNIcqC03Uvu88SmWRF2NlcbuD2dMNmaQ=; b=fyV+PCJzyhkLwI0x6AwIIgUMoPRRr+cYO68/m5Ppk7B+2oAnq97fNgB1uuUe0U9fogP+GZimbb698nJZOXI89QvyKWeaj2GGfPINiUHGzzb0/dQ9Vvx2mjdNh0PVSBwo9WA690kwh7qAi2nQ11cGC81357pGNRrYb2W2dIIQcx4= Received: from CY4PR18MB1622.namprd18.prod.outlook.com (2603:10b6:903:150::14) by CY4PR18MB1030.namprd18.prod.outlook.com (2603:10b6:903:a6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Thu, 29 Oct 2020 08:37:11 +0000 Received: from CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::358d:ee84:5927:d04f]) by CY4PR18MB1622.namprd18.prod.outlook.com ([fe80::358d:ee84:5927:d04f%5]) with mapi id 15.20.3499.027; Thu, 29 Oct 2020 08:37:11 +0000 From: Sunil Kumar Kori To: David Marchand , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran Thread-Topic: [EXT] [PATCH v2 4/4] trace: make CTF metadata prettier Thread-Index: AQHWrW3BnhuVrSVE1E6CO5z9tPVfBKmuQmcg Date: Thu, 29 Oct 2020 08:37:11 +0000 Message-ID: References: <20201023080058.13335-1-david.marchand@redhat.com> <20201028210249.9021-1-david.marchand@redhat.com> <20201028210249.9021-5-david.marchand@redhat.com> In-Reply-To: <20201028210249.9021-5-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [27.63.42.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: db296424-9c8b-4fc0-eea8-08d87be5d483 x-ms-traffictypediagnostic: CY4PR18MB1030: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:93; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dyj7BWVjo54I9dCEez90o1WChs93vXej5i/4jtH20Hiq1u8sWyoqLb96Hk997DYfPI3yVLUUVXC39eTI6OavG/zNgZBIbaVt49qUCHfXdGC3x0h4tENmi0Xs17GmqPz29oxS0bo3C7qfE+dpu9N3nP1E0w6chNLPh4P0APawnlRGCVqkgsqML3+HN6lGWrhnl1VBfOn8ffF6rqBZCWb9M04iOs7bLj7mBB/u5Hk/BgNw84D1UxX4XOw3EwB3cfW5ljtAmtFJEbZWb0uax4SfJ1o5DofJB55PHDtciVl2tnI3oqK4Ssr0iS8URLkeZfjEs4UtiIgD43ees9eeV/5pBw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR18MB1622.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(376002)(346002)(396003)(366004)(478600001)(8676002)(7696005)(8936002)(4326008)(83380400001)(316002)(110136005)(2906002)(107886003)(6506007)(33656002)(186003)(55016002)(9686003)(26005)(5660300002)(66556008)(76116006)(64756008)(66446008)(86362001)(66946007)(66476007)(71200400001)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: RUwSQSyB/K3zHdbcb8y+XN72G7QNUv18C8Jxd8Q8h3d90ys6NknAZyK3HcUJVWvjGblsN6SbwFNOEVHPI+29Yu6jq5EXxyV6vn0N2Bqxnle70rVZjIkF4XscC7IRiQmg97SGVSMqR/RQn+zpgLDNUfJgSajx4l/u5FuAjtT/OzpBAW0LftfmZKea58TKDy4/8OfDzj4jMIqaHox7l36UZiAnygRdbk6mh08YiXcpmsn5YSE1IobyHHfdHk/Vt0cAC2uaDxiS33B66zl5VzPdhNN4CORkawrgPYoQEwSTB2M1s8TNlxGS2asjVuJgyONIGhiEQ+JUZhZvywY+cjYw5Sh4qC1wwYEOCQKnJybd8maY50aa8io/3PJYEq8V7LqgBXjjl2uivgqLf7uOUvKsm7/j7fxO89rwCfyBtFUArY/nbL+0yILC29mV2gqby1JHtSxhGa7FwuDTciBuTDfycxHuLospxODUDJHsY/AYaoJhUAV+QLgc27WNomcKI/1/qmms2TAxpKnl3yhxI1vCGCEF2Sr9HpPCOlt294GpNs4t9QLCe4hliwXdwrkXoOO2Si456JxHimyXlVzZC8vX6k6u68CAwpqwydH7CKoWrGTxOI4+Nzpx9vOXfNnMtuUQjv4nvAsXKacokCGP1RKafw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR18MB1622.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: db296424-9c8b-4fc0-eea8-08d87be5d483 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 08:37:11.4779 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QdzpF1plR0xCThunm8O+BMO13tVudniKbp9fuo6wAZI89eT7eaA36CGd7JYEoSLEOH0GU+ziw0vYLErrj/zrJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR18MB1030 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-10-29_03:2020-10-29, 2020-10-29 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v2 4/4] trace: make CTF metadata prettier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: David Marchand >Sent: Thursday, October 29, 2020 2:33 AM >To: dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > >Subject: [EXT] [PATCH v2 4/4] trace: make CTF metadata prettier > >External Email > >---------------------------------------------------------------------- >This is simply a cosmetic change. > >Before: >event { > id =3D 17; > name =3D "lib.eal.alarm.set"; > fields :=3D struct { > uint64_t us;uintptr_t cb_fn;uintptr_t cb_arg;int32_t rc; > }; >}; > >After: >event { > id =3D 17; > name =3D "lib.eal.alarm.set"; > fields :=3D struct { > uint64_t us; > uintptr_t cb_fn; > uintptr_t cb_arg; > int32_t rc; > }; >}; > >Signed-off-by: David Marchand >--- > lib/librte_eal/common/eal_common_trace.c | 2 +- > lib/librte_eal/common/eal_common_trace_ctf.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/lib/librte_eal/common/eal_common_trace.c >b/lib/librte_eal/common/eal_common_trace.c >index bc031ca719..24e27387b1 100644 >--- a/lib/librte_eal/common/eal_common_trace.c >+++ b/lib/librte_eal/common/eal_common_trace.c >@@ -435,7 +435,7 @@ __rte_trace_point_emit_field(size_t sz, const char *in= , >const char *datatype) > fixup =3D trace_metadata_fixup_field(in); > if (fixup !=3D NULL) > in =3D fixup; >- rc =3D asprintf(&field, "%s%s %s;", >+ rc =3D asprintf(&field, "%s %s %s;\n", > RTE_PER_LCORE(ctf_field) !=3D NULL ? > RTE_PER_LCORE(ctf_field) : "", > datatype, in); >diff --git a/lib/librte_eal/common/eal_common_trace_ctf.c >b/lib/librte_eal/common/eal_common_trace_ctf.c >index 22615c4e73..33e419aac7 100644 >--- a/lib/librte_eal/common/eal_common_trace_ctf.c >+++ b/lib/librte_eal/common/eal_common_trace_ctf.c >@@ -232,7 +232,7 @@ meta_event_emit(char **meta, int *offset, struct >trace_point *tp) > " id =3D %d;\n" > " name =3D \"%s\";\n" > " fields :=3D struct {\n" >- " %s\n" >+ "%s" > " };\n" > "};\n\n", trace_id_get(tp->handle), tp->name, > tp->ctf_field !=3D NULL ? tp->ctf_field : ""); >-- >2.23.0 Acked-by: Sunil Kumar Kori