From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9B46A04EF; Mon, 1 Jun 2020 23:46:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA9891BFF0; Mon, 1 Jun 2020 23:46:22 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2098.outbound.protection.outlook.com [40.107.244.98]) by dpdk.org (Postfix) with ESMTP id A15871BFA9 for ; Mon, 1 Jun 2020 23:46:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j4iBSm+a3hPRlB8ya536zpIR+oQroDddIkj2CApRnDHuUNY5RYqpAL2a3PZo+RgIJpUtei/9rRltzubaNL8IEU5uzoW5l3sinlW66IwrcbctywGGxfLeSOYiBwJW+uPbEFtpUJxIjH2AiB3dc8DriNzy1332ItSUtl9EG5Myj49CX4++Ze527Dv75AUL9Lvhup4gRvXYdboGd/a0HZSKVcbEOWE9yklDTsAO9ic9k3FnH/3oAgOlGG7lkbmYi2Fc0HSp6EJuQsMjhi/SUO2VyObqRgkqrAeaQrUIuDoeIZoYiWCnkbnKTVyoL/6/k+6C8XrxTvkh7n029YTWh8bblw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3PhsiKFAhuwLg8PImP0WbMfxZJ1oGI6k4hJRiRM2kkg=; b=SrW6JoUjvFqkfhZLoPXDHutUPZYdMcsNnNwa0RS2goNyhTuxlJZszcG1YY+dbJVG3Fbh9setp7WTp1sc+r6vOc9AgYz/9d47BQg5nfpjQt1rUJIVQoITrnTtz6+GZVNbySXevJjywO1lRDOhxQBcvGXqqNZm9O31NWJEEICjkEjK3iqAZjiYDwK6mOafhn0esxnpZSXridzOzL9AHZiQd6zGplMIsHl9FbMeeFdigAuG5udGWpXOJIgogJ6BT95zXtSZ1elzvCnbc08rTYvMmaWDl7CFiCBXZkOmWXWX5Pv1ec669b3vI5fLsJoVo69KrYo7Z8B+QxDRW4XMd6K4Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3PhsiKFAhuwLg8PImP0WbMfxZJ1oGI6k4hJRiRM2kkg=; b=SNci3RWjC5tHsdZi18IOrENcLGDpVPjQhsMahC4VA83W1M5Saj8YrxLn8AUh6WG54IWtNQ52NTk3fB8IcWNycjzKml9As9wMbwg/ay9zVv1DI2egQdsYZyBmM8tzuM8CFKY4VFGTvlUmROR9wKMEKZhxH6UifO2sKwTU2FZed4s= Received: from CY4PR21MB0277.namprd21.prod.outlook.com (2603:10b6:903:bb::15) by CY4PR21MB0791.namprd21.prod.outlook.com (2603:10b6:903:13b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.3; Mon, 1 Jun 2020 21:46:18 +0000 Received: from CY4PR21MB0277.namprd21.prod.outlook.com ([fe80::837:8efe:4987:e1a0]) by CY4PR21MB0277.namprd21.prod.outlook.com ([fe80::837:8efe:4987:e1a0%13]) with mapi id 15.20.3066.017; Mon, 1 Jun 2020 21:46:18 +0000 From: Omar Cardona To: Neil Horman , Fady Bader CC: "dev@dpdk.org" , "thomas@monjalon.net" , "tbashar@mellanox.com" , "talshn@mellanox.com" , "yohadt@mellanox.com" , "dmitry.kozliuk@gmail.com" , Harini Ramakrishnan , "pallavi.kadam@intel.com" , "ranjit.menon@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" , "mdr@ashroe.eu" Thread-Topic: [EXTERNAL] Re: [PATCH v2 1/4] eal: disable function versioning on Windows Thread-Index: AQHWOE63Hodsxw9BlkCWl26ovGleGKjEQqAA Date: Mon, 1 Jun 2020 21:46:18 +0000 Message-ID: References: <20200601103139.8612-1-fady@mellanox.com> <20200601103139.8612-2-fady@mellanox.com> <20200601195557.GB210755@hmswarspite.think-freely.org> In-Reply-To: <20200601195557.GB210755@hmswarspite.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-06-01T21:46:16Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=190bd1ba-8e64-4f9d-bb9e-cf75b70a8cb4; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0 authentication-results: tuxdriver.com; dkim=none (message not signed) header.d=none;tuxdriver.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [2001:4898:80e8:8:842a:ac89:b523:ecde] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e0536ee2-6edd-498c-1d74-08d80675377a x-ms-traffictypediagnostic: CY4PR21MB0791: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0421BF7135 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3msNZcrt2PTtbjkVMIP1uHYRoO5LlqBSTlkOFNgkHtZZujwEh2Dshw8e+frUoHyJnemObirVyqrK4uZj4Ba9ZLs9f5/sorTNf9qocTokTcrL3UaRI6IoII4xVMmw0dwGsrZyLDlbQfqT3GsTyaP+YPNxL/tG2+JfydzdH6SDS3rA/z7xuYqWaIixm+4aG7RraV7BhKxnnNxB9QqmWyI3ed1tGEVvX7W/RWieFIsWYrnWHqyiYAI9LjCsLydQC0A5KAnIXxWsqgHGXv+JUe0m3G5aCbi0L+QX+KXoxCcbkzsx1C01VqvIGH3dW2vHV7lBAZUqfS9OpY3KtWvd2aRgrA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR21MB0277.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(376002)(136003)(346002)(366004)(396003)(33656002)(71200400001)(64756008)(66556008)(66946007)(76116006)(186003)(316002)(66446008)(66476007)(2906002)(5660300002)(83380400001)(82960400001)(52536014)(82950400001)(8990500004)(7696005)(8936002)(6506007)(55016002)(9686003)(4326008)(110136005)(7416002)(54906003)(478600001)(86362001)(10290500003)(53546011)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: eS90a2DpQ5Pw/9YTYZXO0G81n11iM0G/BVmZVk6lBnNyt8mR42T0dSBSHEdBQQTccYBTOCYDWdYKIgEkGNkPO1SxAeVhsL1BxS9tlCD/CpTb140TPPdLMQU6IqriMaQamZWk6d8pqszN/ZJ8DeCaGdCTQs0tFkylDw1rUwEHorA6rW0JRevMExdqB7o9v9kqKFZXD5nomN6Gn4aokuUCfVIyLJnb51KqHyFinh71uf1A9BNkc9qK5rSQguqzp6GumIapfEE201TxJXhzE4I1stZg3blwX4cwlXRFXw41WYAKJ743TOs8bofDC42VzbIi8lQJDUb+teF+hunbAhtVB4P8QlYVdoukc4563sXf/ORQ9ZAiw4uFWZ35PmzsqZKmO/JKiDk7u33nqabSby2XW75oaxYHSYJycpOYbgi3UGBRhUqX9OJq68pQf/aZlmTByWstvFy3TYNFSthSqu1yE/lUctWAdSP0QNFtv1u9WwX809JNmQ0QcaqZZOVQD3ywgMeV3x8RZMWt4ID/ZC3cXSREBUXKsLOVUjK18gQHwgk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0536ee2-6edd-498c-1d74-08d80675377a X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jun 2020 21:46:18.3675 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lbvyZEF32gCjMW3fM5aEpGrUWPLJ8+m59tdmFROfTJ2HK5sCty7d/MIGWpN+7YV48EkihzdMhjJwY+OPszNOhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR21MB0791 Subject: Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v2 1/4] eal: disable function versioning on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >> Do we know if we have future plans of supporting dlls on windows in the = future? - Hi Neil, yes this is of interest to us (Windows). =20 - Specifically to aid in non-disruptive granular servicing/updating. - Our primary scenario Userspace VMSwitch is biased towards shared librari= es for production servicing -----Original Message----- From: Neil Horman =20 Sent: Monday, June 1, 2020 12:56 PM To: Fady Bader Cc: dev@dpdk.org; thomas@monjalon.net; tbashar@mellanox.com; talshn@mellano= x.com; yohadt@mellanox.com; dmitry.kozliuk@gmail.com; Harini Ramakrishnan <= Harini.Ramakrishnan@microsoft.com>; Omar Cardona ; = pallavi.kadam@intel.com; ranjit.menon@intel.com; olivier.matz@6wind.com; ar= ybchenko@solarflare.com; mdr@ashroe.eu Subject: [EXTERNAL] Re: [PATCH v2 1/4] eal: disable function versioning on = Windows On Mon, Jun 01, 2020 at 01:31:36PM +0300, Fady Bader wrote: > Function versioning is not needed on Windows, also the function=20 > versioning implementation is not supported by Windows. > Function versioning was disabled on Windows. >=20 I get that windows doesn't seem to support symbol level versioning, but I'm= not sure its reasonable to say that its not needed, unless we never have a= ny intention of building dpdk on windows using a DSO model. The below defi= nately solves the immediate problem, but if we plan to support windows with= dynamic library builds, this just kicks the can down the road. Do we know if we have future plans of supporting dlls on windows in the fut= ure? Neil > Signed-off-by: Fady Bader > --- > lib/librte_eal/include/rte_function_versioning.h | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/lib/librte_eal/include/rte_function_versioning.h=20 > b/lib/librte_eal/include/rte_function_versioning.h > index f588f2643..cee06602e 100644 > --- a/lib/librte_eal/include/rte_function_versioning.h > +++ b/lib/librte_eal/include/rte_function_versioning.h > @@ -11,6 +11,10 @@ > #error Use of function versioning disabled, is "use_function_versioning= =3Dtrue" in meson.build? > #endif > =20 > +#ifdef RTE_EXEC_ENV_WINDOWS > +#undef RTE_BUILD_SHARED_LIB > +#endif > + > #ifdef RTE_BUILD_SHARED_LIB > =20 > /* > -- > 2.16.1.windows.4 >=20 >=20