DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Carrillo, Erik G" <erik.g.carrillo@intel.com>
To: Shijith Thotton <sthotton@marvell.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] eventdev/timer: fix timeout event wait behavior
Date: Wed, 12 Apr 2023 20:00:47 +0000	[thread overview]
Message-ID: <CY5PR11MB6416A51446BC91A1C423EB8AB99B9@CY5PR11MB6416.namprd11.prod.outlook.com> (raw)
In-Reply-To: <90fb5b328eda4c7f83cfb11998ba32a01935ff8e.1679375813.git.sthotton@marvell.com>

> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Tuesday, March 21, 2023 12:20 AM
> To: Carrillo, Erik G <erik.g.carrillo@intel.com>; jerinj@marvell.com
> Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org;
> pbhagavatula@marvell.com; stable@dpdk.org
> Subject: [PATCH v2] eventdev/timer: fix timeout event wait behavior
> 
> Improved the accuracy and consistency of timeout event wait behavior by
> refactoring it. Previously, the delay function used for waiting could be
> inaccurate, leading to inconsistent results. This commit updates the wait
> behavior to use a timeout-based approach, enabling the wait for the exact
> number of timer ticks before proceeding.
> 
> The new function timeout_event_dequeue mimics the behavior of the
> tested systems closely. It dequeues timer expiry events until either the
> expected number of events have been dequeued or the specified time has
> elapsed. The WAIT_TICKS macro defines the waiting behavior based on the
> type of timer being used (software or hardware).
> 
> Fixes: d1f3385d0076 ("test: add event timer adapter auto-test")
> 
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
Thanks for the update.

Acked-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>

  parent reply	other threads:[~2023-04-12 20:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15  8:00 [PATCH v1] eventdev/timer: use loop to check for timeout events Shijith Thotton
2023-03-20 16:54 ` Jerin Jacob
2023-03-21  5:20 ` [PATCH v2] eventdev/timer: fix timeout event wait behavior Shijith Thotton
2023-04-04 10:52   ` Jerin Jacob
2023-04-12 20:00   ` Carrillo, Erik G [this message]
2023-04-21  5:50     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CY5PR11MB6416A51446BC91A1C423EB8AB99B9@CY5PR11MB6416.namprd11.prod.outlook.com \
    --to=erik.g.carrillo@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    --cc=sthotton@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).