From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCBB243B45; Mon, 19 Feb 2024 02:37:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D32B402E0; Mon, 19 Feb 2024 02:37:42 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mails.dpdk.org (Postfix) with ESMTP id 9CFB34029B for ; Mon, 19 Feb 2024 02:37:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708306659; x=1739842659; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vhBM5BT2j2kV/1/K9Ez9zD4w8a0ChX0OftXNw9tmSQA=; b=Loh6fUe5J5a7ecojKIUHiVpFvjfyGnci+i1kgVA2Ht9EiRyDdyFd0PPf Rjto5ebYkUcT22HpJkh+XsDdjS7PHI3u+dOOfoqaBWim5wTMGUQXnrcEM BOm5ugP48qbkCNZ5q8FMJQlEFDqTwpFYRaEzPcZ2La2KZauYPl/PmEWFw Le2Jm36xGiLxfmHYSfBOgTF67v1IgIhL5FNbizIl7Sl3kAVjenOLowlT2 E3lW4JWqf41HN2CXWCNZZMVEv0ZfyQNMVAH/e0ILiKPj7Qjes5R89YhgR w/GFG7A+kT47Hg6k2Nd4mA2RpTYZLJc9iQFEP3LZFlhfH9SAdTZimlfGb Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10988"; a="13081539" X-IronPort-AV: E=Sophos;i="6.06,169,1705392000"; d="scan'208";a="13081539" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2024 17:37:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,169,1705392000"; d="scan'208";a="4317126" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 18 Feb 2024 17:37:38 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 18 Feb 2024 17:37:38 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 18 Feb 2024 17:37:38 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 18 Feb 2024 17:37:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y19yO+R7zE25G589m60VtgUN229J8aTGNbfjEVv82j0DmJzUAXfbqsxYSBdd7VbG9suVZNdiFUfXRkST+BMwp3QIQz8iKc8TOC8aUiKuiSn5iiEVXDB5N0uJ5yypqquaBt3fYZEkjPC/sLDrTJIEZ1E58Yfo0R72rN1wYXOQvpd+3Ib1F9D6UlPKLV4fZJvTJ4QAjcqguqvSIEQUn7+VfkotkH5bmiCD20veeNCHuB4lu11/IZInc/rW7atfgpkloeQspok14lg+vC4v+0tCiLa9h0qL4lbmZiHXCE+Ba5F7eNho1NPBJM/A6iIyOQeRIOl4Co2MeaXF74rqgOod9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=idKuvNGhQZYocQKKHAtOAyYn0MlGwlhKScEW3HbslWA=; b=aTJj/MAQzuZvgUEfrCxSByZUwYKxIy+lAjrkAB6qAsaRV8raWMW+4D8u+SmO4LQohROUrn7RV6L45F1tSqsaKPvIN50ZfIHilhC7F8ZhZQaYQ2FvtSNsgOIsq+SzFVFjoyD4K2Fmc0Xr83Yv/Y4VE3iswGQvPTBAf/wy4lCfDTa+NsQrHY5+TQ09bMcHzFRgHeJzODX8oVFdASSQ9laDB8Sj/kbm1ROfYNAjamsZBe5983+XCtBpidsJc5SYiU9rHfAof7pXNM453zaGTnkIlOckSvW7x2je0duVtKS9wDqwoDfFxwqZed0fhvtSN/ajWEzYU/Y2aUCUvQZGa/QyYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY8PR11MB7747.namprd11.prod.outlook.com (2603:10b6:930:91::17) by IA1PR11MB7854.namprd11.prod.outlook.com (2603:10b6:208:3f6::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.27; Mon, 19 Feb 2024 01:37:34 +0000 Received: from CY8PR11MB7747.namprd11.prod.outlook.com ([fe80::94ed:18e6:3d19:3a58]) by CY8PR11MB7747.namprd11.prod.outlook.com ([fe80::94ed:18e6:3d19:3a58%4]) with mapi id 15.20.7292.029; Mon, 19 Feb 2024 01:37:34 +0000 From: "Xu, Rosen" To: "Marchand, David" , "dev@dpdk.org" CC: Ajit Khaparde , Somnath Kotur , Devendra Singh Rawat , Alok Prasad Subject: RE: [PATCH v2 2/3] drivers: use common min/max macros Thread-Topic: [PATCH v2 2/3] drivers: use common min/max macros Thread-Index: AQHaYMJyGRA+w6xFwUOHEODlbCjeLbEQ5ttw Date: Mon, 19 Feb 2024 01:37:34 +0000 Message-ID: References: <1700089378-26197-1-git-send-email-roretzla@linux.microsoft.com> <20240216102454.4156609-1-david.marchand@redhat.com> <20240216102454.4156609-3-david.marchand@redhat.com> In-Reply-To: <20240216102454.4156609-3-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR11MB7747:EE_|IA1PR11MB7854:EE_ x-ms-office365-filtering-correlation-id: 901d76c0-ba08-4773-07c4-08dc30eb58d2 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ladjhbbwKJjQOUIAifHIFaSXHZ46JeBuhQ69PRPMhboZFPmVjCb07GWLnrIoVl/ncIBOG7wHGeIW4T+AfmBQ4iIJs58oaJgM2zxYpQm6jkZcveCOaClWeZHNq6ociaI0iAqvrfCjVXntMZuuuNuRHKZyLcvgPrlURccF26lY3SxCcPb7lGr0e23N8M9x0rD92Da3liDseujCkRbEY4oedxP1PgwU9XOXYTzLXKXiq/pEXRHJyGexPbVW2hLVwygzhpfiot9lVbsCjMxh5Mh0rVxD1PWQSsPWSg4qW2gvTcaSbWozah5hxJKR95bEyYtRIUmpgmeW28y3c4xdKg5R0lNe3RSkZ31nrO59b5tnOkWf4f3JH05ydX46cmMHpnvQ23xgS/nHVWzpd58STXKqc6Zn6lekQ4WuYG8vdaogj1pyrPQg4K52M1nQHN2np5Qdn/s6NJMj9o+v8eR5h1kEQh8fzs4FYpDV1I/wS/tqiYDLWRBNeWej6Z/S8pBrbamO6/fpiextVpK0ElnpmFT4P8kRSVUHbVBdfRRMj09Fh9oy44cUuIh8T7vk9PULhaGB/68kPTSqn5trn6/dh7bRmi6P1vakTA6gTm6XO+uFMiDRYI2pjFGcbgb/Uw1KRSh/ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7747.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(366004)(396003)(376002)(39860400002)(230922051799003)(186009)(1800799012)(451199024)(64100799003)(64756008)(66556008)(66946007)(71200400001)(8676002)(4326008)(76116006)(52536014)(66446008)(2906002)(83380400001)(122000001)(86362001)(38100700002)(33656002)(82960400001)(38070700009)(110136005)(6506007)(26005)(54906003)(316002)(53546011)(478600001)(9686003)(7696005)(66476007)(8936002)(5660300002)(41300700001)(55016003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xJua6+gUfrIhyAy0ltrJUa264wsmc8cojgr/rpUvEKGKvQ0/EYVCkvgDN6e+?= =?us-ascii?Q?8/7GFSfpAL7EjN3zDtRWDs6CXWHIlPKQ9HU3ianeFdVKu9ARTHNqmsapjWII?= =?us-ascii?Q?plFTI5QNsfpNDps664G8ODJH/M6vffzSRcd64WtzhJn6zlElwhn8SKERYczm?= =?us-ascii?Q?1hfcCk4TqTncG1ABfQYP+EafVZH0ny9KEazfiz5Cr73fQVIpZz/059zAeiqr?= =?us-ascii?Q?zGO7jQCYMPttZlYBRTM80R9sap8tSVkNmmjNfwER3KKP5kCdZTVP+pxrI6IV?= =?us-ascii?Q?AVas0Q8mJf6w3PQ30XATMTUKaF2fB5N9Hj9BxYIOLetaKeGqvLV/BFrn++HO?= =?us-ascii?Q?6BGdt0jgtFhyR/vCzAGi9ig5TnDjpo7fd3BKQ2qJFezPKtjA/TZ5VC7gW8KZ?= =?us-ascii?Q?fwAjysWdhj3a/e7MSyCU6EuJjtPvNtbxRh+CHUQjhSsicGzd0v/wj7Fd+WTD?= =?us-ascii?Q?pUkUPi77y4UzX2KphNojJmX8PIKPr110M/wgyh3qLEytpZEgXp2tVAeEwviF?= =?us-ascii?Q?tpKZ4OQQ6GyWmkE50sXAiMFe79Zsgo8OJKcKlWV3Wr/gQMs5EdbaXaWJE/Tt?= =?us-ascii?Q?FffO7Fz7J3+yL6DcGtqfiuw4EtL/YqJaSpnvXAqT4qaZIjv5ot5THaS3ur9q?= =?us-ascii?Q?gsTYl0T2acI/YnUUnQ7phVw5Rsrto2KVxeUlwAdWEycxixogkQaidUDT9prO?= =?us-ascii?Q?AaAAJHF/saqxaQ/34Z7NM+CDajnIV6fzBOMVKifCmEAk1hTxQHHzoZ+r+9DJ?= =?us-ascii?Q?VXcNgeYbArktYl1JN3wEE1EGsH4gIeGnQJ71nJysnBkLm2J3u2mrCroAQFOf?= =?us-ascii?Q?QKBJhTikpZg+Jppklzy0iCeDKjHrRvZ4pkjFstLlWWmPdFcSb30uhHO7qmdR?= =?us-ascii?Q?5QC7NKNky3KQ6V81v4MNIE3vHEQCgXwLJEFxgUrGz7qDcaopz1xYq57m8bPp?= =?us-ascii?Q?2RoPN7tcpb5+BXybvswoWXu+o1Mz+0mRWehzusSoEg1yYkmSq+K5BiL4AV1k?= =?us-ascii?Q?hZfjIPhw2lii8wVfpb5mth7Icuqosx4ilddkjPD/rA5qasW+Yo6ZX6AZHtVc?= =?us-ascii?Q?BHIKe9AUMW2rRoolnXxdzBkZKTowq9MSF0cySmt5F6G3Ahi0RSGeFOD3S/Ob?= =?us-ascii?Q?eDyYEDM91XW4DZ+i8Q5rvBft0YVbhs530Hg4qXPoEWYh0zw0XSXS5AFZXnhH?= =?us-ascii?Q?mQz8qYiCd9xS+LCWBFu35j9QCGLgDcppc68yMQlV3uyCEVOllHO+7P/+K6a2?= =?us-ascii?Q?fw9AeRV3JqOkig9DX7i598pEFqS/5WyeK4kH45/ZCk7ZtndDPjdaYXLlWEQ7?= =?us-ascii?Q?VuuHvX/q9mztJ3d8Cb9n+rQErbM6op5ZEnKn1JiNkNJnidgFK0pNJKXuMyUP?= =?us-ascii?Q?cMixpe0Eo6bdKVdJB7Y/siAoML/wc9yrl6Na/VRcdPdoC3PKREYARGYdhyzq?= =?us-ascii?Q?EnJJJfI51psPa0S2w1Zq5MivVnTOSX22DSSXjFfg4k6klFoJIWw2ZSdDdU+K?= =?us-ascii?Q?pSFW8aNwKruNXK1RxoysfXZZwxb/WrGxVfDyiDelHFgdU6JoEoujdS42e03q?= =?us-ascii?Q?WSTqnhe0VnwNXm2+sftNHcqFiQK5jKza36sF073P?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 901d76c0-ba08-4773-07c4-08dc30eb58d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2024 01:37:34.5154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lxCc+D+Y+SAiEzTXVKYPuAPC4y6vSucxsHFPdnUyF2H9cu+28/mqcwl0NCzAIP8NTCy4lCVb+/ZYbYFo007DTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7854 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: David Marchand > Sent: Friday, February 16, 2024 6:25 PM > To: dev@dpdk.org > Cc: Ajit Khaparde ; Somnath Kotur > ; Devendra Singh Rawat > ; Alok Prasad ; Xu, Rosen > > Subject: [PATCH v2 2/3] drivers: use common min/max macros >=20 > Use newly introduced macro. >=20 > Signed-off-by: David Marchand > --- > drivers/net/bnxt/bnxt_ethdev.c | 12 +----------- > drivers/net/qede/base/bcm_osal.h | 6 ++---- > drivers/raw/ifpga/base/osdep_rte/osdep_generic.h | 11 ++--------- > 3 files changed, 5 insertions(+), 24 deletions(-) >=20 > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c index 45d840d7af..8cc012206a 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -4867,17 +4867,7 @@ static void bnxt_free_ctx_mem(struct bnxt *bp) >=20 > #define bnxt_roundup(x, y) ((((x) + ((y) - 1)) / (y)) * (y)) >=20 > -#define min_t(type, x, y) ({ \ > - type __min1 =3D (x); \ > - type __min2 =3D (y); \ > - __min1 < __min2 ? __min1 : __min2; }) > - > -#define max_t(type, x, y) ({ \ > - type __max1 =3D (x); \ > - type __max2 =3D (y); \ > - __max1 > __max2 ? __max1 : __max2; }) > - > -#define clamp_t(type, _x, min, max) min_t(type, max_t(type, _x, min)= , > max) > +#define clamp_t(type, _x, min, max) RTE_MIN_T(RTE_MAX_T(_x, min, > type), > +max, type) >=20 > int bnxt_alloc_ctx_mem(struct bnxt *bp) { diff --git > a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm_osal.h > index 11019b5623..7869103c63 100644 > --- a/drivers/net/qede/base/bcm_osal.h > +++ b/drivers/net/qede/base/bcm_osal.h > @@ -443,10 +443,8 @@ u32 qede_osal_log2(u32); #define OSAL_IOMEM > volatile > #define OSAL_UNUSED __rte_unused > #define OSAL_UNLIKELY(x) __builtin_expect(!!(x), 0) > -#define OSAL_MIN_T(type, __min1, __min2) \ > - ((type)(__min1) < (type)(__min2) ? (type)(__min1) : (type)(__min2)) > -#define OSAL_MAX_T(type, __max1, __max2) \ > - ((type)(__max1) > (type)(__max2) ? (type)(__max1) : > (type)(__max2)) > +#define OSAL_MIN_T(type, __min1, __min2) RTE_MIN_T(__min1, __min2, > +type) #define OSAL_MAX_T(type, __max1, __max2) RTE_MAX_T(__max1, > +__max2, type) >=20 > void qede_get_mcp_proto_stats(struct ecore_dev *, enum > ecore_mcp_protocol_type, > union ecore_mcp_protocol_stats *); diff --git > a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > index 62c5666ca9..427793a578 100644 > --- a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > +++ b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > @@ -44,15 +44,8 @@ extern int ifpga_rawdev_logtype; #define min(a, b) > RTE_MIN(a, b) #define max(a, b) RTE_MAX(a, b) >=20 > -#define min_t(type, x, y) ({ \ > - type __min1 =3D (x); \ > - type __min2 =3D (y); \ > - __min1 < __min2 ? __min1 : __min2; }) > - > -#define max_t(type, x, y) ({ \ > - type __max1 =3D (x); \ > - type __max2 =3D (y); \ > - __max1 > __max2 ? __max1 : __max2; }) > +#define min_t(type, x, y) RTE_MIN_T(x, y, type) #define max_t(type, x, > +y) RTE_MAX_T(x, y, type) >=20 > #define spinlock_t rte_spinlock_t > #define spinlock_init(x) rte_spinlock_init(x) > -- > 2.43.0 Reviewed-by: Rosen Xu