From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 182A74552E; Mon, 1 Jul 2024 12:06:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8EB94279F; Mon, 1 Jul 2024 12:06:05 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mails.dpdk.org (Postfix) with ESMTP id ABC2542790 for ; Mon, 1 Jul 2024 12:06:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719828364; x=1751364364; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Ils8o5q4H7X1y4NRf9/RQwcVMVAMutg4MNd8gyTbyF0=; b=YQcoUg3UU+F4dbyfIMOWRg45gt4cBCd7rXg2C1yVe3ywlIyiuR9upFaP a8f1DAYxA57uTTzoJkKVriubvK3yMs+sLtvuD0VOBkNg4pBSUW8Yy/182 EEsgovfTtXb1kk7GrENCaEUzl5rFjT+sjZ0gWuxf4tISZjncjs7DT0StE GLsqkxnbYp+WVIVGzW179l+cs8CXuvgps86m+y9no/DoxWa+/axN7vuQK /65H35aXcVdDTU9W1jWSetB0ayBlE+edu5rmOwRDvqgUl7bLlb5waFtXw C6ZqfSxLqt+muQ5VjUIfNsX78kRXRvzsYPRuxh9DJzgZgZzUPMJUBBoyj Q==; X-CSE-ConnectionGUID: Dc6U8zplSF241biu9I8lmQ== X-CSE-MsgGUID: 9AZSMOmBQKiyoCIcxYWECw== X-IronPort-AV: E=McAfee;i="6700,10204,11119"; a="42364785" X-IronPort-AV: E=Sophos;i="6.09,175,1716274800"; d="scan'208";a="42364785" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2024 03:06:02 -0700 X-CSE-ConnectionGUID: NFyonxRgS1S6eGAjeGpUhA== X-CSE-MsgGUID: 1lNa8YdgQLutLakCF5B4EA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,175,1716274800"; d="scan'208";a="83011749" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Jul 2024 03:06:03 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 1 Jul 2024 03:06:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 1 Jul 2024 03:06:01 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 1 Jul 2024 03:06:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LZlg0TmdeiM6AqJ2FF8VLPRJ92CRDGYplOYH/huNYXhX4dAnZw46tgroGsq/gyRC8qEHsReHce+9Fbom4uWtm2v6K/2OxzSr5wDx2hJIrlMukdeUDFofIl+YJjfqvlkw88Yu9tsNoZTXAHhEgGR5oB0LwpzBv+3xJ7alPCiVgORMKTE4Oa889RJjvUfzJrqguWsgaI62EMCAMbgjnY7YUenn6iJRQxSQ1qfXBHjbFOkg/rdJzZkECxxEwunmd7dYw71pZgl5gkeK6+PAcrJI9ZoaYoa4NkrrxubKgIkQFjUpl56G1Im488jNN5f3cbQxnoW2kNYfMXDSm4sGg7ZBcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=veCPD+9MZDEVPgaof+WpOVRBdv9xI/0bPYh7OgbA0is=; b=VKMhJ7EYv2lncrN/mVCtoQPfyUjxJQoBOVmQJdj0t59kGC8NfN2PdOtDyuLGdFX39mDY8tv6F1DcbM03VyN8iTdLuIwQ4gl8JFZGRJTCX6na9TS7St9NpinPp4nedLr40WdqKaKdRp+WxBjF0obBnnm5goZQ1n8EKZKFfl9TXJCCOWZ6wJHBzVeMj3TpFDjLioA7zmbSJDPuCQ5OVCU7Eo9g0Cm47RBt6wX3AO9mr7Qc2JQdr1dWGVDixMGtIVvN61kIGBikI48Q+IrJUbXmoLt8TKmkGWNRKak0/kDSpLQYHrrn/KW+ohXwuvUP1rw1w5bxXW3DTMDu+WUzCQ4uUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY8PR11MB7747.namprd11.prod.outlook.com (2603:10b6:930:91::17) by CH3PR11MB7841.namprd11.prod.outlook.com (2603:10b6:610:121::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.39; Mon, 1 Jul 2024 10:05:58 +0000 Received: from CY8PR11MB7747.namprd11.prod.outlook.com ([fe80::dd94:c5ad:7fd:fd4f]) by CY8PR11MB7747.namprd11.prod.outlook.com ([fe80::dd94:c5ad:7fd:fd4f%4]) with mapi id 15.20.7719.029; Mon, 1 Jul 2024 10:05:58 +0000 From: "Hore, Soumyadeep" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "Burakov, Anatoly" Subject: RE: [PATCH v5 15/21] common/idpf: add wmb before tail Thread-Topic: [PATCH v5 15/21] common/idpf: add wmb before tail Thread-Index: AQHaxh3t2fRgJULeCUOzymwOB0nXhLHdR3+AgARnpJA= Date: Mon, 1 Jul 2024 10:05:57 +0000 Message-ID: References: <20240618105722.2326987-22-soumyadeep.hore@intel.com> <20240624091644.2404658-1-soumyadeep.hore@intel.com> <20240624091644.2404658-16-soumyadeep.hore@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR11MB7747:EE_|CH3PR11MB7841:EE_ x-ms-office365-filtering-correlation-id: 756bad2a-e2b2-49e6-26ef-08dc99b56741 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?PtwoaAhVc54rELUnnWfiWZI2D10knBnkIZHEXlLNGAPrOvzNRlj2Iuem5Bbm?= =?us-ascii?Q?2I90wOpqpRIVyiJjMbWP40qOwwCVV67DoMZDXaInLHI8SYvjonXcV14hPu4U?= =?us-ascii?Q?RkX/AKncTaFl9B680kp5rzb7hkTzV/QqjBds0eM0xs5LuZh28pMwdBznTAcP?= =?us-ascii?Q?MaHBBDv3aIVWc/SGKpo1IbJspBVd+b1K6vXcj8p0PV+JZe4aq50R7HRzZt+m?= =?us-ascii?Q?sjdI+byp/WqZDFwqQko4/5ZS4q/g/+2JQptNOEDTxTCkqMtYibiML9MYSBE0?= =?us-ascii?Q?8K099zT2JhjpyH6zkrP0j7ZACFQLkPygE6nyjmCOLPMTTFBbbTFMhLxu42jZ?= =?us-ascii?Q?AxCX391BOr/WBgRoRPTaJiwB7k7NCBsGdiCR3fy4AqUhZgisZtmVcJBkRyKI?= =?us-ascii?Q?GNjcYggCEnlzXUqLMkoAmc96itLS4TNuHK2+aiQxmLsXmoAdRVp5gp394mQu?= =?us-ascii?Q?ksEKReS7GCkOIwqZwZ8IY+mYXnvZKa+jAjk0ei4/nNAJidxjpYKNZRLtdjaQ?= =?us-ascii?Q?/upl7bWUmNoQInsbcnwee0S/MNvz6sGB0IhoB4VC7xQg72EoHmek67LME+sU?= =?us-ascii?Q?m2yIumvvLepI3WemUcfNDXhsEwORLA+5fICAgupuCY7G2a3c8wsvguf1g4Zc?= =?us-ascii?Q?43gwXxbNFJyPLWdVvUmP6nCoVuo1t1sTtGRlqkplN8G3bU5iU0HmwoRws4cm?= =?us-ascii?Q?q2DTboPNPUfYoy/twi0p7t5MYbEyLGn3XEA9VXwJb2V5LqpBosMXRntANYLs?= =?us-ascii?Q?XtDGHACQkjMsSRysqqUZlPFFGLe8claYbI0cmlEaLa8bAM0s1a2QaZrbFpCA?= =?us-ascii?Q?T9lVDsmoiLkj+kU1naE7qWXkayjm1egloOtd9CnBohh4ezJP4jdz//Zmx2l/?= =?us-ascii?Q?r4fDbNHsE5b789T38iCiglnEWRnibn1SIYMvvyiqkj+H2ZGlQGnD8XL1mmqp?= =?us-ascii?Q?Ryebu+7y+TkPkPW/8H0/Anioc0ftjwlvcal6Vgq0RPxfmq+DncomC9zNd0xD?= =?us-ascii?Q?Y7pnwAL2wOLx+SswBCOpuWncnZGRUbGeCVB5SuBllMt0cgA8NyV2WiIkmR+Y?= =?us-ascii?Q?lUQag2LF4V1WTw/z93Cvt33IRmrx7ee1hDUElLHkJt8Eq+BAV3nZrrGCWSgQ?= =?us-ascii?Q?iW6BJWOGK2gpCQQ34AUOBO7ghWdx/ADcFTYX44mNJuyyesEJwfSHOMyopcmF?= =?us-ascii?Q?1e+DaQDirIvyXgVognliCSr8U0/hy+goUNVP6Q4audt/e9PiIPK1jPjGK6N4?= =?us-ascii?Q?Y05gig05uQ7GLRBdXULawq2UF2FiD1CD3lh20nqDVH6y9rNbAVhY5f2fE/dq?= =?us-ascii?Q?b93myH2XCFYgiUPTpKMoQIiCDDYd9K+4xo2enDu2mgwuJ4HnHl43rSZc5BY0?= =?us-ascii?Q?gdveL3xfyjmq76cssAmQYGkSUicy8XePXFxIttOEGnNH3EyYyg=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7747.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gk/q11HWSLbV+AWObKZzdUllcdWx7EmGitvfNx09GG7YqvaAj2BIk7SAtKXW?= =?us-ascii?Q?QI3IlC3jDDtIFd+AAGUZfU0pMtunqxVd8ij0NrPFSS4OCXPxcubnFBjJSVLd?= =?us-ascii?Q?ySjgqMwfmp06CP06phtvN78RbTxg5IxeuZ5lH8pIeJaLOJ38RTHYY7X5aGY0?= =?us-ascii?Q?mTAG2rKPNrtF+Uuep6Qh+jFIMQgytee95imHKJdILqxIFuUgOuk9rtuSqi2g?= =?us-ascii?Q?mz7ck3i1B0m/JWzU4TFvjc0wh0JD3DQVGA/Xa0bGXfYDfeBKMnkKg7P8iYhc?= =?us-ascii?Q?mXg6c/guhnt5EROIYHTHYkWoFpEWn2qPLSN8xarRGekCw8To9eOBlv6RVHsy?= =?us-ascii?Q?HtTGPI4ayJ1c7XwcmWh/8JBF6x7JPs04EMjV6TdAhIRN95A0zmAg5PmhTDdc?= =?us-ascii?Q?JQYObyDXigh2lNBoKj/L/0Psdsfhzd0OxaopWPbqct2GzUzPLArPGTWn4n0X?= =?us-ascii?Q?sdw+h0lqkdLquT6RoMDy7qklnpuQ5pkCf4IWGebItxSm3ZphYJ8Oo/dMdYda?= =?us-ascii?Q?ztuPrqgf8jRKe/TLkl7Sys+ih8c4OMe8DITzAXxkGxwy0fFpcLQotVBFwzmO?= =?us-ascii?Q?mKDkk4plOZebGJyHzvEbxOTMvEIrJtRFzcgenpSWKUBQZ/cNu4OiLiIS+y96?= =?us-ascii?Q?8jOXJi7SjkzC/xR2lDN1uJQAaWaBAbvfaFvDyrwvdy2c14ikHrK+1p7K5YTt?= =?us-ascii?Q?uQFj0kD9Oodueown4MHDgvqzS+ZR6P+ChoaWAptUssTiStcRQnaBWZPa+ZYk?= =?us-ascii?Q?oIeQYD8UfYzGH+ilib+4nk25PDhq5wCMXGtbTwj4rXPTdLjQ0M32XVtGJJpZ?= =?us-ascii?Q?QbhTL3FnFEFvsHcng0gfPNPXxy+WuJl6CTnaDNEa3siV25LnhZXsnusE6l7l?= =?us-ascii?Q?BtYEKf2BsilWmmw7IBtN6sLiYHvW6exSzYtNcS5Uj0PkkRD0TAaMWci/0avZ?= =?us-ascii?Q?7zNekYjTDt+KVOXVWkz/B0w4lGjUkWqF9UybJBeT1BVbW/ZE55So4A/NpY2v?= =?us-ascii?Q?P3U+fSORCcdlSNjBQq4WWzMmQ0IQTX2an2vEbKXxmMcUzJ4nAEYFChCmOWl4?= =?us-ascii?Q?Iv5GSYxi04MDIl6Eg21hGi2783pDB9kHTuTfM/wjywuuhkjRu4iXIVaIpP0p?= =?us-ascii?Q?rqMf13pFIGiIsqPwbW47gpERplEVdFeG6xUtMKlO3begIJAgr3e2lFnmIyRV?= =?us-ascii?Q?dpfKo1czLZGu2UTJ+wRRZG6mggCKS+ZwPQtushvs0FYUDJPS76Cu3M/NOfOT?= =?us-ascii?Q?DqGLb1dRkT2Ej9HGGdGM6zb+HxGCRmsWUsrDrBm9tV3lnvl0x3qBxByVMCu+?= =?us-ascii?Q?YfrayZn3E5Bf16q41BLL6kBs35aiqbHMSnP6P0quLxiEWx8bvbl+ec01psdj?= =?us-ascii?Q?pArFzrd2+cziCnbllkCG1Vm/pg+w5g1lENvbJPnqQpUEhmXEcGvIl3g8j26a?= =?us-ascii?Q?ykRbo2klj4/7Zt7jCFUlvlHYCri6HRIm3XsL2I6O0HUo5kHXTxi+aM+y6ndE?= =?us-ascii?Q?JCMtjBbt1+j7QsVUohYpvyRLdOJ344GXt4EsAlQB6DwaNno6DdOD0dFrdorJ?= =?us-ascii?Q?XC5gFgKTquPGIt2YcG2gxXVjpICNRSCFPqlfFiqG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 756bad2a-e2b2-49e6-26ef-08dc99b56741 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2024 10:05:57.9961 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /PngKKWlOQcHKoyz5AgVPvKTltKMMzUbYWIrgE2zQFyQUqrL4lygIeY1+ElJcF1ZQJ3MXxUJ3hEv//H5gK20w4Skvd1HZrvVA1OPOtVk5K8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7841 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Introduced through customer's feedback in their attempt to address=20 > some bugs this introduces a memory barrier before posting ctlq tail.=20 > This makes sure memory writes have a chance to take place before HW=20 > starts messing with the descriptors. >=20 > Signed-off-by: Soumyadeep Hore > --- >From the description, it seems that this may be a bugfix patch. Can you con= firm this and whether it should be backported or not. Also, provide a fixes= tag for this. Thanks, /Bruce This is a new feature supported in MEV TS 1.4 which is only compatible with= dpdk 24.07.=20 So previous dpdk versions are not affected, hence backporting is not requir= ed. Regards, Soumya > drivers/common/idpf/base/idpf_controlq.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/common/idpf/base/idpf_controlq.c=20 > b/drivers/common/idpf/base/idpf_controlq.c > index 65e5599614..4f47759a4f 100644 > --- a/drivers/common/idpf/base/idpf_controlq.c > +++ b/drivers/common/idpf/base/idpf_controlq.c > @@ -604,6 +604,8 @@ int idpf_ctlq_post_rx_buffs(struct idpf_hw *hw, struc= t idpf_ctlq_info *cq, > /* Wrap to end of end ring since current ntp is 0 */ > cq->next_to_post =3D cq->ring_size - 1; > =20 > + idpf_wmb(); > + > wr32(hw, cq->reg.tail, cq->next_to_post); > } > =20 > -- > 2.43.0 >=20