From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ED844552E; Mon, 1 Jul 2024 12:09:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C30E427A0; Mon, 1 Jul 2024 12:09:37 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mails.dpdk.org (Postfix) with ESMTP id 6256842686 for ; Mon, 1 Jul 2024 12:09:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719828575; x=1751364575; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KEsK0VrGBJC4n27ZZlM/OwCl4WBN42bt4ndm74zHtbM=; b=TsrNoDU/Eq52rXlXL8IXC6G3qVmC4R/syn/gfaqgNbxdHFBBaJ7Xrfli hJBJIs+jp031oLJ9OrpClpWjkhJBGEAaP46fIXzo7tPBb3P4kB1Q87FG8 t3oLtD/0J/89yJzhIhWKP2kZtOXpHCtLIoVrulrmkr67Iw5bgVhhw6Fcc rjVWXwvXRb152zrye+Ayz/XHC+FbqaN2COFhIbY5n54gP9TPHSvhztdjj 23v0Un1pnSc1BUYWRklsqPnlQQ595RYr4RdfzEaAipXJBjWRwC5rL6v1O cNOr5bkyAFpaTkqWmq9tyabgvR2bg3/sphbumAoH0kT6nfofms3s7o8Oe g==; X-CSE-ConnectionGUID: rVRLv7ksR8iDs8irnAUJdw== X-CSE-MsgGUID: Rhqul7dFTYaD6vff9CcJiw== X-IronPort-AV: E=McAfee;i="6700,10204,11119"; a="16610498" X-IronPort-AV: E=Sophos;i="6.09,175,1716274800"; d="scan'208";a="16610498" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2024 03:09:34 -0700 X-CSE-ConnectionGUID: kNziMQ3mTG2AyhtsnE+9iA== X-CSE-MsgGUID: lmDFZgD6T4CcvnUwR6HN1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,175,1716274800"; d="scan'208";a="46224732" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa008.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Jul 2024 03:09:35 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 1 Jul 2024 03:09:33 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 1 Jul 2024 03:09:33 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 1 Jul 2024 03:09:33 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 1 Jul 2024 03:09:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kWiCZwBDfbdpANZUD0mBXQjS2k2ceVlpncR7yjvnf8Mgs7tRSQlhNWi/uf9yi23GwZk9FYuYWKTqTvdNRFFn6iD9rnCEBSrt5G1XbYx/wMuasJTCoagsHyjzaaQH9+Ctq3vg4ZghW0pRRip3eIXTCklmabE5gghsJhKpH/T5k6ih0RPWbpxrsSOW568XJFj/Q6aDo8js43YGAMxp0WsHyH4i2s7+lJofCMH/GyaLEjZh7ij2mPYM2pOVA7TxcOpqeVHJsxn1nT0VwERO9xN/4Ed2klGQTn6TxbfPYf5DsAW6u0IKqjBNtfzcLrPVL5d3AkoX61sTrxNqonChxiYzWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LU3D5itmf3fBf/35jfYknlKYh6M1xIQc3ofqGeAOPtI=; b=ld1ai+Kss8QW0MpEIq+yNAqum/B5jwnXp5iYcjmKKkEPqCX7U+8n3d5YyOCn+ZUZNnwTxouz1BkDngF0nx7IhsF5GqgP+n4uMZ6sq21rhK6SMQ/lAEY7qNworv5OSSG3A5E1a4V+2CXNBNQN6SdHR4ZcmoVWmxJhdfF71twhIARoDzybopFCv+ke0Mzud6HBSBUe3tMu1UKDB11ShjcDzQhHAPK+lDFwCWsFnyn/ZdR3lkVFbZsk45hhiwX8tU+M1mQ4DmjRC3hgzsxdIrRwFBO/YABhMNzWvHkLsy+lpwgobpLe3/KU+ShFiI4E3mj3x9jE9Lw+zhgAfr+4ybpS9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY8PR11MB7747.namprd11.prod.outlook.com (2603:10b6:930:91::17) by IA1PR11MB6393.namprd11.prod.outlook.com (2603:10b6:208:3ae::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.29; Mon, 1 Jul 2024 10:09:30 +0000 Received: from CY8PR11MB7747.namprd11.prod.outlook.com ([fe80::dd94:c5ad:7fd:fd4f]) by CY8PR11MB7747.namprd11.prod.outlook.com ([fe80::dd94:c5ad:7fd:fd4f%4]) with mapi id 15.20.7719.029; Mon, 1 Jul 2024 10:09:30 +0000 From: "Hore, Soumyadeep" To: "Richardson, Bruce" CC: "Burakov, Anatoly" , "dev@dpdk.org" Subject: RE: [PATCH v5 16/21] drivers: add flex array support and fix issues Thread-Topic: [PATCH v5 16/21] drivers: add flex array support and fix issues Thread-Index: AQHaxh30Np/RRFvbdUmH3MkhnATN9bHdSMuAgARoK9A= Date: Mon, 1 Jul 2024 10:09:30 +0000 Message-ID: References: <20240618105722.2326987-22-soumyadeep.hore@intel.com> <20240624091644.2404658-1-soumyadeep.hore@intel.com> <20240624091644.2404658-17-soumyadeep.hore@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR11MB7747:EE_|IA1PR11MB6393:EE_ x-ms-office365-filtering-correlation-id: 5645e112-6f09-4d5b-8692-08dc99b5e5c8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?Sji05ZxBGrhZu/LyckzBSuBIvpzfis9w2IhbzlqDwGnD3zYU/jr8X4F3UBco?= =?us-ascii?Q?+bkgodaIwPTPTsDTIfZSjNuDt8K9V+2ymc3FQxQhi54kXkSVNMC5RQVLOj+C?= =?us-ascii?Q?BG2zN0wz1UWTzcIo1tWiFsYZOPh6aQmL9plGYRkdtgr0fa1gwhw7LwGHbHx4?= =?us-ascii?Q?nmzWAsRX2rCEqOPq6KgPk/m8h30s2Vyy4hN2PirXtSfXFfCl6tSHXwWEjwzh?= =?us-ascii?Q?GgnA3BLeve4G+CvLtoGIkgSXPzUiYO8sZ0ENvfMKwIAKigxLVqBLYXaKw5QE?= =?us-ascii?Q?cUdkJoQ0BfMjqwgSH3mgsu9vVRgTu6Gr0ylrekiFvifITQJAmlfzqH/HWYnZ?= =?us-ascii?Q?P+XbKxc1YuJfgeSJikqqYUwXs3HIJgHigmg3fisOSEhcy7lMyFo4MGf1I4FN?= =?us-ascii?Q?uPf5tBwBGN56uwQJDtm+FdniE/Z415c8kHPmT9KVjcTDFNE1rKmXtjKnTJGC?= =?us-ascii?Q?CQ0d93NE+BgxQR4YgIQSzVsJ/03fsj8rHlepTPR68NBEf62ZO4fgstqWkunj?= =?us-ascii?Q?LYJMf4+QqjqkmYcHvju6UpU8HfP0UWelIfzD7WFOodQUM50yn+ud7ecHJaUy?= =?us-ascii?Q?vv1I9FfVhyd+aH/hHSRTJfET7ciwROe5Xy4tkc0r92P3xAVb74PRAGsDLfnN?= =?us-ascii?Q?Q8LMwD6inPkngmXN4Tk7BFXUsPSU9jfBkZ3l9B/AzpZA6/xPB+zXiwgACxmj?= =?us-ascii?Q?T6/jNa67O+no9H19rIDsWVhQkaAefmfPITNkAQ5lA49HxO2P4FWwjor0f7sN?= =?us-ascii?Q?mMAYaXDIwgTapTG5rv8Lv9tKsaTPSAJ+M8UffuK0F3aPy1emdE4i6mflCg5f?= =?us-ascii?Q?fuWBrbZSAziRiZ9/CYtmoAjdaDnqMUsuvg9HQyBDBQpxetvKy7TukKfWA641?= =?us-ascii?Q?kZoQtAD3Nl9KKfDpOfR9Ix3sadcfI8bJDJ1np3EbtT9KPK/xqeafaFfRIYoP?= =?us-ascii?Q?RPqKrCfYljJPyhDTG02OcaSRiiSAa5rbAzPjGC7dKvTz/FAK9l6/inQif2Bj?= =?us-ascii?Q?Ovs4WfhEe7EV9vklCNuihOQFShdjN1EieD8pWN/YSPv2lD2+BGWct+gp7/OT?= =?us-ascii?Q?/1gmaheLRjLntxwjjp+XVUvmf6KwEQtEUjrJv5iO2r8YSDPpalnMsKTWKywj?= =?us-ascii?Q?tPsNz20RhvpCVLPONMa2DyhI9ruo6RW1k7peAACab2ZF3hz4K6s1N1P2hXqQ?= =?us-ascii?Q?Nu+1wgm+PNXPeBRhZSXvYkCyOw5qaUp3XteIEINL2u/Iva4j88FqBlJ/DSeA?= =?us-ascii?Q?Fv3NwVCOp5QoG+gdyute/Y5Lx087n1jhgLRgDEjmvUka2sI3ihMK8Sn8M0eL?= =?us-ascii?Q?jCUY8FOhg2t1lpqNup5QrKdHtqMPFOcu3oE70WKjj3O9Bdnpgw7OqyeMGRwX?= =?us-ascii?Q?VgiKwbbTkGQ08IYmiT0uLxk5iVUDaIWEiuDZpwIm14pV3Ieapw=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY8PR11MB7747.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wwgKLQ5szbpSVyDCtr24Oicyk8KsXMGZISJJmRvA/+FcRxmEViP8O53AaTDu?= =?us-ascii?Q?C6FSlS38jFqH7w0nwB2TWAhQJdybXbHxahdzo5mo11r5BINnAHvhjXUnWcgY?= =?us-ascii?Q?hP74ia218CKMgRcomTh25wPWB+HndSErvpAJMeaD6S4Fl3ssuHPQzr7RI5rI?= =?us-ascii?Q?tApniigorXRZzY/S547iEqc50/bus8YFYj6uUYEtHFe6CpOyFgjRCdjHFpOH?= =?us-ascii?Q?hyhS/SlAZJEXhNoFzO1gEUAfmLdP5FZ43zCAdIRAUv7vfLev1VQI1DtSXvSE?= =?us-ascii?Q?h3Trr9EcjfAhsFIvRj3rhH5xp4Bi6EPDSKvL5CdBNHGtpm2uF28Xh4M9Gb98?= =?us-ascii?Q?jwdUdXi12npvzUNADBqA6Lik0fRZEZmU6+lONhH+oKhvqAZpvaUvMGmk9nEB?= =?us-ascii?Q?ljUAlHyrWtY58fBYlNnR1336/gIL53ia2efJVsiNhH+zOxb7rwBqgXDZMxdt?= =?us-ascii?Q?v0L051ugW3GK4nVMHg00NmbE5HovIcpJFEKD9pjhbqXhjmQ0smNXLJaZGHTW?= =?us-ascii?Q?MueWeu70e/AS9Mys7JTtj3GqshIm++gpjqf4LBb0eJ/NuxgWNadCM+tEoNrt?= =?us-ascii?Q?uznB7WkWuXp54LpCG6LUGevavRgX/j8QFos5GFm/KktGKZzwhOFcp9ExL8mY?= =?us-ascii?Q?uaAs7Jes8Pv31d8s00/nuyF/bBEQx21OYSYNkjJeqd9vo2XkgsUauGta9bRu?= =?us-ascii?Q?BBeqgy0O/caMygLnICLfufjIjP/0EggdX0jRqEmo2xeLBqbAvkfOFNBwbyxx?= =?us-ascii?Q?qms+zrLmAMs0uvaD5cKlYOqD1Io5GXIlzIdnfzg37ZlCF7macjmVq4RueJJI?= =?us-ascii?Q?5WwBXL0h6Px5+3/reejgUb3LScLsIm1vVuY6eaz+I2d1NaIGddRu+xBOw+fk?= =?us-ascii?Q?sNO/PUSKPIMpIbZSBpBFxWAev7X0jZjJC3KWZMLZhP8bC8s/UtALxRAW2gHu?= =?us-ascii?Q?v/vgfcjnE7SeQQsrDeM+pHg55g/SEWzeFQ73hkvnwL0YnTbXWlIpoIn80RGs?= =?us-ascii?Q?fjP2Xu2krFJ7LuIRCY4Ds0wtHdMhOZOmTBzhEy9vWazHvmJK8v1t2nsdl9Dx?= =?us-ascii?Q?xlIiZAT4vS1ThM8avVYwzd4CeZlDFLFMLBjXBKIjRrvgk0Sdx+TPh+fjTafi?= =?us-ascii?Q?1ph4k0/fCXgE0l2Q1VHRYe3gOw9BxoDDQfkK0JvdzAY7A1BSHPcrsuuFNOfa?= =?us-ascii?Q?faXuQa6ZZfy64dafN0+RKbjChRt1lw+Yiqn4FzD/VF7Wnfru8oskubzCG/vE?= =?us-ascii?Q?nF/6sm59p+0KLIZWIZKUWlC7Z+YS7SHgX4AggKY6yWMpP9pL6UIDjnpkR7UT?= =?us-ascii?Q?B2En1wsirsdTdUb88/zG/PlUZxZhhJJNs3IKB9aY+zV3+2hY/ETZfKdBUajC?= =?us-ascii?Q?QYNsvq0DCemsaDJUT7QdRmhIELEkR9hGxKjZ8ChUYr0yS7ju8P7ir+4FRnG4?= =?us-ascii?Q?pT2pWAOR1q2zJGtabrA6YcrGQXOKbS+8mdulnO8EmsdWLu7VkE7Ay6AjLf1W?= =?us-ascii?Q?OfqvOWrAtWkqcCfXYps531Bukz+g1Sk38muNNCG0VY4c6fHFz+Wac5tbzs14?= =?us-ascii?Q?iQbIRaQ7NlX+1B1DEiC2yU+JnTVluw8J3NHxksvQ?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR11MB7747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5645e112-6f09-4d5b-8692-08dc99b5e5c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2024 10:09:30.2994 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qFe4VAxDXEJQbzCqdzuiJL5D4DDX05XRIG5deoil8vKvB23aAoRqxKkDRsyyRS6mmVIISxYT0y5tg+rl2D97BSoO0BZEokOrw6/EqqrD0oc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6393 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > With the internal Linux upstream feedback that is received on IDPF=20 > driver and also some references available online, it is discouraged to=20 > use 1-sized array fields in the structures, especially in the new=20 > Linux drivers that are going to be upstreamed. Instead, it is=20 > recommended to use flex array fields for the dynamic sized structures. >=20 > Some fixes based on code change is introduced to compile dpdk. >=20 > Signed-off-by: Soumyadeep Hore > --- > drivers/common/idpf/base/virtchnl2.h | 466 ++++----------------- > drivers/common/idpf/idpf_common_virtchnl.c | 2 +- > drivers/net/cpfl/cpfl_ethdev.c | 28 +- > 3 files changed, 86 insertions(+), 410 deletions(-) >=20 > diff --git a/drivers/common/idpf/base/virtchnl2.h=20 > b/drivers/common/idpf/base/virtchnl2.h > index 9dd5191c0e..317bd06c0f 100644 > --- a/drivers/common/idpf/base/virtchnl2.h > +++ b/drivers/common/idpf/base/virtchnl2.h > @@ -63,6 +63,10 @@ enum virtchnl2_status { > #define VIRTCHNL2_CHECK_STRUCT_LEN(n, X) \ > static_assert((n) =3D=3D sizeof(struct X), \ > "Structure length does not match with the expected value") > +#define VIRTCHNL2_CHECK_STRUCT_VAR_LEN(n, X, T) \ > + VIRTCHNL2_CHECK_STRUCT_LEN(n, X) > + > +#define STRUCT_VAR_LEN 1 > =20 > /** > * New major set of opcodes introduced and so leaving room for @@=20 > -696,10 +700,9 @@ VIRTCHNL2_CHECK_STRUCT_LEN(32,=20 > virtchnl2_queue_reg_chunk); struct virtchnl2_queue_reg_chunks { > __le16 num_chunks; > u8 pad[6]; > - struct virtchnl2_queue_reg_chunk chunks[1]; > + struct virtchnl2_queue_reg_chunk chunks[STRUCT_VAR_LEN]; > }; This patch doesn't actually seem to be using flexible array members. Instead I see a macro with value "1" being used in place of a hard-coded "1= ". Can you please check that commit message matches what's actually happeni= ng, and that changes in the patch are correct. Thanks, /Bruce Addressed in v6 by adding the corresponding commit message. Regards, Soumya