From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4043E2C7A for ; Mon, 9 Feb 2015 15:19:54 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 09 Feb 2015 06:14:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,544,1418112000"; d="scan'208";a="683102725" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by orsmga002.jf.intel.com with ESMTP; 09 Feb 2015 06:19:52 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 9 Feb 2015 22:19:50 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.62]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.197]) with mapi id 14.03.0195.001; Mon, 9 Feb 2015 22:19:50 +0800 From: "Liang, Cunming" To: Olivier MATZ , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread Thread-Index: AQHQPoxrbbzTMhSAhkeKUloAe874tZzmsL0AgAG2GOA= Date: Mon, 9 Feb 2015 14:19:50 +0000 Message-ID: References: <1422491072-5114-1-git-send-email-cunming.liang@intel.com> <1422842559-13617-1-git-send-email-cunming.liang@intel.com> <1422842559-13617-12-git-send-email-cunming.liang@intel.com> <54D7C082.80803@6wind.com> In-Reply-To: <54D7C082.80803@6wind.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2015 14:19:54 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Monday, February 09, 2015 4:01 AM > To: Liang, Cunming; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-= EAL > thread >=20 > Hi, >=20 > On 02/02/2015 03:02 AM, Cunming Liang wrote: > > For those non-EAL thread, *_lcore_id* is invalid and probably larger th= an > RTE_MAX_LCORE. > > The patch adds the check and allows only EAL thread using EAL per threa= d log > level and log type. > > Others shares the global log level. > > > > Signed-off-by: Cunming Liang > > --- > > lib/librte_eal/common/eal_common_log.c | 17 +++++++++++++++-- > > lib/librte_eal/common/include/rte_log.h | 5 +++++ > > 2 files changed, 20 insertions(+), 2 deletions(-) > > > > diff --git a/lib/librte_eal/common/eal_common_log.c > b/lib/librte_eal/common/eal_common_log.c > > index cf57619..e8dc94a 100644 > > --- a/lib/librte_eal/common/eal_common_log.c > > +++ b/lib/librte_eal/common/eal_common_log.c > > @@ -193,11 +193,20 @@ rte_set_log_type(uint32_t type, int enable) > > rte_logs.type &=3D (~type); > > } > > > > +/* Get global log type */ > > +uint32_t > > +rte_get_log_type(void) > > +{ > > + return rte_logs.type; > > +} > > + > > /* get the current loglevel for the message beeing processed */ > > int rte_log_cur_msg_loglevel(void) > > { > > unsigned lcore_id; > > lcore_id =3D rte_lcore_id(); > > + if (lcore_id >=3D RTE_MAX_LCORE) > > + return rte_get_log_level(); > > return log_cur_msg[lcore_id].loglevel; > > } > > > > @@ -206,6 +215,8 @@ int rte_log_cur_msg_logtype(void) > > { > > unsigned lcore_id; > > lcore_id =3D rte_lcore_id(); > > + if (lcore_id >=3D RTE_MAX_LCORE) > > + return rte_get_log_type(); > > return log_cur_msg[lcore_id].logtype; > > } > > > > @@ -265,8 +276,10 @@ rte_vlog(__attribute__((unused)) uint32_t level, > > > > /* save loglevel and logtype in a global per-lcore variable */ > > lcore_id =3D rte_lcore_id(); > > - log_cur_msg[lcore_id].loglevel =3D level; > > - log_cur_msg[lcore_id].logtype =3D logtype; > > + if (lcore_id < RTE_MAX_LCORE) { > > + log_cur_msg[lcore_id].loglevel =3D level; > > + log_cur_msg[lcore_id].logtype =3D logtype; > > + } > > > > ret =3D vfprintf(f, format, ap); > > fflush(f); > > diff --git a/lib/librte_eal/common/include/rte_log.h > b/lib/librte_eal/common/include/rte_log.h > > index db1ea08..f83a0d9 100644 > > --- a/lib/librte_eal/common/include/rte_log.h > > +++ b/lib/librte_eal/common/include/rte_log.h > > @@ -144,6 +144,11 @@ uint32_t rte_get_log_level(void); > > void rte_set_log_type(uint32_t type, int enable); > > > > /** > > + * Get the global log type. > > + */ > > +uint32_t rte_get_log_type(void); > > + > > +/** > > * Get the current loglevel for the message being processed. > > * > > * Before calling the user-defined stream for logging, the log > > >=20 > Wouldn't it be better to change the variable: > static struct log_cur_msg log_cur_msg[RTE_MAX_LCORE]; > into a pthread (tls) variable? >=20 > With your patch, the log level and log type are not saved for > non-EAL threads. If TLS were used, I think it would work in any case. [LCM] Good point. But for this patch set, still suppose not involve big imp= act to EAL thread. For improve non-EAL thread, we'll have a separate patch set for it. >=20 > Regards, > Olivier