From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 91E3EB54D for ; Sun, 15 Feb 2015 09:32:38 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 15 Feb 2015 00:32:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,580,1418112000"; d="scan'208";a="454856425" Received: from kmsmsx151.gar.corp.intel.com ([172.21.73.86]) by FMSMGA003.fm.intel.com with ESMTP; 15 Feb 2015 00:17:43 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by KMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP Server (TLS) id 14.3.195.1; Sun, 15 Feb 2015 16:32:34 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.62]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.197]) with mapi id 14.03.0195.001; Sun, 15 Feb 2015 16:32:32 +0800 From: "Liang, Cunming" To: "Qiu, Michael" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] test: add ut for eal flags --lcores Thread-Index: AQHQSOLyM/lYVa7d7kOh/4dMh6ApxJzxYKng Date: Sun, 15 Feb 2015 08:32:33 +0000 Message-ID: References: <1423979251-5562-1-git-send-email-cunming.liang@intel.com> <533710CFB86FA344BFBF2D6802E60286CE9D76@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <533710CFB86FA344BFBF2D6802E60286CE9D76@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v1] test: add ut for eal flags --lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 08:32:39 -0000 Hi, > -----Original Message----- > From: Qiu, Michael > Sent: Sunday, February 15, 2015 2:59 PM > To: Liang, Cunming; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] test: add ut for eal flags --lcores >=20 > Hi, Steve >=20 > Why not post this patch within your enabling EAL "--lcores" option patch > set? > As it is not merged yet. >=20 [LCM] As that patch series already go through several round review, I won't= expect to involve the totally new update on it. =20 > Just a suggestion, depends you. >=20 > Thanks, > Michael > On 2/15/2015 1:48 PM, Cunming Liang wrote: > > The patch add unit test for the new eal option "--lcores". > > > > Signed-off-by: Cunming Liang > > --- > > It depends on the previous patch which enabling EAL "--lcores" option. > > http://dpdk.org/ml/archives/dev/2015-February/013204.html > > > > app/test/test_eal_flags.c | 95 > ++++++++++++++++++++++++++++++++++++++++------- > > 1 file changed, 81 insertions(+), 14 deletions(-) > > > > diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c > > index 0a8269c..0352f87 100644 > > --- a/app/test/test_eal_flags.c > > +++ b/app/test/test_eal_flags.c > > @@ -512,47 +512,114 @@ test_missing_c_flag(void) > > > > /* -c flag but no coremask value */ > > const char *argv1[] =3D { prgname, prefix, mp_flag, "-n", "3", "-c"}; > > - /* No -c or -l flag at all */ > > + /* No -c, -l or --lcores flag at all */ > > const char *argv2[] =3D { prgname, prefix, mp_flag, "-n", "3"}; > > /* bad coremask value */ > > - const char *argv3[] =3D { prgname, prefix, mp_flag, "-n", "3", "-c", = "error" }; > > + const char *argv3[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-c", "error" }; > > /* sanity check of tests - valid coremask value */ > > - const char *argv4[] =3D { prgname, prefix, mp_flag, "-n", "3", "-c", = "1" }; > > + const char *argv4[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-c", "1" }; > > /* -l flag but no corelist value */ > > - const char *argv5[] =3D { prgname, prefix, mp_flag, "-n", "3", "-l"}; > > - const char *argv6[] =3D { prgname, prefix, mp_flag, "-n", "3", "-l", = " " }; > > + const char *argv5[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-l"}; > > + const char *argv6[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-l", " " }; > > /* bad corelist values */ > > - const char *argv7[] =3D { prgname, prefix, mp_flag, "-n", "3", "-l", = "error" }; > > - const char *argv8[] =3D { prgname, prefix, mp_flag, "-n", "3", "-l", = "1-" }; > > - const char *argv9[] =3D { prgname, prefix, mp_flag, "-n", "3", "-l", = "1," }; > > - const char *argv10[] =3D { prgname, prefix, mp_flag, "-n", "3", "-l",= "1#2" }; > > + const char *argv7[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-l", "error" }; > > + const char *argv8[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-l", "1-" }; > > + const char *argv9[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-l", "1," }; > > + const char *argv10[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-l", "1#2" }; > > /* sanity check test - valid corelist value */ > > - const char *argv11[] =3D { prgname, prefix, mp_flag, "-n", "3", "-l",= "1-2,3" }; > > + const char *argv11[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "-l", "1-2,3" }; > > + > > + /* --lcores flag but no lcores value */ > > + const char *argv12[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores" }; > > + const char *argv13[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", " " }; > > + /* bad lcores value */ > > + const char *argv14[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "1-3-5" }; > > + const char *argv15[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "0-1,,2" }; > > + const char *argv16[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "0-,1" }; > > + const char *argv17[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "(0-,2-4)" }; > > + const char *argv18[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "(-1,2)" }; > > + const char *argv19[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "(2-4)@(2-4-6)" }; > > + const char *argv20[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "(a,2)" }; > > + const char *argv21[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "1-3@(1,3)" }; > > + const char *argv22[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "3@((1,3)" }; > > + const char *argv23[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "(4-7)=3D(1,3)" }; > > + const char *argv24[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", "[4-7]@(1,3)" }; > > + /* sanity check of tests - valid lcores value */ > > + const char *argv25[] =3D { prgname, prefix, mp_flag, > > + "-n", "3", "--lcores", > > + "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"}; > > > > if (launch_proc(argv1) =3D=3D 0 > > || launch_proc(argv2) =3D=3D 0 > > || launch_proc(argv3) =3D=3D 0) { > > - printf("Error - process ran without error when missing -c flag\n"); > > + printf("Error - " > > + "process ran without error when missing -c flag\n"); > > return -1; > > } > > if (launch_proc(argv4) !=3D 0) { > > - printf("Error - process did not run ok with valid coremask > value\n"); > > + printf("Error - " > > + "process did not run ok with valid coremask value\n"); > > return -1; > > } > > > > + /* start -l test */ > > if (launch_proc(argv5) =3D=3D 0 > > || launch_proc(argv6) =3D=3D 0 > > || launch_proc(argv7) =3D=3D 0 > > || launch_proc(argv8) =3D=3D 0 > > || launch_proc(argv9) =3D=3D 0 > > || launch_proc(argv10) =3D=3D 0) { > > - printf("Error - process ran without error with invalid -l flag\n"); > > + printf("Error - " > > + "process ran without error with invalid -l flag\n"); > > return -1; > > } > > if (launch_proc(argv11) !=3D 0) { > > - printf("Error - process did not run ok with valid corelist value\n")= ; > > + printf("Error - " > > + "process did not run ok with valid corelist value\n"); > > return -1; > > } > > + > > + /* start --lcores tests */ > > + if (launch_proc(argv12) =3D=3D 0 || launch_proc(argv13) =3D=3D 0 || > > + launch_proc(argv14) =3D=3D 0 || launch_proc(argv15) =3D=3D 0 || > > + launch_proc(argv16) =3D=3D 0 || launch_proc(argv17) =3D=3D 0 || > > + launch_proc(argv18) =3D=3D 0 || launch_proc(argv19) =3D=3D 0 || > > + launch_proc(argv20) =3D=3D 0 || launch_proc(argv21) =3D=3D 0 || > > + launch_proc(argv21) =3D=3D 0 || launch_proc(argv22) =3D=3D 0 || > > + launch_proc(argv23) =3D=3D 0 || launch_proc(argv24) =3D=3D 0) { > > + printf("Error - " > > + "process ran without error with invalid --lcore flag\n"); > > + return -1; > > + } > > + > > + if (launch_proc(argv25) !=3D 0) { > > + printf("Error - " > > + "process did not run ok with valid corelist value\n"); > > + return -1; > > + } > > + > > return 0; > > } > >