* [dpdk-dev] [PATCH] virtio: Fix compilation issue on freebsd
@ 2015-02-27 2:30 Ouyang Changchun
2015-02-27 5:11 ` Liang, Cunming
0 siblings, 1 reply; 3+ messages in thread
From: Ouyang Changchun @ 2015-02-27 2:30 UTC (permalink / raw)
To: dev
This patch fixes the compilation issue on freebsd:
/root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c: In function 'virtio_resource_init':
/root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c:1071:56: error: unused parameter 'pci_dev' [-Werror=unused-parameter] static int virtio_resource_init(struct rte_pci_device *pci_dev)
^
cc1: all warnings being treated as errors
Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
---
lib/librte_pmd_virtio/virtio_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c
index 9eb0217..88ecd57 100644
--- a/lib/librte_pmd_virtio/virtio_ethdev.c
+++ b/lib/librte_pmd_virtio/virtio_ethdev.c
@@ -1068,7 +1068,7 @@ virtio_has_msix(const struct rte_pci_addr *loc __rte_unused)
return 0;
}
-static int virtio_resource_init(struct rte_pci_device *pci_dev)
+static int virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused)
{
/* no setup required */
return 0;
--
1.8.4.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] virtio: Fix compilation issue on freebsd
2015-02-27 2:30 [dpdk-dev] [PATCH] virtio: Fix compilation issue on freebsd Ouyang Changchun
@ 2015-02-27 5:11 ` Liang, Cunming
2015-02-27 23:13 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Liang, Cunming @ 2015-02-27 5:11 UTC (permalink / raw)
To: Ouyang, Changchun, dev
Hi,
> -----Original Message-----
> From: Ouyang, Changchun
> Sent: Friday, February 27, 2015 10:30 AM
> To: dev@dpdk.org
> Cc: Liang, Cunming; Cao, Waterman; Ouyang, Changchun
> Subject: [PATCH] virtio: Fix compilation issue on freebsd
>
> This patch fixes the compilation issue on freebsd:
>
> /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c: In function
> 'virtio_resource_init':
> /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c:1071:56: error:
> unused parameter 'pci_dev' [-Werror=unused-parameter] static int
> virtio_resource_init(struct rte_pci_device *pci_dev)
> ^
> cc1: all warnings being treated as errors
>
> Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
> ---
> lib/librte_pmd_virtio/virtio_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
> b/lib/librte_pmd_virtio/virtio_ethdev.c
> index 9eb0217..88ecd57 100644
> --- a/lib/librte_pmd_virtio/virtio_ethdev.c
> +++ b/lib/librte_pmd_virtio/virtio_ethdev.c
> @@ -1068,7 +1068,7 @@ virtio_has_msix(const struct rte_pci_addr *loc
> __rte_unused)
> return 0;
> }
>
> -static int virtio_resource_init(struct rte_pci_device *pci_dev)
> +static int virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused)
> {
> /* no setup required */
> return 0;
> --
> 1.8.4.2
Acked-by: Cunming Liang <cunming.liang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] virtio: Fix compilation issue on freebsd
2015-02-27 5:11 ` Liang, Cunming
@ 2015-02-27 23:13 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-02-27 23:13 UTC (permalink / raw)
To: Ouyang, Changchun; +Cc: dev
> > This patch fixes the compilation issue on freebsd:
> >
> > /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c: In function
> > 'virtio_resource_init':
> > /root/qwan/tmp/dpdk_org/lib/librte_pmd_virtio/virtio_ethdev.c:1071:56: error:
> > unused parameter 'pci_dev' [-Werror=unused-parameter] static int
> > virtio_resource_init(struct rte_pci_device *pci_dev)
> > ^
> > cc1: all warnings being treated as errors
> >
> > Signed-off-by: Changchun Ouyang <changchun.ouyang@intel.com>
>
> Acked-by: Cunming Liang <cunming.liang@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-27 23:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-27 2:30 [dpdk-dev] [PATCH] virtio: Fix compilation issue on freebsd Ouyang Changchun
2015-02-27 5:11 ` Liang, Cunming
2015-02-27 23:13 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).