From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 64D1B6A95 for ; Thu, 2 Apr 2015 03:44:10 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 01 Apr 2015 18:44:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,507,1422950400"; d="scan'208";a="549886034" Received: from pgsmsx104.gar.corp.intel.com ([10.221.44.91]) by orsmga003.jf.intel.com with ESMTP; 01 Apr 2015 18:44:08 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by PGSMSX104.gar.corp.intel.com (10.221.44.91) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 2 Apr 2015 09:44:07 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.223]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.80]) with mapi id 14.03.0224.002; Thu, 2 Apr 2015 09:44:05 +0800 From: "Liang, Cunming" To: Thomas Monjalon , "Zhang, XiaonanX" , "Cao, Waterman" Thread-Topic: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on link_get Thread-Index: AQHQbCROk8CqtK3VdkuUz+TSCOQQh5027tKAgAA38wCAAOVygIAA5UfQ Date: Thu, 2 Apr 2015 01:44:05 +0000 Message-ID: References: <1427855614-8654-1-git-send-email-cunming.liang@intel.com> <63FB47D6C0357E428AA804B2C89068BA012D58D6@SHSMSX104.ccr.corp.intel.com> <32480824.oD8BQeRvMH@xps13> In-Reply-To: <32480824.oD8BQeRvMH@xps13> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on link_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2015 01:44:11 -0000 Hi Thomas, > What is the relation between link status timeout and qos_sched? [LCM] Validation team found qos_sched test failure on i40e. The sample depe= nds on link speed to calc the percentage. The root cause comes from that i40e link_get hasn't support wait_to_complet= e well.=20 I agree with you it should add more description in test report why 'Used Qo= S example to verified'. > > +-----------------------+----------------------+ > > | Subport output rate | Subport output rate | > > | (% line rate) | (Mpps) | > > +-----------+-----------+----------+-----------+ > > | Expected | Actual | Expected | Actual | > > +-----------+-----------+----------+-----------+ >=20 > This table is empty. [LCM] It's useless, should be omitted I think. Cunming > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, April 02, 2015 3:52 AM > To: Zhang, XiaonanX; Cao, Waterman > Cc: dev@dpdk.org; Zhang, Helin; Liang, Cunming > Subject: Re: [dpdk-dev] [PATCH] i40e: fix no effect wait_to_complete on l= ink_get >=20 > Hi, >=20 > 2015-04-01 06:10, Zhang, XiaonanX: > > > > Tested-by: Xiaonan zhang > > > > - OS: Fedora21 3.19.1-201.fc21.x86_64 > > - GCC: gcc version 4.9.1 20140930 (Red Hat 4.9.1-11) (GCC) > > - CPU: Intel(R) Xeon(R) CPU E5-2680 v2 @ 2.80GHz > > - NIC: Ethernet controller [0200]: Intel Corporation Ethernet Controlle= r X710 for > 10GbE SFP+ [8086:1572] (rev 01) > > - Default x86_64-native-linuxapp-gcc configuration > > - Total 1 cases, 1 passed, 0 failed > > > > - Test case: Used Qos example to verified > > ------------------------------------- >=20 > What is the relation between link status timeout and qos_sched? >=20 > > Traffic shaping for subport. Check that the subport rate is enforced. > > > > Set the subport output rate to x% of line rate (x =3D 10 .. 100). Set t= he subport TC > limits high (100% line rate each), so they do not constitute limitations.= Input traffic > is 100% line rate. > > > > Different tb period and tb credits, therefore different output rate, ar= e tried: > 25%, 50%, 75%, 90% and 100% the lineal rate. (The output for subport is T= b credits > per period / Tb period.) > > The traffic is injected change subport value random. > > > > Other parameters are same before tests and they don't change here. > > > > Cmdline: ./examples/qos_sched/build/qos_sched -c 0xe -n 4 -- --pfc > "0,1,2,3,3" --cfg "/root/profile_sched_pipe_1.cfg" > > > > The result is this table: > > > > > > +-----------------------+----------------------+ > > | Subport output rate | Subport output rate | > > | (% line rate) | (Mpps) | > > +-----------+-----------+----------+-----------+ > > | Expected | Actual | Expected | Actual | > > +-----------+-----------+----------+-----------+ >=20 > This table is empty. >=20 > > > > Signed-off-by: Xiaonan Zhang >=20 > It seems that this test report is not relevant. > It will be ignored in the commit message. Sorry