From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id B87E6C378 for ; Thu, 23 Jul 2015 16:18:42 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 23 Jul 2015 07:18:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,531,1432623600"; d="scan'208";a="734192353" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by orsmga001.jf.intel.com with ESMTP; 23 Jul 2015 07:18:40 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX152.gar.corp.intel.com (172.21.73.87) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 23 Jul 2015 22:18:38 +0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.126]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.146]) with mapi id 14.03.0224.002; Thu, 23 Jul 2015 22:18:37 +0800 From: "Liang, Cunming" To: "dev@dpdk.org" , "thomas.monjalon@6wind.com" Thread-Topic: [PATCH v15 00/13] Interrupt mode PMD Thread-Index: AQHQwpiW/WKSaPp0XkO2+PO3+21v8J3pEX/g Date: Thu, 23 Jul 2015 14:18:37 +0000 Message-ID: References: <1437113775-32199-1-git-send-email-cunming.liang@intel.com> <1437361349-2801-1-git-send-email-cunming.liang@intel.com> In-Reply-To: <1437361349-2801-1-git-send-email-cunming.liang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "shemming@brocade.com" Subject: Re: [dpdk-dev] [PATCH v15 00/13] Interrupt mode PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jul 2015 14:18:43 -0000 Hi Thomas and all, This patch set postponed from v2.0, and widely reviewed during this release= cycle. The packet I/O interrupt framework is the prerequisite of all PMDs to suppo= rt packet I/O intr. There's no significant change since the last three version(v13~v15), the ch= anges are about ABI and version map fixing. It missed the rc1 in the last minutes, I'm now asking for the exception to = make it go into v2.1 rc2 if nobody will reject it. Again, thanks for all the comments by Stephen, David, Neil and Thomas. Thanks, Steve > -----Original Message----- > From: Liang, Cunming > Sent: Monday, July 20, 2015 11:02 AM > To: dev@dpdk.org; thomas.monjalon@6wind.com > Cc: shemming@brocade.com; david.marchand@6wind.com; Zhou, Danny; Liu, > Yong; nhorman@tuxdriver.com; Liang, Cunming > Subject: [PATCH v15 00/13] Interrupt mode PMD >=20 > v15 changes > - remove unnecessary RTE_NEXT_ABI comment > - remove ifdef RTE_NEXT_ABI from header file >=20 > v14 changes > - per-patch basis ABI compatibility rework > - remove unnecessary 'local: *' from version map > - minor comments rework >=20 > v13 changes > - version map cleanup for v2.1 > - replace RTE_EAL_RX_INTR by RTE_NEXT_ABI for ABI compatibility >=20 > Patch series v12 > Acked-by: Stephen Hemminger > Acked-by: Danny Zhou >=20 > v12 changes > - bsd cleanup for unused variable warning > - fix awkward line split in debug message >=20 > v11 changes > - typo cleanup and check kernel style >=20 > v10 changes > - code rework to return actual error code > - bug fix for lsc when using uio_pci_generic >=20 > v9 changes > - code rework to fix open comment > - bug fix for igb lsc when both lsc and rxq are enabled in vfio-msix > - new patch to turn off the feature by default so as to avoid v2.1 abi b= roken >=20 > v8 changes > - remove condition check for only vfio-msix > - add multiplex intr support when only one intr vector allowed > - lsc and rxq interrupt runtime enable decision > - add safe event delete while the event wakeup execution happens >=20 > v7 changes > - decouple epoll event and intr operation > - add condition check in the case intr vector is disabled > - renaming some APIs >=20 > v6 changes > - split rte_intr_wait_rx_pkt into two APIs 'wait' and 'set'. > - rewrite rte_intr_rx_wait/rte_intr_rx_set. > - using vector number instead of queue_id as interrupt API params. > - patch reorder and split. >=20 > v5 changes > - Rebase the patchset onto the HEAD > - Isolate ethdev from EAL for new-added wait-for-rx interrupt function > - Export wait-for-rx interrupt function for shared libraries > - Split-off a new patch file for changed struct rte_intr_handle that > other patches depend on, to avoid breaking git bisect > - Change sample applicaiton to accomodate EAL function spec change > accordingly >=20 > v4 changes > - Export interrupt enable/disable functions for shared libraries > - Adjust position of new-added structure fields and functions to > avoid breaking ABI >=20 > v3 changes > - Add return value for interrupt enable/disable functions > - Move spinlok from PMD to L3fwd-power > - Remove unnecessary variables in e1000_mac_info > - Fix miscelleous review comments >=20 > v2 changes > - Fix compilation issue in Makefile for missed header file. > - Consolidate internal and community review comments of v1 patch set. >=20 > The patch series introduce low-latency one-shot rx interrupt into DPDK wi= th > polling and interrupt mode switch control example. >=20 > DPDK userspace interrupt notification and handling mechanism is based on = UIO > with below limitation: > 1) It is designed to handle LSC interrupt only with inefficient suspended > pthread wakeup procedure (e.g. UIO wakes up LSC interrupt handling thr= ead > which then wakes up DPDK polling thread). In this way, it introduces > non-deterministic wakeup latency for DPDK polling thread as well as pa= cket > latency if it is used to handle Rx interrupt. > 2) UIO only supports a single interrupt vector which has to been shared b= y > LSC interrupt and interrupts assigned to dedicated rx queues. >=20 > This patchset includes below features: > 1) Enable one-shot rx queue interrupt in ixgbe PMD(PF & VF) and igb PMD(P= F > only) > . > 2) Build on top of the VFIO mechanism instead of UIO, so it could support > up to 64 interrupt vectors for rx queue interrupts. > 3) Have 1 DPDK polling thread handle per Rx queue interrupt with a dedica= ted > VFIO eventfd, which eliminates non-deterministic pthread wakeup latenc= y in > user space. > 4) Demonstrate interrupts control APIs and userspace NAIP-like polling/in= terrupt > switch algorithms in L3fwd-power example. >=20 > Known limitations: > 1) It does not work for UIO due to a single interrupt eventfd shared by L= SC > and rx queue interrupt handlers causes a mess. [FIXED] > 2) LSC interrupt is not supported by VF driver, so it is by default disab= led > in L3fwd-power now. Feel free to turn in on if you want to support bot= h LSC > and rx queue interrupts on a PF. >=20 > Cunming Liang (13): > eal/linux: add interrupt vectors support in intr_handle > eal/linux: add rte_epoll_wait/ctl support > eal/linux: add API to set rx interrupt event monitor > eal/linux: fix comments typo on vfio msi > eal/linux: map eventfd to VFIO MSI-X intr vector > eal/linux: standalone intr event fd create support > eal/linux: fix lsc read error in uio_pci_generic > eal/bsd: dummy for new intr definition > eal/bsd: fix inappropriate linuxapp referred in bsd > ethdev: add rx intr enable, disable and ctl functions > ixgbe: enable rx queue interrupts for both PF and VF > igb: enable rx queue interrupts for PF > l3fwd-power: enable one-shot rx interrupt and polling/interrupt mode > switch >=20 > drivers/net/e1000/igb_ethdev.c | 311 ++++++++++-- > drivers/net/ixgbe/ixgbe_ethdev.c | 527 > ++++++++++++++++++++- > drivers/net/ixgbe/ixgbe_ethdev.h | 4 + > examples/l3fwd-power/main.c | 205 ++++++-- > lib/librte_eal/bsdapp/eal/eal_interrupts.c | 42 ++ > .../bsdapp/eal/include/exec-env/rte_interrupts.h | 74 ++- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 5 + > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 414 ++++++++++++++-= - > .../linuxapp/eal/include/exec-env/rte_interrupts.h | 153 ++++++ > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 8 + > lib/librte_ether/rte_ethdev.c | 147 ++++++ > lib/librte_ether/rte_ethdev.h | 104 ++++ > lib/librte_ether/rte_ether_version.map | 4 + > 13 files changed, 1870 insertions(+), 128 deletions(-) >=20 > -- > 1.8.1.4