From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from prod-mail-xrelay08.akamai.com (prod-mail-xrelay08.akamai.com [96.6.114.112]) by dpdk.org (Postfix) with ESMTP id 897325932 for ; Wed, 20 Aug 2014 22:22:26 +0200 (CEST) Received: from prod-mail-xrelay08.akamai.com (localhost.localdomain [127.0.0.1]) by postfix.imss70 (Postfix) with ESMTP id 991804852E; Wed, 20 Aug 2014 20:25:59 +0000 (GMT) Received: from prod-mail-relay08.akamai.com (prod-mail-relay08.akamai.com [172.27.22.71]) by prod-mail-xrelay08.akamai.com (Postfix) with ESMTP id 8D2B64840B; Wed, 20 Aug 2014 20:25:59 +0000 (GMT) Received: from ustx2ex-cashub.dfw01.corp.akamai.com (ustx2ex-cashub2.dfw01.corp.akamai.com [172.27.25.76]) by prod-mail-relay08.akamai.com (Postfix) with ESMTP id 879009805C; Wed, 20 Aug 2014 20:25:59 +0000 (GMT) Received: from USMBX2.msg.corp.akamai.com ([169.254.1.85]) by ustx2ex-cashub2.dfw01.corp.akamai.com ([172.27.25.76]) with mapi; Wed, 20 Aug 2014 15:25:59 -0500 From: "Sanford, Robert" To: Declan Doherty , "dev@dpdk.org" Date: Wed, 20 Aug 2014 15:25:57 -0500 Thread-Topic: [dpdk-dev] [PATCH 3/6] bond: fix naming inconsistency in tx_burst_round_robin Thread-Index: Ac+8tPPOGpDX4o8qTACEhrf+Wizghg== Message-ID: References: <1408456313-28812-1-git-send-email-declan.doherty@intel.com> <1408456313-28812-4-git-send-email-declan.doherty@intel.com> In-Reply-To: <1408456313-28812-4-git-send-email-declan.doherty@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.4.3.140616 acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/6] bond: fix naming inconsistency in tx_burst_round_robin X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Aug 2014 20:22:26 -0000 Reviewed-by: Robert Sanford >Renaming struct bond_dev_pritvate *dev_private to internals to match >convention used in other pmds > >Signed-off-by: Declan Doherty >--- > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c >b/lib/librte_pmd_bond/rte_eth_bond_pmd.c >index 683b146..70123fc 100644 >--- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c >+++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c >@@ -92,7 +92,7 @@ static uint16_t > bond_ethdev_tx_burst_round_robin(void *queue, struct rte_mbuf **bufs, > uint16_t nb_pkts) > { >- struct bond_dev_private *dev_private; >+ struct bond_dev_private *internals; > struct bond_tx_queue *bd_tx_q; >=20 > struct rte_mbuf *slave_bufs[RTE_MAX_ETHPORTS][nb_pkts]; >@@ -107,13 +107,13 @@ bond_ethdev_tx_burst_round_robin(void *queue, >struct rte_mbuf **bufs, > int i, cs_idx =3D 0; >=20 > bd_tx_q =3D (struct bond_tx_queue *)queue; >- dev_private =3D bd_tx_q->dev_private; >+ internals =3D bd_tx_q->dev_private; >=20 > /* Copy slave list to protect against slave up/down changes during tx > * bursting */ >- num_of_slaves =3D dev_private->active_slave_count; >- memcpy(slaves, dev_private->active_slaves, >- sizeof(dev_private->active_slaves[0]) * num_of_slaves); >+ num_of_slaves =3D internals->active_slave_count; >+ memcpy(slaves, internals->active_slaves, >+ sizeof(internals->active_slaves[0]) * num_of_slaves); >=20 > if (num_of_slaves < 1) > return num_tx_total; >--=20 >1.7.0.7 >