From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rsanford@akamai.com>
Received: from prod-mail-xrelay02.akamai.com (prod-mail-xrelay02.akamai.com
 [72.246.2.14]) by dpdk.org (Postfix) with ESMTP id 40667B3CD
 for <dev@dpdk.org>; Tue, 26 Aug 2014 18:04:53 +0200 (CEST)
Received: from prod-mail-xrelay02.akamai.com (localhost [127.0.0.1])
 by postfix.imss70 (Postfix) with ESMTP id 0F0192855F;
 Tue, 26 Aug 2014 16:08:53 +0000 (GMT)
Received: from prod-mail-relay06.akamai.com (prod-mail-relay06.akamai.com
 [172.17.120.126])
 by prod-mail-xrelay02.akamai.com (Postfix) with ESMTP id EF80728558;
 Tue, 26 Aug 2014 16:08:52 +0000 (GMT)
Received: from ustx2ex-cashub.dfw01.corp.akamai.com
 (ustx2ex-cashub7.dfw01.corp.akamai.com [172.27.25.73])
 by prod-mail-relay06.akamai.com (Postfix) with ESMTP id D6963202F;
 Tue, 26 Aug 2014 16:08:52 +0000 (GMT)
Received: from USMBX2.msg.corp.akamai.com ([169.254.1.85]) by
 ustx2ex-cashub7.dfw01.corp.akamai.com ([172.27.25.73]) with mapi; Tue, 26 Aug
 2014 11:08:52 -0500
From: "Sanford, Robert" <rsanford@akamai.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 26 Aug 2014 11:08:53 -0500
Thread-Topic: [dpdk-dev] [PATCH 1/2] igb_uio: fix compability on old kernel
Thread-Index: Ac/BSAc/5iBoIG8nTDywjhHRtFKFOQ==
Message-ID: <D0222750.29B5%rsanford@akamai.com>
References: <20140725103627.4ca989b7@haswell.linuxnetplumber.net>
 <9317787.qKVt3oyQbN@xps13> <D01CF3B4.28B5%rsanford@akamai.com>
 <CA+cr1coJs9yokaDT1ya=5ChSWuSYWiF4TqmAhpcP0qLZKC4odA@mail.gmail.com>
 <20140823081453.6e3ae5d7@uryu.home.lan>
In-Reply-To: <20140823081453.6e3ae5d7@uryu.home.lan>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: Microsoft-MacOutlook/14.4.3.140616
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] igb_uio: fix compability on old kernel
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Aug 2014 16:04:53 -0000


>
>> This is what we came up with. It works for us. In our kernel headers'
>> linux/pci.h, pci_num_vf is enclosed within "#ifdef
>>CONFIG_PCI_IOV/#endif";
>> pci_intx_mask_supported and pci_check_and_mask_intx are enclosed within
>> "#ifdef HAVE_PCI_SET_MWI/#endif".
>>=20
>> What do you think?
>
>Maybe we can just get rid of kernel version checks all together and
>just use the HAVE_ checks.
>
>I will test on stock 2.6.32.

Sorry, I spoke too soon. Although it builds with the ifdefs, I just found
that it does not load.
"kernel: igb_uio: Unknown symbol irq_to_desc"