From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-outbound-1.vmware.com (smtp-outbound-1.vmware.com [208.91.2.12]) by dpdk.org (Postfix) with ESMTP id B9A9A7E75 for ; Tue, 28 Oct 2014 22:48:37 +0100 (CET) Received: from sc9-mailhost2.vmware.com (sc9-mailhost2.vmware.com [10.113.161.72]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 4073228C41; Tue, 28 Oct 2014 14:57:19 -0700 (PDT) Received: from EX13-CAS-007.vmware.com (EX13-CAS-007.vmware.com [10.113.191.57]) by sc9-mailhost2.vmware.com (Postfix) with ESMTP id 35A54B1938; Tue, 28 Oct 2014 14:57:19 -0700 (PDT) Received: from EX13-MBX-020.vmware.com (10.113.191.40) by EX13-MBX-001.vmware.com (10.113.191.21) with Microsoft SMTP Server (TLS) id 15.0.775.38; Tue, 28 Oct 2014 14:57:16 -0700 Received: from EX13-MBX-026.vmware.com (10.113.191.46) by EX13-MBX-020.vmware.com (10.113.191.40) with Microsoft SMTP Server (TLS) id 15.0.775.38; Tue, 28 Oct 2014 14:57:14 -0700 Received: from EX13-MBX-026.vmware.com ([fe80::858b:7f42:fd7c:703d]) by EX13-MBX-026.vmware.com ([fe80::858b:7f42:fd7c:703d%17]) with mapi id 15.00.0775.031; Tue, 28 Oct 2014 14:57:14 -0700 From: Yong Wang To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping Thread-Index: AQHP5q+f3kqeQUkLF0OqkGkH2ZSdUZwuOPwAgAAiocWADkeWgIAJg64A Date: Tue, 28 Oct 2014 21:57:14 +0000 Message-ID: References: <1413181389-14887-1-git-send-email-yongwang@vmware.com> <1413181389-14887-2-git-send-email-yongwang@vmware.com> <20141013113146.202b5eb3@uryu.home.lan> <20141022190933.44549786@uryu.home.lan> In-Reply-To: <20141022190933.44549786@uryu.home.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.113.160.246] Content-Type: text/plain; charset="us-ascii" Content-ID: <0E845C97B100C54EAEBF47FC22F3903B@pa-exch1.vmware.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 21:48:38 -0000 On 10/22/14, 6:39 AM, "Stephen Hemminger" wrote: >On Mon, 13 Oct 2014 18:42:18 +0000 >Yong Wang wrote: > >> Are you referring to the patch as a whole or your comment is about the >>reset of vlan_tci on the "else" (no vlan tags stripped) path? I am not >>sure I get your comments here. This patch simply fixes a bug on the rx >>vlan stripping path (where valid vlan_tci stripped is overwritten >>unconditionally later on the rx path in the original vmxnet3 pmd >>driver). All the other pmd drivers are doing the same thing in terms of >>translating descriptor status to rte_mbuf flags for vlan stripping. > >I was thinking that there are many fields in a pktmbuf and rather than >individually >setting them (like tci). The code should call the common >rte_pktmbuf_reset before setting >the fields. That way when someone adds a field to mbuf they don't have >to chasing >through every driver that does it's own initialization. Currently rte_pktmbuf_reset() is used in rte_pktmbuf_alloc() but looks like most pmd drivers use rte_rxmbuf_alloc() to replenish rx buffers, which directly calls __rte_mbuf_raw_alloc () without calling rte_pktmbuf_reset(). How about we change that in a separate patch to all pmd drivers so that we can keep their behavior consistent?