From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-5.cisco.com (alln-iport-5.cisco.com [173.37.142.92]) by dpdk.org (Postfix) with ESMTP id 3B1897F18 for ; Fri, 7 Nov 2014 16:37:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=4108; q=dns/txt; s=iport; t=1415375200; x=1416584800; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=NbScRdu3u49R6i9DT2MLLE+rftR7RHKv7xIsEbccjGg=; b=QuoNsVVSeTF0bo5O+dfSmhIffPE7Kokwn8j6HmN4sVBA5hsQAfRWRKJU O0leIymNGGBIeWfsWG5IF3pcigQB3jhwv/5P5pk16RwgFUV6l6gCvu3XF rbk1Z0WIf2ef6yIy7kyXKESTW9KvOfThJnXgAzXkw1XzGyDZk1kfqDDeT o=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ag4FANHoXFStJV2d/2dsb2JhbABbgw5UWQTLSYdXAoEcFgEBAQEBfYQDAQEEOj8QAgEIDgoeEDIlAgQOBYhB0BMBAQEBAQEBAQEBAQEBAQEBAQEBGZA5WAeESwWLBYcihFSESoJVgTISkQ+ECYN5bIEGQoEDAQEB X-IronPort-AV: E=Sophos;i="5.07,333,1413244800"; d="scan'208";a="94474808" Received: from rcdn-core-6.cisco.com ([173.37.93.157]) by alln-iport-5.cisco.com with ESMTP; 07 Nov 2014 15:46:39 +0000 Received: from xhc-aln-x03.cisco.com (xhc-aln-x03.cisco.com [173.36.12.77]) by rcdn-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id sA7Fkd3K002905 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 7 Nov 2014 15:46:39 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.60]) by xhc-aln-x03.cisco.com ([173.36.12.77]) with mapi id 14.03.0195.001; Fri, 7 Nov 2014 09:46:39 -0600 From: "Sujith Sankar (ssujith)" To: Neil Horman Thread-Topic: [dpdk-dev] [PATCH 3/7] ENIC PMD Makefile Thread-Index: AQHP+nbIzsw3+Pucd0yOvoaHzVpv+5xVbVSAgACijoA= Date: Fri, 7 Nov 2014 15:46:38 +0000 Message-ID: References: <1415390747-9532-1-git-send-email-ssujith@cisco.com> <1415390747-9532-4-git-send-email-ssujith@cisco.com> <20141107113449.GC25469@hmsreliant.think-freely.org> In-Reply-To: <20141107113449.GC25469@hmsreliant.think-freely.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.65.66.186] Content-Type: text/plain; charset="us-ascii" Content-ID: <9A61A30A51B3E04CAED71F974AB7B2C6@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 3/7] ENIC PMD Makefile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 15:37:08 -0000 Hi Neil, Thanks for the comments. I shall work on the modifications that you have suggested and get back with V2. Regards, -Sujith On 07/11/14 5:04 pm, "Neil Horman" wrote: >On Sat, Nov 08, 2014 at 01:35:43AM +0530, Sujith Sankar wrote: >> Signed-off-by: Sujith Sankar >> --- >> lib/librte_pmd_enic/Makefile | 66 >>++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> create mode 100644 lib/librte_pmd_enic/Makefile >>=20 >> diff --git a/lib/librte_pmd_enic/Makefile b/lib/librte_pmd_enic/Makefile >> new file mode 100644 >> index 0000000..7605a8f >> --- /dev/null >> +++ b/lib/librte_pmd_enic/Makefile >> @@ -0,0 +1,66 @@ >> +# BSD LICENSE >> +#=20 >> +# Copyright(c) 2010-2013 Intel Corporation. All rights reserved. >> +# All rights reserved. >> +#=20 >> +# Redistribution and use in source and binary forms, with or without >> +# modification, are permitted provided that the following conditions >> +# are met: >> +#=20 >> +# * Redistributions of source code must retain the above copyright >> +# notice, this list of conditions and the following disclaimer. >> +# * Redistributions in binary form must reproduce the above >>copyright=20 >> +# notice, this list of conditions and the following disclaimer >>in=20 >> +# the documentation and/or other materials provided with the >> +# distribution. >> +# * Neither the name of Intel Corporation nor the names of its >> +# contributors may be used to endorse or promote products >>derived=20 >> +# from this software without specific prior written permission. >> +#=20 >> +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND >>CONTRIBUTORS=20 >> +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >> +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS >>FOR=20 >> +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE >>COPYRIGHT=20 >> +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, >>INCIDENTAL,=20 >> +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT >> +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF >>USE,=20 >> +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON >>ANY=20 >> +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR >>TORT=20 >> +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE >>USE=20 >> +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH >>DAMAGE. >> +#=20 >> + >> +include $(RTE_SDK)/mk/rte.vars.mk >> + >> +# >> +# library name >> +# >> +LIB =3D librte_pmd_enic.a >> + >> +CFLAGS +=3D -I$(RTE_SDK)/lib/librte_hash/ >> +CFLAGS +=3D -O3 -Wno-deprecated >> + >> +VPATH +=3D $(RTE_SDK)/lib/librte_pmd_enic/src >> + >> +# >> +# all source are stored in SRCS-y >> +# >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic_main.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic_clsf.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_cq.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_wq.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_dev.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_intr.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_rq.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic_etherdev.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D enic_res.c >> +SRCS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D vnic_rss.c >> + >> + >> +# this lib depends upon: >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D lib/librte_eal >>lib/librte_ether >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D lib/librte_mempool >>lib/librte_mbuf >> +DEPDIRS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) +=3D lib/librte_net >>lib/librte_malloc >> + >> +include $(RTE_SDK)/mk/rte.lib.mk >> + >> --=20 >> 1.9.1 >>=20 >>=20 > >Make this the last patch in your series, and merge it with the chunk from >the >last patch that adds the enic directory to the lib/Makefile, so that a >bisect >will build between these commits. > >Neil >