From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) by dpdk.org (Postfix) with ESMTP id 54B496828 for ; Mon, 10 Nov 2014 11:06:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1878; q=dns/txt; s=iport; t=1415614571; x=1416824171; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=hRXxuz/JYIFWZtDQTxuSJohEIXFDkPv1zoTbceakN5o=; b=AOUL/UFf0OGfxN/h/8Ab7aVrO8Slg/EJNX5fdS+KRY6fzFpQz5/uAhBI +4rHTlob+qQ9MzT8b3CkmVyAkpxoQlUmjqm54k/hdn+1jb6MFlvN9kYme V6V7kFySoP+VoKnUUILOsnJj4hCu6qQQfF9TyWpvjqCANUN8FhAgiAElf w=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhIFAHuPYFStJV2R/2dsb2JhbABbgw6BLQTTRAKBJRYBAQEBAX2EAwEBBDo/EAIBCDYQMiUCBA4FiEHOCwEBAQEBAQEBAQEBAQEBAQEBAQEZkRUHhEsBBJIxi3SBNINPkV2DemyBSIEDAQEB X-IronPort-AV: E=Sophos;i="5.07,351,1413244800"; d="scan'208";a="367712430" Received: from rcdn-core-9.cisco.com ([173.37.93.145]) by rcdn-iport-9.cisco.com with ESMTP; 10 Nov 2014 10:16:10 +0000 Received: from xhc-aln-x11.cisco.com (xhc-aln-x11.cisco.com [173.36.12.85]) by rcdn-core-9.cisco.com (8.14.5/8.14.5) with ESMTP id sAAAG9Ei003196 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 10 Nov 2014 10:16:10 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.60]) by xhc-aln-x11.cisco.com ([173.36.12.85]) with mapi id 14.03.0195.001; Mon, 10 Nov 2014 04:16:09 -0600 From: "Sujith Sankar (ssujith)" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 4/7] VNIC common code Thread-Index: AQHP+nbJVKzbpkgKwEehYneMY0x0lJxVtQUAgAS1jQA= Date: Mon, 10 Nov 2014 10:16:09 +0000 Message-ID: References: <1415390747-9532-1-git-send-email-ssujith@cisco.com> <1415390747-9532-5-git-send-email-ssujith@cisco.com> <3857314.dObtBBdJqR@xps13> In-Reply-To: <3857314.dObtBBdJqR@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.127.148.111] Content-Type: text/plain; charset="us-ascii" Content-ID: <823AD02E412CD940A09BBC5060E5D263@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 4/7] VNIC common code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2014 10:06:26 -0000 Thomas, These are files common to all flavours (user-space as well as kernel mode) of VIC drivers. I shall add this info to the commit logs. Let me rework the directory structure too. Thanks, -Sujith On 07/11/14 9:21 pm, "Thomas Monjalon" wrote: >2014-11-08 01:35, Sujith Sankar: >> lib/librte_pmd_enic/src/cq_desc.h | 122 ++++ >> lib/librte_pmd_enic/src/cq_enet_desc.h | 257 ++++++++ >> lib/librte_pmd_enic/src/rq_enet_desc.h | 72 +++ >> lib/librte_pmd_enic/src/vnic_cq.c | 113 ++++ >> lib/librte_pmd_enic/src/vnic_cq.h | 148 +++++ >> lib/librte_pmd_enic/src/vnic_dev.c | 1077 >>+++++++++++++++++++++++++++++++ >> lib/librte_pmd_enic/src/vnic_dev.h | 198 ++++++ >> lib/librte_pmd_enic/src/vnic_devcmd.h | 770 ++++++++++++++++++++++ >> lib/librte_pmd_enic/src/vnic_enet.h | 74 +++ >> lib/librte_pmd_enic/src/vnic_intr.c | 79 +++ >> lib/librte_pmd_enic/src/vnic_intr.h | 122 ++++ >> lib/librte_pmd_enic/src/vnic_nic.h | 84 +++ >> lib/librte_pmd_enic/src/vnic_resource.h | 93 +++ >> lib/librte_pmd_enic/src/vnic_rq.c | 242 +++++++ >> lib/librte_pmd_enic/src/vnic_rq.h | 278 ++++++++ >> lib/librte_pmd_enic/src/vnic_rss.c | 81 +++ >> lib/librte_pmd_enic/src/vnic_rss.h | 57 ++ >> lib/librte_pmd_enic/src/vnic_stats.h | 82 +++ >> lib/librte_pmd_enic/src/vnic_wq.c | 241 +++++++ >> lib/librte_pmd_enic/src/vnic_wq.h | 279 ++++++++ >> lib/librte_pmd_enic/src/wq_enet_desc.h | 110 ++++ >> 21 files changed, 4579 insertions(+) > >What is the status of these files? >Are they copied from somewhere? >Please explain in the commit log. > >Could you move them in a subdirectory vnic/ or base/? > >Please could you remove the src/ subdirectory level? > >Thanks >--=20 >Thomas