From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Prasad Rao \(prrao\)" <prrao@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v4 6/6] DPDK changes for accommodating ENIC PMD
Date: Tue, 25 Nov 2014 10:46:17 +0000 [thread overview]
Message-ID: <D09A5A39.28A10%ssujith@cisco.com> (raw)
In-Reply-To: <CALwxeUtiCb5vOyFFmd3UeOa0ohCZSP71K6jrRrYSaWPhVRWrBw@mail.gmail.com>
David,
I tested it now, and it looks like the length is proper in
dev->men_resource[0].len without this change.
Not sure what changed in my workspace as I clearly remember seeing it
wrong and hence added the extra statement in the lib.
I shall remove it in v5.
Thanks for pointing it out, David.
Regards,
-Sujith
From: David Marchand <david.marchand@6wind.com>
Date: Tuesday, 25 November 2014 3:32 pm
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Prasad Rao (prrao)" <prrao@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v4 6/6] DPDK changes for accommodating
ENIC PMD
Hello Sujith,
On Tue, Nov 25, 2014 at 5:30 PM, Sujith Sankar
<ssujith@cisco.com> wrote:
diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
index c776ddc..87e7862 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
@@ -736,6 +736,7 @@ pci_vfio_map_resource(struct rte_pci_device *dev)
maps[i].offset = reg.offset;
maps[i].size = reg.size;
dev->mem_resource[i].addr = bar_addr;
+ dev->mem_resource[i].len = reg.size;
}
/* if secondary process, do not set up interrupts */
I still think this part is wrong.
The length should have been populated by pci_parse_sysfs_resource().
Are you sure this length is 0 ?
Can you do give me the result of cat
/sys/bus/pci/devices/$your_device_pci_address/resource ?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2014-11-25 10:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 16:30 [dpdk-dev] [PATCH v4 0/6] Cisco Systems Inc. VIC Ethernet PMD - " Sujith Sankar
2014-11-25 10:05 ` David Marchand
2014-11-25 10:50 ` Sujith Sankar (ssujith)
2014-11-25 16:30 ` [dpdk-dev] [PATCH v4 1/6] ENIC PMD License Sujith Sankar
2014-11-25 16:30 ` [dpdk-dev] [PATCH v4 2/6] ENIC PMD Makefile Sujith Sankar
2014-11-25 16:30 ` [dpdk-dev] [PATCH v4 3/6] VNIC common code partially shared with ENIC kernel mode driver Sujith Sankar
2014-11-25 16:30 ` [dpdk-dev] [PATCH v4 4/6] ENIC PMD specific code Sujith Sankar
2014-11-25 16:30 ` [dpdk-dev] [PATCH v4 5/6] DPDK-ENIC PMD interface Sujith Sankar
2014-11-25 16:30 ` [dpdk-dev] [PATCH v4 6/6] DPDK changes for accommodating ENIC PMD Sujith Sankar
2014-11-25 10:02 ` David Marchand
2014-11-25 10:46 ` Sujith Sankar (ssujith) [this message]
2014-11-25 11:47 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D09A5A39.28A10%ssujith@cisco.com \
--to=ssujith@cisco.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=prrao@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).