DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Prasad Rao \(prrao\)" <prrao@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v5 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD
Date: Tue, 25 Nov 2014 17:00:27 +0000	[thread overview]
Message-ID: <D09AB363.28AD3%ssujith@cisco.com> (raw)
In-Reply-To: <CALwxeUs-rK2hQ_ymsFrb=eQGRyGX+h8sMRKAkBveUv2AOTYXwg@mail.gmail.com>

Thanks David.
I shall rectify those.

Regards,
-Sujith

From: David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.com>>
Date: Tuesday, 25 November 2014 8:58 pm
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com<mailto:ssujith@cisco.com>>
Cc: "dev@dpdk.org<mailto:dev@dpdk.org>" <dev@dpdk.org<mailto:dev@dpdk.org>>, "Prasad Rao (prrao)" <prrao@cisco.com<mailto:prrao@cisco.com>>
Subject: Re: [dpdk-dev] [PATCH v5 0/6] enicpmd: Cisco Systems Inc. VIC Ethernet PMD

Sujith,

- Sorry, I still have one problem with the patchset.

Your patches do not pass checkpatch.
I can see indent problems, trailing whitespaces etc...

Can you fix this ?


- Also, look at patch 6/6, there is a problem with the build option (see my other mail).


Thanks for the effort.

--
David Marchand

On Wed, Nov 26, 2014 at 12:45 AM, Sujith Sankar <ssujith@cisco.com<mailto:ssujith@cisco.com>> wrote:
ENIC PMD is the poll-mode driver for the Cisco Systems Inc. VIC to be
used with DPDK suite.

Sujith Sankar (6):
  enicpmd: License text
  enicpmd: Makefile
  enicpmd: VNIC common code partially shared with ENIC kernel mode
    driver
  enicpmd: pmd specific code
  enicpmd: DPDK-ENIC PMD interface
  enicpmd: DPDK changes for accommodating ENIC PMD

 config/common_linuxapp                   |    5 +
 lib/Makefile                             |    1 +
 lib/librte_pmd_enic/LICENSE              |   27 +
 lib/librte_pmd_enic/Makefile             |   67 ++
 lib/librte_pmd_enic/enic.h               |  157 ++++
 lib/librte_pmd_enic/enic_clsf.c          |  244 ++++++
 lib/librte_pmd_enic/enic_compat.h        |  142 ++++
 lib/librte_pmd_enic/enic_etherdev.c      |  613 +++++++++++++++
 lib/librte_pmd_enic/enic_main.c          | 1266 ++++++++++++++++++++++++++++++
 lib/librte_pmd_enic/enic_res.c           |  221 ++++++
 lib/librte_pmd_enic/enic_res.h           |  168 ++++
 lib/librte_pmd_enic/vnic/cq_desc.h       |  126 +++
 lib/librte_pmd_enic/vnic/cq_enet_desc.h  |  261 ++++++
 lib/librte_pmd_enic/vnic/rq_enet_desc.h  |   76 ++
 lib/librte_pmd_enic/vnic/vnic_cq.c       |  117 +++
 lib/librte_pmd_enic/vnic/vnic_cq.h       |  152 ++++
 lib/librte_pmd_enic/vnic/vnic_dev.c      | 1063 +++++++++++++++++++++++++
 lib/librte_pmd_enic/vnic/vnic_dev.h      |  202 +++++
 lib/librte_pmd_enic/vnic/vnic_devcmd.h   |  774 ++++++++++++++++++
 lib/librte_pmd_enic/vnic/vnic_enet.h     |   78 ++
 lib/librte_pmd_enic/vnic/vnic_intr.c     |   83 ++
 lib/librte_pmd_enic/vnic/vnic_intr.h     |  126 +++
 lib/librte_pmd_enic/vnic/vnic_nic.h      |   88 +++
 lib/librte_pmd_enic/vnic/vnic_resource.h |   97 +++
 lib/librte_pmd_enic/vnic/vnic_rq.c       |  246 ++++++
 lib/librte_pmd_enic/vnic/vnic_rq.h       |  282 +++++++
 lib/librte_pmd_enic/vnic/vnic_rss.c      |   85 ++
 lib/librte_pmd_enic/vnic/vnic_rss.h      |   61 ++
 lib/librte_pmd_enic/vnic/vnic_stats.h    |   86 ++
 lib/librte_pmd_enic/vnic/vnic_wq.c       |  245 ++++++
 lib/librte_pmd_enic/vnic/vnic_wq.h       |  283 +++++++
 lib/librte_pmd_enic/vnic/wq_enet_desc.h  |  114 +++
 mk/rte.app.mk<http://rte.app.mk>                            |    4 +
 33 files changed, 7560 insertions(+)
 create mode 100644 lib/librte_pmd_enic/LICENSE
 create mode 100644 lib/librte_pmd_enic/Makefile
 create mode 100644 lib/librte_pmd_enic/enic.h
 create mode 100644 lib/librte_pmd_enic/enic_clsf.c
 create mode 100644 lib/librte_pmd_enic/enic_compat.h
 create mode 100644 lib/librte_pmd_enic/enic_etherdev.c
 create mode 100644 lib/librte_pmd_enic/enic_main.c
 create mode 100644 lib/librte_pmd_enic/enic_res.c
 create mode 100644 lib/librte_pmd_enic/enic_res.h
 create mode 100644 lib/librte_pmd_enic/vnic/cq_desc.h
 create mode 100644 lib/librte_pmd_enic/vnic/cq_enet_desc.h
 create mode 100644 lib/librte_pmd_enic/vnic/rq_enet_desc.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_cq.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_cq.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_dev.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_dev.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_devcmd.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_enet.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_intr.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_intr.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_nic.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_resource.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_rq.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_rq.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_rss.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_rss.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_stats.h
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_wq.c
 create mode 100644 lib/librte_pmd_enic/vnic/vnic_wq.h
 create mode 100644 lib/librte_pmd_enic/vnic/wq_enet_desc.h

--
1.9.1

  reply	other threads:[~2014-11-25 16:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 23:45 Sujith Sankar
2014-11-25 15:05 ` Neil Horman
2014-11-25 15:28 ` David Marchand
2014-11-25 17:00   ` Sujith Sankar (ssujith) [this message]
2014-11-25 23:45 ` [dpdk-dev] [PATCH v5 1/6] enicpmd: License text Sujith Sankar
2014-11-25 23:45 ` [dpdk-dev] [PATCH v5 2/6] enicpmd: Makefile Sujith Sankar
2014-11-25 23:45 ` [dpdk-dev] [PATCH v5 3/6] enicpmd: VNIC common code partially shared with ENIC kernel mode driver Sujith Sankar
2014-11-25 23:45 ` [dpdk-dev] [PATCH v5 4/6] enicpmd: pmd specific code Sujith Sankar
2014-11-25 23:45 ` [dpdk-dev] [PATCH v5 5/6] enicpmd: DPDK-ENIC PMD interface Sujith Sankar
2014-11-25 23:45 ` [dpdk-dev] [PATCH v5 6/6] enicpmd: DPDK changes for accommodating ENIC PMD Sujith Sankar
2014-11-25 15:25   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D09AB363.28AD3%ssujith@cisco.com \
    --to=ssujith@cisco.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    --cc=prrao@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).