DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config: disable enic driver on Power
Date: Thu, 27 Nov 2014 14:52:51 +0000	[thread overview]
Message-ID: <D09D37E4.28F62%ssujith@cisco.com> (raw)
In-Reply-To: <CALwxeUsVP2btL3cRebCP3trVO-6sigNroYdx0DWkSqjeGrQy7A@mail.gmail.com>

Hi David,

I shall take a look at it get back soon after some tests.
One point here is that ENICPMD will be used only on UCS servers (as Cisco VIC cards are shipped only with them) and  they are all x86_64.  So you could turn it off for all the other architectures.

Thanks,
-Sujith

From: David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.com>>
Date: Thursday, 27 November 2014 5:14 pm
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com<mailto:ssujith@cisco.com>>
Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com<mailto:chaozhu@linux.vnet.ibm.com>>, "dev@dpdk.org<mailto:dev@dpdk.org>" <dev@dpdk.org<mailto:dev@dpdk.org>>
Subject: Re: [PATCH] config: disable enic driver on Power

Hello Sujith,

Please can you have a look at this in your enic driver ?
I find it weird to use these types while we could use <stdint.h> types such as uint8_t etc...

Thanks.

--
David Marchand


On Thu, Nov 27, 2014 at 12:42 PM, David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.com>> wrote:
enic driver is giving trouble because of non-standard types :

  CC enic_res.o
In file included from
lib/librte_pmd_enic/enic_res.c:36:0:
lib/librte_pmd_enic/enic_compat.h:92:1: error: unknown type name ‘u_int32_t’
 static inline u_int32_t ioread32(volatile void *addr)
 ^

Disable it on Power for now.

Signed-off-by: David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.com>>
---
 config/defconfig_ppc_64-power8-linuxapp-gcc |    1 +
 1 file changed, 1 insertion(+)

diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/defconfig_ppc_64-power8-linuxapp-gcc
index cefb3be..48018c3 100644
--- a/config/defconfig_ppc_64-power8-linuxapp-gcc
+++ b/config/defconfig_ppc_64-power8-linuxapp-gcc
@@ -52,6 +52,7 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
 CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
 CONFIG_RTE_LIBRTE_VMXNET3_PMD=n
 CONFIG_RTE_LIBRTE_PMD_BOND=n
+CONFIG_RTE_LIBRTE_ENIC_PMD=n

 # This following libraries are not available on Power. So they're turned off.
 CONFIG_RTE_LIBRTE_LPM=n
--
1.7.10.4

  reply	other threads:[~2014-11-27 14:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 11:42 David Marchand
2014-11-27 11:44 ` David Marchand
2014-11-27 14:52   ` Sujith Sankar (ssujith) [this message]
2014-11-27 18:16 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D09D37E4.28F62%ssujith@cisco.com \
    --to=ssujith@cisco.com \
    --cc=david.marchand@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).