[dpdk-dev] [PATCH] config: disable enic driver on Power

[dpdk-dev] [PATCH] config: disable enic driver on Power

[David Marchand]

enic driver is giving trouble because of non-standard types :

  CC enic_res.o
In file included from
lib/librte_pmd_enic/enic_res.c:36:0:
lib/librte_pmd_enic/enic_compat.h:92:1: error: unknown type name ‘u_int32_t’
 static inline u_int32_t ioread32(volatile void *addr)
 ^

Disable it on Power for now.

Signed-off-by: David Marchand <david.marchand@6wind.com>
---
 config/defconfig_ppc_64-power8-linuxapp-gcc |    1 +
 1 file changed, 1 insertion(+)

diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/defconfig_ppc_64-power8-linuxapp-gcc
index cefb3be..48018c3 100644
--- a/config/defconfig_ppc_64-power8-linuxapp-gcc
+++ b/config/defconfig_ppc_64-power8-linuxapp-gcc
@@ -52,6 +52,7 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
 CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
 CONFIG_RTE_LIBRTE_VMXNET3_PMD=n
 CONFIG_RTE_LIBRTE_PMD_BOND=n
+CONFIG_RTE_LIBRTE_ENIC_PMD=n
 
 # This following libraries are not available on Power. So they're turned off.
 CONFIG_RTE_LIBRTE_LPM=n
-- 
1.7.10.4

Re: [dpdk-dev] [PATCH] config: disable enic driver on Power

[David Marchand]

Hello Sujith,

Please can you have a look at this in your enic driver ?
I find it weird to use these types while we could use <stdint.h> types such
as uint8_t etc...

Thanks.

-- 
David Marchand


On Thu, Nov 27, 2014 at 12:42 PM, David Marchand <david.marchand@6wind.com>
wrote:

> enic driver is giving trouble because of non-standard types :
>
>   CC enic_res.o
> In file included from
> lib/librte_pmd_enic/enic_res.c:36:0:
> lib/librte_pmd_enic/enic_compat.h:92:1: error: unknown type name
> ‘u_int32_t’
>  static inline u_int32_t ioread32(volatile void *addr)
>  ^
>
> Disable it on Power for now.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  config/defconfig_ppc_64-power8-linuxapp-gcc |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc
> b/config/defconfig_ppc_64-power8-linuxapp-gcc
> index cefb3be..48018c3 100644
> --- a/config/defconfig_ppc_64-power8-linuxapp-gcc
> +++ b/config/defconfig_ppc_64-power8-linuxapp-gcc
> @@ -52,6 +52,7 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
>  CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
>  CONFIG_RTE_LIBRTE_VMXNET3_PMD=n
>  CONFIG_RTE_LIBRTE_PMD_BOND=n
> +CONFIG_RTE_LIBRTE_ENIC_PMD=n
>
>  # This following libraries are not available on Power. So they're turned
> off.
>  CONFIG_RTE_LIBRTE_LPM=n
> --
> 1.7.10.4
>
>

Re: [dpdk-dev] [PATCH] config: disable enic driver on Power

[Sujith Sankar (ssujith)]

Hi David,

I shall take a look at it get back soon after some tests.
One point here is that ENICPMD will be used only on UCS servers (as Cisco VIC cards are shipped only with them) and  they are all x86_64.  So you could turn it off for all the other architectures.

Thanks,
-Sujith

From: David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.com>>
Date: Thursday, 27 November 2014 5:14 pm
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com<mailto:ssujith@cisco.com>>
Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com<mailto:chaozhu@linux.vnet.ibm.com>>, "dev@dpdk.org<mailto:dev@dpdk.org>" <dev@dpdk.org<mailto:dev@dpdk.org>>
Subject: Re: [PATCH] config: disable enic driver on Power

Hello Sujith,

Please can you have a look at this in your enic driver ?
I find it weird to use these types while we could use <stdint.h> types such as uint8_t etc...

Thanks.

--
David Marchand


On Thu, Nov 27, 2014 at 12:42 PM, David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.com>> wrote:
enic driver is giving trouble because of non-standard types :

  CC enic_res.o
In file included from
lib/librte_pmd_enic/enic_res.c:36:0:
lib/librte_pmd_enic/enic_compat.h:92:1: error: unknown type name ‘u_int32_t’
 static inline u_int32_t ioread32(volatile void *addr)
 ^

Disable it on Power for now.

Signed-off-by: David Marchand <david.marchand@6wind.com<mailto:david.marchand@6wind.com>>
---
 config/defconfig_ppc_64-power8-linuxapp-gcc |    1 +
 1 file changed, 1 insertion(+)

diff --git a/config/defconfig_ppc_64-power8-linuxapp-gcc b/config/defconfig_ppc_64-power8-linuxapp-gcc
index cefb3be..48018c3 100644
--- a/config/defconfig_ppc_64-power8-linuxapp-gcc
+++ b/config/defconfig_ppc_64-power8-linuxapp-gcc
@@ -52,6 +52,7 @@ CONFIG_RTE_LIBRTE_I40E_PMD=n
 CONFIG_RTE_LIBRTE_VIRTIO_PMD=n
 CONFIG_RTE_LIBRTE_VMXNET3_PMD=n
 CONFIG_RTE_LIBRTE_PMD_BOND=n
+CONFIG_RTE_LIBRTE_ENIC_PMD=n

 # This following libraries are not available on Power. So they're turned off.
 CONFIG_RTE_LIBRTE_LPM=n
--
1.7.10.4

Re: [dpdk-dev] [PATCH] config: disable enic driver on Power

[Thomas Monjalon]

> enic driver is giving trouble because of non-standard types :
> 
>   CC enic_res.o
> In file included from
> lib/librte_pmd_enic/enic_res.c:36:0:
> lib/librte_pmd_enic/enic_compat.h:92:1: error: unknown type name ‘u_int32_t’
>  static inline u_int32_t ioread32(volatile void *addr)
>  ^
> 
> Disable it on Power for now.
> 
> Signed-off-by: David Marchand <david.marchand@6wind.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied

-- 
Thomas