From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h
Date: Fri, 28 Nov 2014 02:31:41 +0000 [thread overview]
Message-ID: <D09DDC03.28FC9%ssujith@cisco.com> (raw)
In-Reply-To: <3873403.PSCWCNKvtK@xps13>
On 28/11/14 1:54 am, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>2014-11-27 19:01, Thomas Monjalon:
>> 2014-11-27 22:44, Sujith Sankar:
>> > Inclusion of vfio.h was giving compilation errors if kernel version
>>is less
>> > than 3.6.0 and if RTE_EAL_VFIO was on in config.
>> >
>> > Replaced inclusion of vfio.h with eal_vfio.h and replaced
>>RTE_EAL_VFIO with
>> > VFIO_PRESENT in enicpmd code.
>>
>> You should add
>> Reported-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
I shall take care of this from now on.
>>
>> > Signed-off-by: Sujith Sankar <ssujith@cisco.com>
>> [...]
>> > CFLAGS += -I$(RTE_SDK)/lib/librte_hash/
>>-I$(RTE_SDK)/lib/librte_pmd_enic/vnic/
>> > CFLAGS += -I$(RTE_SDK)/lib/librte_pmd_enic/
>> > +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
>> > CFLAGS += -O3 -Wno-deprecated
>>
>> I think -I$(RTE_SDK)/lib/librte_hash/ and
>>-I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
>> are not needed.
>>
>> I'll fix it if you confirm.
You¹re right.
>
>Applied with above comments.
Thank you Thomas !
>
>--
>Thomas
next prev parent reply other threads:[~2014-11-28 2:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 17:14 Sujith Sankar
2014-11-27 17:22 ` Sujith Sankar (ssujith)
2014-11-27 18:01 ` Thomas Monjalon
2014-11-27 20:24 ` Thomas Monjalon
2014-11-28 2:31 ` Sujith Sankar (ssujith) [this message]
2014-11-28 2:09 ` Qiu, Michael
2014-11-28 14:16 ` Thomas Monjalon
2014-12-02 7:10 ` Qiu, Michael
2014-11-28 14:56 ` Neil Horman
2014-12-02 7:24 ` Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D09DDC03.28FC9%ssujith@cisco.com \
--to=ssujith@cisco.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).