From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) by dpdk.org (Postfix) with ESMTP id 4C9AB1518 for ; Fri, 28 Nov 2014 03:31:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1129; q=dns/txt; s=iport; t=1417141905; x=1418351505; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=oNYWKJ+PDFlB7P0P2boLHvmJlI/rHiFVsoNwkHAsoZU=; b=BUudXC1VOxGXYkLYeorDCgrEMegXAEqiMSLwH50FXekhRrhdS+7lfbMK WOvqOh52t6EEojf5vX+3le0U9beVV15MhtuTJ9nRDCtvSOdzgwaSb8XFo pRoQaXvotDKgyfLhY1TE4G81tG2wOfMIIeZmGEVdkGSeqVv+Hs7ubkYF9 Y=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgcFAEHdd1StJA2D/2dsb2JhbABbgwaBLc4PAoEJFgEBAQEBfYQDAQEEeRACAQhGMiUCBA4FiEDRcgEBAQEBAQEBAQEBAQEBAQEBAQEZkHsHhE0BBItohFGCLIwclxyDfG+BSIECAQEB X-IronPort-AV: E=Sophos;i="5.07,473,1413244800"; d="scan'208";a="100791034" Received: from alln-core-1.cisco.com ([173.36.13.131]) by alln-iport-4.cisco.com with ESMTP; 28 Nov 2014 02:31:43 +0000 Received: from xhc-rcd-x04.cisco.com (xhc-rcd-x04.cisco.com [173.37.183.78]) by alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id sAS2VgIn023550 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 28 Nov 2014 02:31:43 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.173]) by xhc-rcd-x04.cisco.com ([fe80::200:5efe:173.37.183.34%12]) with mapi id 14.03.0195.001; Thu, 27 Nov 2014 20:31:42 -0600 From: "Sujith Sankar (ssujith)" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h Thread-Index: AQHQCmXPoRwfNA9xBE+MVOoZyzXf/px1KEIAgAAn0ACAAMLSgA== Date: Fri, 28 Nov 2014 02:31:41 +0000 Message-ID: References: <1417108480-28341-1-git-send-email-ssujith@cisco.com> <2232586.GRrg2Bq1yj@xps13> <3873403.PSCWCNKvtK@xps13> In-Reply-To: <3873403.PSCWCNKvtK@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.65.69.66] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <42E7832C531103438714ACE4197E63CB@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] enicpmd: compilation error during inclusion of vfio.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 02:31:44 -0000 On 28/11/14 1:54 am, "Thomas Monjalon" wrote: >2014-11-27 19:01, Thomas Monjalon: >> 2014-11-27 22:44, Sujith Sankar: >> > Inclusion of vfio.h was giving compilation errors if kernel version >>is less >> > than 3.6.0 and if RTE_EAL_VFIO was on in config. >> >=20 >> > Replaced inclusion of vfio.h with eal_vfio.h and replaced >>RTE_EAL_VFIO with >> > VFIO_PRESENT in enicpmd code. >>=20 >> You should add >> Reported-by: Pawel Wodkowski I shall take care of this from now on. >>=20 >> > Signed-off-by: Sujith Sankar >> [...] >> > CFLAGS +=3D -I$(RTE_SDK)/lib/librte_hash/ >>-I$(RTE_SDK)/lib/librte_pmd_enic/vnic/ >> > CFLAGS +=3D -I$(RTE_SDK)/lib/librte_pmd_enic/ >> > +CFLAGS +=3D -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/ >> > CFLAGS +=3D -O3 -Wno-deprecated >>=20 >> I think -I$(RTE_SDK)/lib/librte_hash/ and >>-I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/ >> are not needed. >>=20 >> I'll fix it if you confirm. You=B9re right. > >Applied with above comments. Thank you Thomas ! > >--=20 >Thomas