Re: [dpdk-dev] [PATCH v2] enicpmd: replace the type u_int* with uint* to remove compilation errors on a few platforms

["Sujith Sankar (ssujith)" <ssujith@cisco.com>]

On 28/11/14 9:36 pm, "Bruce Richardson" <bruce.richardson@intel.com> wrote:

>On Fri, Nov 28, 2014 at 04:01:00PM +0000, Sujith Sankar (ssujith) wrote:
>> 
>> 
>> On 28/11/14 9:22 pm, "Bruce Richardson" <bruce.richardson@intel.com>
>>wrote:
>> 
>> >On Fri, Nov 28, 2014 at 03:08:19PM +0530, Sujith Sankar wrote:
>> >> ENIC PMD was giving compilation errors on ppc_64-power8-linuxapp-gcc
>> >>because
>> >> of types such as u_int32_t.  This patch replaces all those with
>> >>uint32_t and
>> >> similar ones.
>> >> 
>> >> Reported-by: David Marchand <david.marchand@6wind.com>
>> >> Signed-off-by: Sujith Sankar <ssujith@cisco.com>
>> >
>> >Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>> >
>> >This patch helps out with getting a clang compile on BSD. However, one
>> >error
>> >and a number of warnings remain that should be looked at in another
>>patch.
>> >The error is:
>> >
>> >dpdk.org/lib/librte_pmd_enic/enic_main.c:435:3: fatal error: non-void
>> >function 'enic_rq_indicate_buf' should return a value [-Wreturn-type]
>> >                return;
>> 
>> Bruce, thanks for the comment.  I¹ve not built enicpmd using clang
>> compiler.
>> I shall setup a BSD build with clang compiler and send a patch with
>> necessary fixes.
>> Could you please let me know the versions and flavours that you are
>>using?
>> 
>> Thanks,
>> -Sujith
>>
>Clang on a linux install gives the same errors, as far as I can see. What
>I'm using is clang 3.4 on Fedora 20, and clang 3.3 on FreeBSD 10.
>
>If you like, if you just fix clang on Linux compilation, I can check for
>any
>additional errors on FreeBSD and get back to you on them, rather than you
>having
>to install a FreeBSD system right away.

Thank you Bruce.
I shall start with Clang on Linux and send the patch soon.

>
>/Bruce