From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alln-iport-2.cisco.com (alln-iport-2.cisco.com [173.37.142.89]) by dpdk.org (Postfix) with ESMTP id 057998040 for ; Wed, 3 Dec 2014 16:10:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1151; q=dns/txt; s=iport; t=1417619410; x=1418829010; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zFf9aJCp5XJfceOIfj/ndj6CrqoRg/sqxkImOmxOzRY=; b=c7YpU3JCamyLwuSLRQ+otRWlSd10Je741RbQ2WIxjRwN2yDFEmTHygDn o0yXNASw1OYw4oie1Q1KdqtAWFxlYqMqfq95yvPFQnMAX0F/KeG57zbnH x3gvZ63TQFP/GIZhrLQWvtRczblUEKufecLN2lfhBsB4120JVOUOvwfLP k=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AkEFAGgBf1StJA2N/2dsb2JhbABagwaBKgTMXAKBFRYBAQEBAX2EAwEBBDo/EAIBCDYQMiUCBA4FiD7WDAEBAQEBAQEBAQEBAQEBAQEBAQEBAReQZgeEQgEEkA+KSoEijwuDaYN4b4FFgQABAQE X-IronPort-AV: E=Sophos;i="5.07,508,1413244800"; d="scan'208";a="102300569" Received: from alln-core-8.cisco.com ([173.36.13.141]) by alln-iport-2.cisco.com with ESMTP; 03 Dec 2014 15:10:07 +0000 Received: from xhc-rcd-x04.cisco.com (xhc-rcd-x04.cisco.com [173.37.183.78]) by alln-core-8.cisco.com (8.14.5/8.14.5) with ESMTP id sB3FA5k3024354 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 3 Dec 2014 15:10:05 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.173]) by xhc-rcd-x04.cisco.com ([fe80::200:5efe:173.37.183.34%12]) with mapi id 14.03.0195.001; Wed, 3 Dec 2014 09:10:05 -0600 From: "Sujith Sankar (ssujith)" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] enic: fix warnings Thread-Index: AQHQDkCuktcPIMZrUki/JI7pjsyY85x+tewA//+nPwCAAF2RAA== Date: Wed, 3 Dec 2014 15:10:05 +0000 Message-ID: References: <1417532360-8568-1-git-send-email-thomas.monjalon@6wind.com> <2126129.v20IaaVbE9@xps13> In-Reply-To: <2126129.v20IaaVbE9@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.65.35.154] Content-Type: text/plain; charset="us-ascii" Content-ID: <3B59D9BD11ED024EACECE7AC84FE0AF3@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] enic: fix warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2014 15:10:09 -0000 On 03/12/14 8:35 pm, "Thomas Monjalon" wrote: >2014-12-03 14:52, Sujith Sankar: >>=20 >> On 02/12/14 8:29 pm, "Thomas Monjalon" >>wrote: >>=20 >> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set >> >in the Makefile. But they appear with toolchains that enforce more >>checks. >> > >> >-Wno-deprecated seems useless. >> >-Wno-strict-aliasing is added to avoid false positives. >> > >> >This patch cleans up unused variable, unused functions, wrong types, >> >static declarations, etc. A lot of functions have unused parameters; >> >it suggests that more clean-up could be needed. >>=20 >> I shall look at it when I pull these changes to my repo. >> What other toolchains did you check with? > >It's tested with many distributions, example CentOS 6. >But adding the warnings as in this patch should be enough to test with >any toolchain. Thanks Thomas. I shall look at the unused vars and get back with clean-up patch. Your patch looks good. And I did a quick sanity test on my server, which went through fine. -Sujith > >--=20 >Thomas