From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) by dpdk.org (Postfix) with ESMTP id A539E7EB0 for ; Thu, 4 Dec 2014 11:58:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1322; q=dns/txt; s=iport; t=1417690702; x=1418900302; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Jg6lYmdtMUAaay07oYy+r7HC3jbwMxznS7mpmpx6QLE=; b=WWa1nC930hfD/kvgsAP/NAJxMpWvngzBJRlV3KlGT7qBWQoxFzb8F3Ie lrJbCX4L1PcGYPntjBZhdIP+4mc2PSCuOivga4By0CzgCqqhpmlAFCedi OW1JnJlBkJXUvnT3+d+EmzhXswEG9hAnfAmdXdg3P87MS1XEObha/j9qj g=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AikFAAs+gFStJA2G/2dsb2JhbABagwaBKgTMZgKBGBYBAQEBAX2EAwEBBDo/EAIBCDYQMiUCBA4FiD7WJgEBAQEBAQEBAQEBAQEBAQEBAQEZkGYHhEIBBJAQikqUF4N5b4FFgQABAQE X-IronPort-AV: E=Sophos;i="5.07,514,1413244800"; d="scan'208";a="377498735" Received: from alln-core-12.cisco.com ([173.36.13.134]) by rcdn-iport-8.cisco.com with ESMTP; 04 Dec 2014 10:58:19 +0000 Received: from xhc-aln-x09.cisco.com (xhc-aln-x09.cisco.com [173.36.12.83]) by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id sB4AwIPl008934 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 4 Dec 2014 10:58:18 GMT Received: from xmb-aln-x07.cisco.com ([169.254.2.173]) by xhc-aln-x09.cisco.com ([173.36.12.83]) with mapi id 14.03.0195.001; Thu, 4 Dec 2014 04:58:18 -0600 From: "Sujith Sankar (ssujith)" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] enic: fix warnings Thread-Index: AQHQDkCuktcPIMZrUki/JI7pjsyY85x//roA//+pB4CAAF7vAA== Date: Thu, 4 Dec 2014 10:58:17 +0000 Message-ID: References: <1417532360-8568-1-git-send-email-thomas.monjalon@6wind.com> <2887963.q9hPn3S3sv@xps13> In-Reply-To: <2887963.q9hPn3S3sv@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.9.131030 x-originating-ip: [10.127.148.145] Content-Type: text/plain; charset="us-ascii" Content-ID: <17EEC930AB802D4DBCB36E81E4CFCC4D@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] enic: fix warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Dec 2014 10:58:23 -0000 On 04/12/14 4:18 pm, "Thomas Monjalon" wrote: >2014-12-04 10:29, Sujith Sankar: >>=20 >> On 02/12/14 8:29 pm, "Thomas Monjalon" >>wrote: >>=20 >> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set >> >in the Makefile. But they appear with toolchains that enforce more >>checks. >> > >> >-Wno-deprecated seems useless. >> >-Wno-strict-aliasing is added to avoid false positives. >> > >> >This patch cleans up unused variable, unused functions, wrong types, >> >static declarations, etc. A lot of functions have unused parameters; >> >it suggests that more clean-up could be needed. >> > >> >Signed-off-by: Thomas Monjalon >> >--- >> > lib/librte_pmd_enic/Makefile | 3 +- >> > lib/librte_pmd_enic/enic.h | 4 +- >> > lib/librte_pmd_enic/enic_ethdev.c | 20 ++++----- >>=20 >> Thomas, the name of this file got modified. It was enic_etherdev.c in >>my >> submission. >> Any idea how this happened? I do not remember seeing a request for >>this. > >Yes, sorry I forgot to request it. >I renamed the file to be consistent with other drivers. >Everywhere in DPDK we talk about ethdev for device operations, not >etherdev. Ok.=20 Thank you. > >--=20 >Thomas