From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ssujith@cisco.com>
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91])
 by dpdk.org (Postfix) with ESMTP id A1EB8683A
 for <dev@dpdk.org>; Tue, 16 Dec 2014 05:12:43 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
 d=cisco.com; i=@cisco.com; l=1632; q=dns/txt; s=iport;
 t=1418703163; x=1419912763;
 h=from:to:cc:subject:date:message-id:references:
 in-reply-to:content-id:content-transfer-encoding: mime-version;
 bh=xkO3xKzOEiOaunUQUVxpfpWbIrtD5HktBVJAm2MENNo=;
 b=Hy6291xknaZgf/RwfNFY+nUnYtmBNeP2as8ad+wfxlb1A/etWqCWA070
 3BaWV4n0865oR8dXWj8qhPkJ0U5NaCGlNWo1tmQPrUC9j2UUYK4g2MHb7
 1mE6n7tNdCfQSwUuiXIqT/B1RLcfC4D1XIS1XxDHyt0rF+R/uLN6j2SD0 4=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AoAFAO2vj1StJA2G/2dsb2JhbABagwaBKgTLYgKBJBYBAQEBAX2EDQEBAwE6PxACAQg2EDIlAgQOBYgkCNQtAQEBAQEBAQEBAQEBAQEBAQEBARmPcgeEKQEEjgKIb4ELgl6FbIdiIoNsboFFfgEBAQ
X-IronPort-AV: E=Sophos;i="5.07,584,1413244800"; d="scan'208";a="106037970"
Received: from alln-core-12.cisco.com ([173.36.13.134])
 by alln-iport-4.cisco.com with ESMTP; 16 Dec 2014 04:12:42 +0000
Received: from xhc-rcd-x15.cisco.com (xhc-rcd-x15.cisco.com [173.37.183.89])
 by alln-core-12.cisco.com (8.14.5/8.14.5) with ESMTP id sBG4Cgf2004464
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL);
 Tue, 16 Dec 2014 04:12:42 GMT
Received: from xmb-aln-x07.cisco.com ([169.254.2.173]) by
 xhc-rcd-x15.cisco.com ([173.37.183.89]) with mapi id 14.03.0195.001; Mon, 15
 Dec 2014 22:12:42 -0600
From: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT
Thread-Index: AQHQFeRr1xRBtyDx5UWdyYsoypZs7pyRtUyAgACszQA=
Date: Tue, 16 Dec 2014 04:12:41 +0000
Message-ID: <D0B5AE42.2A9E2%ssujith@cisco.com>
References: <1418372303-31565-1-git-send-email-ssujith@cisco.com>
 <5911790.4rCTPaIceN@xps13>
In-Reply-To: <5911790.4rCTPaIceN@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
user-agent: Microsoft-MacOutlook/14.3.9.131030
x-originating-ip: [10.127.149.83]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A20FBF2AE24F084E80BFAC21AE83A032@emea.cisco.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] enic: corrected the usage of VFIO_PRESENT
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2014 04:12:44 -0000


On 16/12/14 4:54 am, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:

>2014-12-12 13:48, Sujith Sankar:
>> This patch corrects the usage of the flag VFIO_PRESENT in enic driver.
>
>Please, could you explain why the flag VFIO_PRESENT was not well used?

Without including eal_vfio.h, VFIO_PRESENT is not available in enic.
Hence VFIO specific code in enic was not getting compiled and some errors
were generated during run-time.

>
>> This has uncovered a few warnings, and this patch corrects those too.
>[...]
>> --- a/lib/librte_pmd_enic/enic_main.c
>> +++ b/lib/librte_pmd_enic/enic_main.c
>> @@ -39,6 +39,7 @@
>>  #include <sys/mman.h>
>>  #include <fcntl.h>
>>  #include <libgen.h>
>> +#include <sys/ioctl.h>
>> =20
>>  #include <rte_pci.h>
>>  #include <rte_memzone.h>
>> @@ -46,6 +47,7 @@
>>  #include <rte_mbuf.h>
>>  #include <rte_string_fns.h>
>>  #include <rte_ethdev.h>
>> +#include <eal_vfio.h>
>
>This header was not designed to be included by PMDs.
>It will break compilation on BSD.

Is there an alternative to make VFIO_PRESENT available in enic?  Please
advise.

Thanks,
-Sujith

>
>>  #include "enic_compat.h"
>>  #include "enic.h"
>> @@ -561,6 +563,7 @@ enic_free_consistent(__rte_unused struct
>>rte_pci_device *hwdev,
>>  	/* Nothing to be done */
>>  }
>> =20
>> +#ifndef VFIO_PRESENT
>>  static void
>>  enic_intr_handler(__rte_unused struct rte_intr_handle *handle,
>>  	void *arg)
>> @@ -572,6 +575,7 @@ enic_intr_handler(__rte_unused struct
>>rte_intr_handle *handle,
>> =20
>>  	enic_log_q_error(enic);
>>  }
>> +#endif
>
>--=20
>Thomas